Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-19 Thread Damyan Ivanov
-=| Damyan Ivanov, 19.09.2018 04:55:54 + |=-
> -=| Xavier, 18.09.2018 22:58:48 +0200 |=-
> > [1]
> > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libnet-server-mail-perl.html)
> > [2] 
> > https://buildd.debian.org/status/package.php?p=libnet-server-mail-perl
> 
> The buildd used libio-socket-ssl-perl 2.059-1, which misses a lot of 
> openssl 1.1.1 fixes.
> 
> Perhaps bumping the (build) dependency to version 2.060-3 would help?
> 
> Hmm, the reproducible-builds log also shows 2.059-1, but I guess 
> bumping the version is still worth a try -- may be the failure is 
> hard to trigger.

That didn't work, and now I am able to make the test fail with 
a slightly different error:

t/starttls.t .. 
ok 1 - Accepted client for Test01: STARTTLS support
ok 2 - Accepted client for Test02: STARTTLS invalid parameters
ok 3 - Accepted client for Test03: STARTTLS handshake
# Error: TLS handshake failed SSL connect attempt failed error:1408F10B:SSL 
routines:ssl3_get_record:wrong version number at t/starttls.t line 117.
# kill 9, 24096 (server)
All 3 subtests passed 

Test Summary Report
---
t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
  Non-zero wait status: 9
  Parse errors: No plan found in TAP output

Looking at the test certificate, it has a 1024-bit key, which may be 
the root reason, although the error message above doesn't confirm 
that.

... and a minute later the test succeeds, after replacing 
t/certs/server-{cert,key}.pem with a senf-signed 4096-bit certificate


Will prepare a proper patch, forward it upstream and upload.


-- dam



Bug#908824: closed by Damyan Ivanov (Re: Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure)

2018-09-19 Thread Adrian Bunk
Control: reopen -1

Doesn't seem to work:
https://buildd.debian.org/status/package.php?p=libnet-server-mail-perl=sid

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-18 Thread Damyan Ivanov
-=| Xavier, 18.09.2018 22:58:48 +0200 |=-
> Le 15/09/2018 à 17:42, Damyan Ivanov a écrit :
> > Adding
> > $SIG{PIPE} = 'IGNORE';
> > at the start of the test seems to make it pass all the time.
> > 
> > I wonder if this is the correct fix.
> > 
> > -- Damyan
> 
> Hello,
> 
> I added this hook without success. "reproducible" builds well [1] but
> not buildd [2]
> 
> [1]
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libnet-server-mail-perl.html)
> [2] 
> https://buildd.debian.org/status/package.php?p=libnet-server-mail-perl

The buildd used libio-socket-ssl-perl 2.059-1, which misses a lot of 
openssl 1.1.1 fixes.

Perhaps bumping the (build) dependency to version 2.060-3 would help?

Hmm, the reproducible-builds log also shows 2.059-1, but I guess 
bumping the version is still worth a try -- may be the failure is hard 
to trigger.


-- dam



Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-18 Thread Xavier
Le 15/09/2018 à 17:42, Damyan Ivanov a écrit :
> -=| gregor herrmann, 14.09.2018 16:08:50 +0200 |=-
>> Control: tag -1 + unreproducible
>>
>> On Fri, 14 Sep 2018 16:52:38 +0300, Adrian Bunk wrote:
>>
>>> Source: libnet-server-mail-perl
>>> Version: 0.25-1
>>> Severity: serious
>>> Tags: ftbfs
>>>
>>> https://buildd.debian.org/status/fetch.php?pkg=libnet-server-mail-perl=all=0.25-1=1536904015=0
>>
>> Thanks for the bug report.
>>  
>>> ...
>>> Test Summary Report
>>> ---
>>> t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
>>>   Non-zero wait status: 9
>>>   Parse errors: No plan found in TAP output
>>> Files=4, Tests=33,  2 wallclock secs ( 0.05 usr  0.04 sys +  0.67 cusr  
>>> 0.20 csys =  0.96 CPU)
>>> Result: FAIL
>>> Failed 1/4 test programs. 0/33 subtests failed.
>>> make[1]: *** [Makefile:861: test_dynamic] Error 255
>>
>> Hm, the package builds for me.
>>
>>
>> The buildd failure is:
>>
>> # Error: TLS handshake failed SSL connect attempt failed at t/starttls.t 
>> line 116.
>> # kill 9, 17145 (server)
>> t/starttls.t .. 
>> ok 1 - Accepted client for Test01: STARTTLS support
>> ok 2 - Accepted client for Test02: STARTTLS invalid parameters
>> ok 3 - Accepted client for Test03: STARTTLS handshake
>> All 3 subtests passed 
>>
>>
>> Line 116 in the test is:
>>
>>112   my $rv =
>>113 IO::Socket::SSL->start_SSL( $s,
>>114   SSL_verify_mode => 
>> IO::Socket::SSL::SSL_VERIFY_NONE, );
>>115   
>>116   ( defined $rv && ref $rv eq 'IO::Socket::SSL' )
>>117 or die "TLS handshake failed >" . 
>> IO::Socket::SSL::errstr();
> 
> 
> Building the package several times (sbuild) passes here most of the 
> time and then:
> 
> # Error: Can't call method "peerhost" on an undefined value at t/starttls.t 
> line
>  131.
> # kill 9, 28330 (server)
> t/starttls.t .. 
> ok 1 - Accepted client for Test01: STARTTLS support
> ok 2 - Accepted client for Test02: STARTTLS invalid parameters
> ok 3 - Accepted client for Test03: STARTTLS handshake
> All 3 subtests passed 
> 
> Adding
> $SIG{PIPE} = 'IGNORE';
> at the start of the test seems to make it pass all the time.
> 
> I wonder if this is the correct fix.
> 
> -- Damyan

Hello,

I added this hook without success. "reproducible" builds well [1] but
not buildd [2]

[1]
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libnet-server-mail-perl.html)
[2] https://buildd.debian.org/status/package.php?p=libnet-server-mail-perl



Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-15 Thread Damyan Ivanov
-=| gregor herrmann, 14.09.2018 16:08:50 +0200 |=-
> Control: tag -1 + unreproducible
> 
> On Fri, 14 Sep 2018 16:52:38 +0300, Adrian Bunk wrote:
> 
> > Source: libnet-server-mail-perl
> > Version: 0.25-1
> > Severity: serious
> > Tags: ftbfs
> > 
> > https://buildd.debian.org/status/fetch.php?pkg=libnet-server-mail-perl=all=0.25-1=1536904015=0
> 
> Thanks for the bug report.
>  
> > ...
> > Test Summary Report
> > ---
> > t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
> >   Non-zero wait status: 9
> >   Parse errors: No plan found in TAP output
> > Files=4, Tests=33,  2 wallclock secs ( 0.05 usr  0.04 sys +  0.67 cusr  
> > 0.20 csys =  0.96 CPU)
> > Result: FAIL
> > Failed 1/4 test programs. 0/33 subtests failed.
> > make[1]: *** [Makefile:861: test_dynamic] Error 255
> 
> Hm, the package builds for me.
> 
> 
> The buildd failure is:
> 
> # Error: TLS handshake failed SSL connect attempt failed at t/starttls.t line 
> 116.
> # kill 9, 17145 (server)
> t/starttls.t .. 
> ok 1 - Accepted client for Test01: STARTTLS support
> ok 2 - Accepted client for Test02: STARTTLS invalid parameters
> ok 3 - Accepted client for Test03: STARTTLS handshake
> All 3 subtests passed 
> 
> 
> Line 116 in the test is:
> 
>112my $rv =
>113  IO::Socket::SSL->start_SSL( $s,
>114SSL_verify_mode => 
> IO::Socket::SSL::SSL_VERIFY_NONE, );
>115
>116( defined $rv && ref $rv eq 'IO::Socket::SSL' )
>117  or die "TLS handshake failed >" . 
> IO::Socket::SSL::errstr();


Building the package several times (sbuild) passes here most of the 
time and then:

# Error: Can't call method "peerhost" on an undefined value at t/starttls.t line
 131.
# kill 9, 28330 (server)
t/starttls.t .. 
ok 1 - Accepted client for Test01: STARTTLS support
ok 2 - Accepted client for Test02: STARTTLS invalid parameters
ok 3 - Accepted client for Test03: STARTTLS handshake
All 3 subtests passed 

Adding
$SIG{PIPE} = 'IGNORE';
at the start of the test seems to make it pass all the time.

I wonder if this is the correct fix.

-- Damyan



Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-14 Thread gregor herrmann
On Fri, 14 Sep 2018 17:29:59 +0200, Xavier wrote:

> I'll take a look to recent SSL problems (and Net::SMTP dependencies) to
> try to understand.

My first idea was that the problems with IO::Socket::SSL and OpenSSL
1.1.1 might be the cause for this failure; but as it doesn't happen
in my sid chroot I'm out of ideas ...
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Leonard Cohen: I'm Your Man


signature.asc
Description: Digital Signature


Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-14 Thread Xavier
Hi all,

looking at CPAN reports [1], no bug found by CPAN testers even on Gregor
machine [2] ;-) (except on Windows, which is a known problem).

I'll take a look to recent SSL problems (and Net::SMTP dependencies) to
try to understand.

Cheers,
Xavier

[1] http://matrix.cpantesters.org/?dist=Net-Server-Mail+0.25
[2]
http://www.cpantesters.org/cpan/report/85f34480-b7e8-11e8-913e-4c12c844a040



Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-14 Thread gregor herrmann
Control: tag -1 + unreproducible

On Fri, 14 Sep 2018 16:52:38 +0300, Adrian Bunk wrote:

> Source: libnet-server-mail-perl
> Version: 0.25-1
> Severity: serious
> Tags: ftbfs
> 
> https://buildd.debian.org/status/fetch.php?pkg=libnet-server-mail-perl=all=0.25-1=1536904015=0

Thanks for the bug report.
 
> ...
> Test Summary Report
> ---
> t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
>   Non-zero wait status: 9
>   Parse errors: No plan found in TAP output
> Files=4, Tests=33,  2 wallclock secs ( 0.05 usr  0.04 sys +  0.67 cusr  0.20 
> csys =  0.96 CPU)
> Result: FAIL
> Failed 1/4 test programs. 0/33 subtests failed.
> make[1]: *** [Makefile:861: test_dynamic] Error 255

Hm, the package builds for me.


The buildd failure is:

# Error: TLS handshake failed SSL connect attempt failed at t/starttls.t line 
116.
# kill 9, 17145 (server)
t/starttls.t .. 
ok 1 - Accepted client for Test01: STARTTLS support
ok 2 - Accepted client for Test02: STARTTLS invalid parameters
ok 3 - Accepted client for Test03: STARTTLS handshake
All 3 subtests passed 


Line 116 in the test is:

   112  my $rv =
   113IO::Socket::SSL->start_SSL( $s,
   114  SSL_verify_mode => IO::Socket::SSL::SSL_VERIFY_NONE, );
   115  
   116  ( defined $rv && ref $rv eq 'IO::Socket::SSL' )
   117or die "TLS handshake failed " . IO::Socket::SSL::errstr();



Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Frank Zappa: CHUCHA


signature.asc
Description: Digital Signature


Bug#908824: libnet-server-mail-perl FTBFS: t/starttls.t failure

2018-09-14 Thread Adrian Bunk
Source: libnet-server-mail-perl
Version: 0.25-1
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/fetch.php?pkg=libnet-server-mail-perl=all=0.25-1=1536904015=0

...
Test Summary Report
---
t/starttls.t (Wstat: 9 Tests: 3 Failed: 0)
  Non-zero wait status: 9
  Parse errors: No plan found in TAP output
Files=4, Tests=33,  2 wallclock secs ( 0.05 usr  0.04 sys +  0.67 cusr  0.20 
csys =  0.96 CPU)
Result: FAIL
Failed 1/4 test programs. 0/33 subtests failed.
make[1]: *** [Makefile:861: test_dynamic] Error 255