Bug#909063: apacheds: package installation fails due to incorrect apacheds.service unit

2018-10-27 Thread Dominik George
Hi,

> > Patch against git master is attached. This happened during the BSP in
> > Karlsruhe, so I will NMU to DELAYED/5 tomorrow before the BSP ends if you do
> > not object, and also ask the release team about inclusion in the next point
> > release.
> 
> Thank you for the fix Dominik. Could you commit the changes to the Salsa
> repository and do a team upload instead of a NMU please?

Sure, if you accept my request to join ;).

-nik


signature.asc
Description: PGP signature


Bug#909063: apacheds: package installation fails due to incorrect apacheds.service unit

2018-10-27 Thread Emmanuel Bourg
Le 27/10/2018 à 15:44, Dominik George a écrit :

> Patch against git master is attached. This happened during the BSP in
> Karlsruhe, so I will NMU to DELAYED/5 tomorrow before the BSP ends if you do
> not object, and also ask the release team about inclusion in the next point
> release.

Thank you for the fix Dominik. Could you commit the changes to the Salsa
repository and do a team upload instead of a NMU please?



Bug#909063: apacheds: package installation fails due to incorrect apacheds.service unit

2018-10-27 Thread Dominik George
Control: tags -1 + patch
Control: user debian-rele...@lists.debian.org
Control: usertags -1 + bsp-2018-10-de-karlsruhe

Hi,

> Sep 17 18:42:47 ldap01 systemd[1]: [/lib/systemd/system/apacheds.service:11] 
> Executable path is not absolute, ignoring: ${JAVA_HOME}/bin/java ${JAVA_OPTS} 
>  -Dapacheds.controls=${ADS_CONTROLS} …}/
> Sep 17 18:42:47 ldap01 systemd[1]: apacheds.service: Service lacks both 
> ExecStart= and ExecStop= setting. Refusing.

The error here is a bit misleading (in systemd in buster, it becomes more
clear). The ExecStart command itself is not allowed to contain variables;
the solution is to wrap the call in a /bin/sh -c exec call.

Patch against git master is attached. This happened during the BSP in
Karlsruhe, so I will NMU to DELAYED/5 tomorrow before the BSP ends if you do
not object, and also ask the release team about inclusion in the next point
release.

Cheers,
Nik
From 854fbfd0a86c52ebed3ce7773ee762ee49eb69be Mon Sep 17 00:00:00 2001
From: Dominik George 
Date: Sat, 27 Oct 2018 15:33:29 +0200
Subject: [PATCH] Fix command in systemd service file.

---
 debian/apacheds.service | 17 +
 debian/changelog|  7 +++
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/debian/apacheds.service b/debian/apacheds.service
index e6de514..23efa17 100644
--- a/debian/apacheds.service
+++ b/debian/apacheds.service
@@ -8,14 +8,15 @@ Type=simple
 User=apacheds
 Group=apacheds
 EnvironmentFile=/etc/default/apacheds
-ExecStart=${JAVA_HOME}/bin/java ${JAVA_OPTS} \
--Dapacheds.controls=${ADS_CONTROLS} \
--Dapacheds.extendedOperations=${ADS_EXTENDED_OPERATIONS} \
--Dlog4j.configuration=file:${ADS_INSTANCES}/${ADS_INSTANCE}/conf/log4j.properties \
--Dapacheds.log.dir=${ADS_INSTANCES}/${ADS_INSTANCE}/log \
--cp '${ADS_HOME}/lib/*' \
-org.apache.directory.server.UberjarMain \
-${ADS_INSTANCES}/${ADS_INSTANCE}/
+ExecStart=/bin/sh -c "exec \
+${JAVA_HOME}/bin/java ${JAVA_OPTS} \
+  -Dapacheds.controls=${ADS_CONTROLS} \
+  -Dapacheds.extendedOperations=${ADS_EXTENDED_OPERATIONS} \
+  -Dlog4j.configuration=file:${ADS_INSTANCES}/${ADS_INSTANCE}/conf/log4j.properties \
+  -Dapacheds.log.dir=${ADS_INSTANCES}/${ADS_INSTANCE}/log \
+  -cp '${ADS_HOME}/lib/*' \
+  org.apache.directory.server.UberjarMain \
+  ${ADS_INSTANCES}/${ADS_INSTANCE}/"
 PrivateTmp=true
 
 [Install]
diff --git a/debian/changelog b/debian/changelog
index 4e0d8a6..73583b1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+apache-directory-server (2.0.0~M24-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix command in systemd service file. (Closes: #909063)
+
+ -- Dominik George   Sat, 27 Oct 2018 15:32:48 +0200
+
 apache-directory-server (2.0.0~M24-1) unstable; urgency=medium
 
   * Team upload.
-- 
2.19.1



signature.asc
Description: PGP signature


Bug#909063: apacheds: package installation fails due to incorrect apacheds.service unit

2018-09-17 Thread Jeremy McNaughton
Package: apacheds
Version: 2.0.0~M15-4
Severity: grave
Justification: renders package unusable

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

I am unable to install the apacheds package. The installation fails
when dpkg attempts to start the service due to incorrect ExecStart=
directives in the apacheds.service system unit.

I have tried on both stretch and buster, the same problem happens on
both.

Below I have included the complete output of the apt-get command used,
as well as the output of "journalctl -u apacheds.service" after the
package failed to install.


*** apt-get-install-apacheds.txt

root@ldap01:~# apt-get install apacheds
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  ant ant-optional ca-certificates-java default-jre-headless fontconfig-config 
fonts-dejavu-core java-common junit4 libantlr-java libapache-directory-api-java 
libapache-directory-jdbm-java libapache-pom-java
  libapacheds-i18n-java libapacheds-java libapacheds-kerberos-codec-java 
libavahi-client3 libavahi-common-data libavahi-common3 libbcprov-java 
libcommons-collections3-java libcommons-io-java
  libcommons-lang-java libcommons-logging-java libcommons-parent-java 
libcommons-pool-java libcups2 libdom4j-java libehcache-java libfontconfig1 
libhamcrest-java libisorelax-java libjaxen-java libjaxp1.3-java
  libjdom1-java libjetty9-java libjpeg62-turbo liblcms2-2 liblog4j1.2-java 
libmavibot-java libmina2-java libmsv-java libnspr4 libnss3 libpcsclite1 
librelaxng-datatype-java libservlet3.1-java libslf4j-java
  libxerces2-java libxi6 libxml-commons-external-java 
libxml-commons-resolver1.1-java libxom-java libxpp2-java libxpp3-java 
libxrender1 libxtst6 openjdk-8-jre-headless x11-common
Suggested packages:
  ant-doc ant-gcj default-jdk | java-compiler | java-sdk ant-optional-gcj antlr 
javacc junit jython libbcel-java libbsf-java libcommons-net-java libmail-java 
libjdepend-java libjsch-java liboro-java
  libregexp-java libxalan2-java default-jre libbcprov-java-doc 
libcommons-collections3-java-doc libcommons-io-java-doc 
libcommons-lang-java-doc libavalon-framework-java libcommons-logging-java-doc
  libexcalibur-logkit-java cups-common libdom4j-java-doc libjaxp1.3-java-gcj 
libjdom1-java-doc jetty9 liblcms2-utils liblog4j1.2-java-doc libmina-java-doc 
libspring-beans-java libjzlib-java libognl-java
  libtomcat8-java pcscd libxerces2-java-doc libxerces2-java-gcj 
libxml-commons-resolver1.1-java-doc libxom-java-doc libnss-mdns 
fonts-dejavu-extra fonts-ipafont-gothic fonts-ipafont-mincho fonts-wqy-microhei
  fonts-wqy-zenhei fonts-indic
The following NEW packages will be installed:
  ant ant-optional apacheds ca-certificates-java default-jre-headless 
fontconfig-config fonts-dejavu-core java-common junit4 libantlr-java 
libapache-directory-api-java libapache-directory-jdbm-java
  libapache-pom-java libapacheds-i18n-java libapacheds-java 
libapacheds-kerberos-codec-java libavahi-client3 libavahi-common-data 
libavahi-common3 libbcprov-java libcommons-collections3-java libcommons-io-java
  libcommons-lang-java libcommons-logging-java libcommons-parent-java 
libcommons-pool-java libcups2 libdom4j-java libehcache-java libfontconfig1 
libhamcrest-java libisorelax-java libjaxen-java libjaxp1.3-java
  libjdom1-java libjetty9-java libjpeg62-turbo liblcms2-2 liblog4j1.2-java 
libmavibot-java libmina2-java libmsv-java libnspr4 libnss3 libpcsclite1 
librelaxng-datatype-java libservlet3.1-java libslf4j-java
  libxerces2-java libxi6 libxml-commons-external-java 
libxml-commons-resolver1.1-java libxom-java libxpp2-java libxpp3-java 
libxrender1 libxtst6 openjdk-8-jre-headless x11-common
0 upgraded, 59 newly installed, 0 to remove and 1 not upgraded.
Need to get 53.3 MB of archives.
After this operation, 141 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Get:1 http://deb.debian.org/debian stretch/main amd64 libnspr4 amd64 2:4.12-6 
[117 kB]
Get:2 http://deb.debian.org/debian stretch/main amd64 libnss3 amd64 
2:3.26.2-1.1+deb9u1 [1,161 kB]
Get:3 http://deb.debian.org/debian stretch/main amd64 ca-certificates-java all 
20170531+nmu1 [14.7 kB]
Get:4 http://deb.debian.org/debian stretch/main amd64 java-common all 0.58 
[13.5 kB]
Get:5 http://deb.debian.org/debian stretch/main amd64 libavahi-common-data 
amd64 0.6.32-2 [118 kB]
Get:6 http://deb.debian.org/debian stretch/main amd64 libavahi-common3 amd64 
0.6.32-2 [52.0 kB]
Get:7 http://deb.debian.org/debian stretch/main amd64 libavahi-client3 amd64 
0.6.32-2 [55.3 kB]
Get:8 http://deb.debian.org/debian stretch/main amd64 libjpeg62-turbo amd64 
1:1.5.1-2 [134 kB]
Get:9