Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Le 16/10/2018 à 11:55, Mattia Rizzolo a écrit : > Control: tag -1 -moreinfo > Control: clone -1 -2 > Control: retitle -2 uscan: disallow using --report together with --*download* > > On Mon, Oct 15, 2018 at 07:10:03PM +0200, Mattia Rizzolo wrote: >> On Mon, Oct 15, 2018 at 06:45:30PM +0200, Xavier wrote: >>> looking at uscan doc, --report (same as --same) disables mk-origtargz, >>> so no operation is done and you fall on actual behavior (no rename). >>> What changes do you want? >> >> Right, that's me being silly. I used both --report and >> --download-version, which don't really make sense (shouldn't --report >> (and --safe) conflict with all the --*)ownload* options? - unrelated, >> eh!) >> >> I'm now in a slow network place, so I'll try again tomrrow... > > Indeed, it works *nearly* as expected (check the bottom). > So, I'm also proposing to disallow --report with all the download > options, as they don't really make sense anyway. If user choose --safe, it makes me feel uncomfortable to launch repack. Today "--safe -d" downloads package and don't launch mk-origtargz. That's why I proposed to launch mk-origtargz with also a --safe mode to avoid unsafe operations but allow rename/copy/symlink (will fail if repack is needed).
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Control: tag -1 -moreinfo Control: clone -1 -2 Control: retitle -2 uscan: disallow using --report together with --*download* On Mon, Oct 15, 2018 at 07:10:03PM +0200, Mattia Rizzolo wrote: > On Mon, Oct 15, 2018 at 06:45:30PM +0200, Xavier wrote: > > looking at uscan doc, --report (same as --same) disables mk-origtargz, > > so no operation is done and you fall on actual behavior (no rename). > > What changes do you want? > > Right, that's me being silly. I used both --report and > --download-version, which don't really make sense (shouldn't --report > (and --safe) conflict with all the --*)ownload* options? - unrelated, > eh!) > > I'm now in a slow network place, so I'll try again tomrrow... Indeed, it works *nearly* as expected (check the bottom). So, I'm also proposing to disallow --report with all the download options, as they don't really make sense anyway. mattia@warren ~/devel/debian/inkscape/inkscape (git)-[master] % uscan --download-version 0.92.1 uscan info: The directory to store downloaded files($destdir): .. uscan info: uscan (version 2.18.6) See uscan(1) for help uscan info: Scan watch files in . uscan info: Check debian/watch and debian/changelog in ./.git/refs/tags uscan info: Check debian/watch and debian/changelog in . uscan info: package="inkscape" version="0.92.3-5" (as seen in debian/changelog) uscan info: package="inkscape" version="0.92.3" (no epoch/revision) uscan info: ./debian/changelog sets package="inkscape" version="0.92.3" uscan info: Found upstream signing keyring: debian/upstream/signing-key.asc uscan info: Process watch file at: debian/watch package = inkscape version = 0.92.3 pkg_dir = . uscan info: Set passive mode: 1 uscan info: opts: uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/, dversionmangle=auto, pgpmode=next uscan info: line: https://launchpad.net/inkscape/+download (?:.*/)?inkscape[-_]?(\d[\-+\.:\~\da-zA-Z]*)(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip|tgz|tbz|txz) debian uscan info: Parsing uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/ uscan info: Parsing dversionmangle=auto uscan info: Parsing pgpmode=next uscan info: line: https://launchpad.net/inkscape/+download (?:.*/)?inkscape[-_]?(\d[\-+\.:\~\da-zA-Z]*)(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip|tgz|tbz|txz) debian uscan info: Last orig.tar.* tarball version (from debian/changelog): 0.92.3 uscan info: Download the --download-version specified version: 0.92.1 uscan info: Requesting URL: https://launchpad.net/inkscape/+download uscan info: Matching pattern: (?:(?:https://launchpad.net)?\/inkscape\/\+download)?(?:.*/)?inkscape[-_]?(\d[\-+\.:\~\da-zA-Z]*)(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip|tgz|tbz|txz) uscan info: Found the following matching hrefs on the web page (newest first): https://launchpad.net/inkscape/0.92.x/0.92.3/+download/inkscape-0.92.3.tar.bz2 (0.92.3) index=0.92.3-2 https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 (0.92.2) index=0.92.2-2 https://launchpad.net/inkscape/0.92.x/0.92.1/+download/inkscape-0.92.1.tar.bz2 (0.92.1) index=0.92.1-2 matched with the download version https://launchpad.net/inkscape/0.92.x/0.92.1pre2/+download/inkscape-0.92.1pre2.tar.bz2 (0.92.1~pre2) index=0.92.1~pre2-2 https://launchpad.net/inkscape/0.92.x/0.92.1pre1/+download/inkscape-0.92.1pre1.tar.bz2 (0.92.1~pre1) index=0.92.1~pre1-2 https://launchpad.net/inkscape/0.92.x/0.92.1pre0/+download/inkscape-0.92.1pre0.tar.bz2 (0.92.1~pre0) index=0.92.1~pre0-2 https://launchpad.net/inkscape/0.92.x/0.92/+download/inkscape-0.92.0.tar.bz2 (0.92.0) index=0.92.0-2 https://launchpad.net/inkscape/0.92.x/0.92pre4/+download/inkscape-0.92pre4.tar.bz2 (0.92~pre4) index=0.92~pre4-2 https://launchpad.net/inkscape/0.92.x/0.92pre3/+download/inkscape-0.92pre3.tar.bz2 (0.92~pre3) index=0.92~pre3-2 https://launchpad.net/inkscape/0.91.x/0.91/+download/inkscape-0.91.tar.bz2 (0.91) index=0.91-2 https://launchpad.net/inkscape/0.91.x/0.91/+download/inkscape-0.91.tar.gz (0.91) index=0.91-1 https://launchpad.net/inkscape/0.91.x/0.91/+download/inkscape-0.91.zip (0.91) index=0.91-0 uscan info: Looking at $base = https://launchpad.net/inkscape/+download with $filepattern = (?:.*/)?inkscape[-_]?(\d[\-+\.:\~\da-zA-Z]*)(?i)\.(?:tar\.xz|tar\.bz2|tar\.gz|zip|tgz|tbz|txz) found $newfile = https://launchpad.net/inkscape/0.92.x/0.92.1/+download/inkscape-0.92.1.tar.bz2 $newversion = 0.92.1 which is newer than $lastversion = 0.92.3 uscan info: Matching target for downloadurlmangle: https://launchpad.net/inkscape/0.92.x/0.92.1/+download/inkscape-0.92.1.tar.bz2 uscan info: Upstream URL(+tag) to download is identified as https://launchpad.net/inkscape/0.92.x/0.92.1/+download/inkscape-0.92.1.tar.bz2 uscan info: Filename (filenamemangled) for downloaded file: inkscape-0.92.1.tar.bz2 uscan: Newest version of inkscape on remote site is 0.92.1, specified download
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
On Mon, Oct 15, 2018 at 08:11:47PM +0200, Xavier wrote: > Le 15/10/2018 à 19:10, Mattia Rizzolo a écrit : > > Right, that's me being silly. I used both --report and > > --download-version, which don't really make sense (shouldn't --report > > (and --safe) conflict with all the --*)ownload* options? - unrelated, > > eh!) > > An idea: > retitle -1 uscan: --safe should allow operations that doesn't need to repack > severity -1 wishlist not really: since --safe is an alias for --report, that's clearly something that is meant to only report the status, not do anything, imho. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Le 15/10/2018 à 19:10, Mattia Rizzolo a écrit : > Control: tag -1 moreinfo > > On Mon, Oct 15, 2018 at 06:45:30PM +0200, Xavier wrote: >> looking at uscan doc, --report (same as --same) disables mk-origtargz, >> so no operation is done and you fall on actual behavior (no rename). >> What changes do you want? > > Right, that's me being silly. I used both --report and > --download-version, which don't really make sense (shouldn't --report > (and --safe) conflict with all the --*)ownload* options? - unrelated, > eh!) > > I'm now in a slow network place, so I'll try again tomrrow... An idea: retitle -1 uscan: --safe should allow operations that doesn't need to repack severity -1 wishlist
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Control: tag -1 moreinfo On Mon, Oct 15, 2018 at 06:45:30PM +0200, Xavier wrote: > looking at uscan doc, --report (same as --same) disables mk-origtargz, > so no operation is done and you fall on actual behavior (no rename). > What changes do you want? Right, that's me being silly. I used both --report and --download-version, which don't really make sense (shouldn't --report (and --safe) conflict with all the --*)ownload* options? - unrelated, eh!) I'm now in a slow network place, so I'll try again tomrrow... -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Hello, looking at uscan doc, --report (same as --same) disables mk-origtargz, so no operation is done and you fall on actual behavior (no rename). What changes do you want? NB: there are still other bugs :-(, I'm trying to fix them
Bug#910912: uscan: ignore USCAN_SYMLINK=rename with --download-version
Package: devscripts Version: 2.18.6 User: devscri...@pacakges.debian.org Usertag: uscan With USCAN_SYMLINK=rename in my ~/.devscripts, it downloads the version I want it to download, but then doesn't rename it as expected. mattia@warren ~/devel/debian/inkscape/inkscape (git)-[master] % uscan --report --download-version 0.92.2 -dd uscan info: The directory to store downloaded files($destdir): .. uscan info: uscan (version 2.18.6) See uscan(1) for help uscan info: Scan watch files in . uscan info: Check debian/watch and debian/changelog in ./.git/refs/tags uscan info: Check debian/watch and debian/changelog in . uscan info: package="inkscape" version="0.92.3-5" (as seen in debian/changelog) uscan info: package="inkscape" version="0.92.3" (no epoch/revision) uscan info: ./debian/changelog sets package="inkscape" version="0.92.3" uscan info: Found upstream signing keyring: debian/upstream/signing-key.asc uscan info: Process watch file at: debian/watch package = inkscape version = 0.92.3 pkg_dir = . uscan info: Set passive mode: 1 uscan info: opts: uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/, dversionmangle=auto, pgpmode=auto uscan info: line: https://launchpad.net/inkscape/+download (?:.*/)?inkscape[_\-\.]?(\d\S+)\.(?:tgz|txz|tar\.(?:bz2|gz|z2|xz)) debian uscan info: Parsing uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)[\-\.]?\d*)$/$1~$2/ uscan info: Parsing dversionmangle=auto uscan info: Parsing pgpmode=auto uscan info: line: https://launchpad.net/inkscape/+download (?:.*/)?inkscape[_\-\.]?(\d\S+)\.(?:tgz|txz|tar\.(?:bz2|gz|z2|xz)) debian uscan info: Last orig.tar.* tarball version (from debian/changelog): 0.92.3 uscan info: Download the --download-version specified version: 0.92.2 uscan info: Requesting URL: https://launchpad.net/inkscape/+download uscan info: Matching pattern: (?:(?:https://launchpad.net)?\/inkscape\/\+download)?(?:.*/)?inkscape[_\-\.]?(\d\S+)\.(?:tgz|txz|tar\.(?:bz2|gz|z2|xz)) uscan info: Found the following matching hrefs on the web page (newest first): https://launchpad.net/inkscape/0.92.x/0.92.3/+download/inkscape-0.92.3.tar.bz2 (0.92.3) index=0.92.3-2 https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 (0.92.2) index=0.92.2-2 matched with the download version https://launchpad.net/inkscape/0.92.x/0.92.1/+download/inkscape-0.92.1.tar.bz2 (0.92.1) index=0.92.1-2 https://launchpad.net/inkscape/0.92.x/0.92.1pre2/+download/inkscape-0.92.1pre2.tar.bz2 (0.92.1~pre2) index=0.92.1~pre2-2 https://launchpad.net/inkscape/0.92.x/0.92.1pre1/+download/inkscape-0.92.1pre1.tar.bz2 (0.92.1~pre1) index=0.92.1~pre1-2 https://launchpad.net/inkscape/0.92.x/0.92.1pre0/+download/inkscape-0.92.1pre0.tar.bz2 (0.92.1~pre0) index=0.92.1~pre0-2 https://launchpad.net/inkscape/0.92.x/0.92/+download/inkscape-0.92.0.tar.bz2 (0.92.0) index=0.92.0-2 https://launchpad.net/inkscape/0.92.x/0.92pre4/+download/inkscape-0.92pre4.tar.bz2 (0.92~pre4) index=0.92~pre4-2 https://launchpad.net/inkscape/0.92.x/0.92pre3/+download/inkscape-0.92pre3.tar.bz2 (0.92~pre3) index=0.92~pre3-2 https://launchpad.net/inkscape/0.91.x/0.91/+download/inkscape-0.91.tar.bz2 (0.91) index=0.91-2 https://launchpad.net/inkscape/0.91.x/0.91/+download/inkscape-0.91.tar.gz (0.91) index=0.91-1 uscan info: Looking at $base = https://launchpad.net/inkscape/+download with $filepattern = (?:.*/)?inkscape[_\-\.]?(\d\S+)\.(?:tgz|txz|tar\.(?:bz2|gz|z2|xz)) found $newfile = https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 $newversion = 0.92.2 which is newer than $lastversion = 0.92.3 uscan info: Matching target for downloadurlmangle: https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 uscan info: Upstream URL(+tag) to download is identified as https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 uscan info: Filename (filenamemangled) for downloaded file: inkscape-0.92.2.tar.bz2 uscan: Newest version of inkscape on remote site is 0.92.2, specified download version is 0.92.2 uscan info: Downloading upstream package: inkscape-0.92.2.tar.bz2 uscan info: Requesting URL: https://launchpad.net/inkscape/0.92.x/0.92.2/+download/inkscape-0.92.2.tar.bz2 uscan info: Successfully downloaded package: inkscape-0.92.2.tar.bz2 uscan info: Start checking for common possible upstream OpenPGP signature files uscan info: End checking for common possible upstream OpenPGP signature files uscan info: Don't check OpenPGP signature uscan info: New orig.tar.* tarball version (oversionmangled): 0.92.2 uscan info: SKIP generation of orig.tar.* and running of script/uupdate (--safe) uscan info: Scan finished mattia@warren ~/devel/debian/inkscape/inkscape (git)-[master] % .. mattia@warren ~/devel/debian/inkscape % l total 64524 drwx-- 3 mattia mattia 4096 Feb 21 2017 gpghome drwxr-xr-x 16 mattia mattia
