Bug#910942: [wine-development] Please use wrap-and-sort
Hi Mike On 10/14/18 2:36 AM, Michael Gilbert wrote: > Welcome back! Thanks, much appreciated! btw, I'm just working on 3.0.3-1. > Wrap and sort is itself the original source of the extra diff being > seen and will continue to be in the future. Wrap and sort has a deterministic result. We could add it to debian/scripts/import, so that even misplaced entries get sorted quite soon, and then stay in their place forever. > I would prefer to > maintain the original rough organization of dependencies, which is > build tools, utilities, and data followed by libraries. Wrap and sort > to me is not particularly useful. It helps to see the logic being named. However in my packaging work on Wine I've really seen these reorganization changes so often (in d/rules and other files like .install) and had to spend a lot of time in comparing files, that I'd prefer a deterministic sorting to a rough organization which changes over time. >> [1] This time I just noticed you replaced the builddep "fontforge-nox | >> fontforge" with "fontforge-nox". This reverts something I did on >> purpose when I implemented the font-rebuilding, so that for local >> rebuilds fontforge-nox doesn't get pulled in unnecessarily if fontforge >> is already installed. > > That change is of course intentional. It is my opinion that it is > preferable to try to avoid potential sources of variance in builds. A > desire to reduce the number of installed packages for a build I think > should not override that. Ok. Greets jre
Bug#910942: [wine-development] Please use wrap-and-sort
On Sat, Oct 13, 2018 at 12:39 PM Jens Reyer wrote: > To avoid these issues I suggest to use > > wrap-and-sort --wrap-always --short-indent --trailing-comma Hi Jens, Welcome back! Wrap and sort is itself the original source of the extra diff being seen and will continue to be in the future. I would prefer to maintain the original rough organization of dependencies, which is build tools, utilities, and data followed by libraries. Wrap and sort to me is not particularly useful. > [1] This time I just noticed you replaced the builddep "fontforge-nox | > fontforge" with "fontforge-nox". This reverts something I did on > purpose when I implemented the font-rebuilding, so that for local > rebuilds fontforge-nox doesn't get pulled in unnecessarily if fontforge > is already installed. That change is of course intentional. It is my opinion that it is preferable to try to avoid potential sources of variance in builds. A desire to reduce the number of installed packages for a build I think should not override that. Best wishes, Mike
Bug#910942: [wine-development] Please use wrap-and-sort
Package: wine-development Version: 3.17-1 Severity: normal Hi Mike, in the recent uploads you re-sorted the dependencies in d/control.in once again. Each time this happens this takes some of my time when I sync the src:wine packaging, or dig into issues that exist only in one of our or other packages (upstream, downstream, other versions, ...). Further it obfuscates packaging changes[1] and has potential for copy errors. To avoid these issues I suggest to use wrap-and-sort --wrap-always --short-indent --trailing-comma which will keep the general layout intact, but sorts the entries alphabetically. You objected this change some years ago, but we didn't discuss it in depth back then. Hopefully I could change your mind this time. Greets jre [1] This time I just noticed you replaced the builddep "fontforge-nox | fontforge" with "fontforge-nox". This reverts something I did on purpose when I implemented the font-rebuilding, so that for local rebuilds fontforge-nox doesn't get pulled in unnecessarily if fontforge is already installed. Greets jre
