Bug#911867: RFS: frr/6.0.1-1 [ITP]
David Lamparter wrote: > On Sun, Oct 28, 2018 at 06:00:08PM +0200, Yavor Doganov wrote: > > Hmm, if a shared library does not provide a stable ABI it should not > > be shipped as public library. > > Good point, done, latest version on mentors uses /usr/lib/$multiarch/frr/ > However, now I have package-has-unnecessary-activation-of-ldconfig-trigger > to deal with... This appears to be debhelper #204975. You can use an override like: override_dh_makeshlibs: dh_makeshlibs --noscripts
Bug#911867: RFS: frr/6.0.1-1 [ITP]
❦ 27 octobre 2018 14:54 +0200, David Lamparter : > The lib is an integral part of a FRRouting version; the daemons and the > .so must match up. As noted above on the symbols file, the .so version > is not currently used since the ABI is not stable. The "0" does not > convey any useful information. Look how the Quagga package is done: libs are shipped in /usr/lib/quagga. If the build system didn't change too much, it should be quite easy to do the same thing with FRR. -- Debian package sponsoring guidelines: https://vincent.bernat.im/en/debian-package-sponsoring signature.asc Description: PGP signature
Bug#911867: RFS: frr/6.0.1-1 [ITP]
On Sun, Oct 28, 2018 at 06:00:08PM +0200, Yavor Doganov wrote: > David Lamparter wrote: > > Symbols files are only applicable to libraries providing a stable ABI. > > This is explicitly not the case for FRRouting (hence also the 0.0.0 > > .so version.) > > Hmm, if a shared library does not provide a stable ABI it should not > be shipped as public library. Please consider installing it at > /usr/lib/frr or something similar. That way, you won't clutter > /usr/lib, your package will be compliant with Policy and as a bonus > you'd get rid of the (legitimate) lintian warnings. Good point, done, latest version on mentors uses /usr/lib/$multiarch/frr/ However, now I have package-has-unnecessary-activation-of-ldconfig-trigger to deal with... -David
Bug#911867: RFS: frr/6.0.1-1 [ITP]
David Lamparter wrote: > Symbols files are only applicable to libraries providing a stable ABI. > This is explicitly not the case for FRRouting (hence also the 0.0.0 > .so version.) Hmm, if a shared library does not provide a stable ABI it should not be shipped as public library. Please consider installing it at /usr/lib/frr or something similar. That way, you won't clutter /usr/lib, your package will be compliant with Policy and as a bonus you'd get rid of the (legitimate) lintian warnings.
Bug#911867: RFS: frr/6.0.1-1 [ITP]
Hi Herbert,
Thanks for your input! FWIW I started out with a whole lot of lintian
errors and warnings and am happy to be down to informational messages ;)
On Sat, Oct 27, 2018 at 08:19:23AM -0300, Herbert Fortes wrote:
> On 10/25/18 3:17 PM, David Lamparter wrote:
> I no-symbols-control-file
> usr/lib/x86_64-linux-gnu/libfrrospfapiclient.so.0.0.0
> usr/lib/x86_64-linux-gnu/libfrr.so.0.0.0
>
> https://wiki.debian.org/UsingSymbolsFiles
Symbols files are only applicable to libraries providing a stable ABI.
This is explicitly not the case for FRRouting (hence also the 0.0.0
.so version.)
> I spelling-error-in-binary # a lot
> I spelling-error-in-manpage # a lot
I fixed these upstream in https://github.com/FRRouting/frr/pull/3247
Some of the spellcheck warnings are also bogus since the spellchecker
misdetects function names (e.g. writen()) as english words ("written".)
> O package-name-doesnt-match-sonames
> libfrr0 libfrrospfapiclient0 (override comment: libfrr* are for
> internal use only and do not provide a stable API or ABI. soname / library
> versioning is irrelevant and they must always be shipped exact-matching to
> the daemons compiled against it)
>
>It is a package name. That's all.
>The lib can not be trusted?
The lib is an integral part of a FRRouting version; the daemons and the
.so must match up. As noted above on the symbols file, the .so version
is not currently used since the ABI is not stable. The "0" does not
convey any useful information.
> P package-uses-old-debhelper-compat-version
> 9
>
> There is a problem with version 11?
Probably nothing. The package used version 7 before I started working
to upgrade it and I bumped it up to and tested version 9 since that's
not deprecated.
Note that this is a "pedantic" level warning so I'm going to fix other
stuff before getting to this :)
> O alternatively-build-depends-on-python-sphinx-and-python3-sphinx
> (override comment: these are for build-compatibility on older
> distros (e.g. Ubuntu 14.04))
>
> It is a new package. It is preferable to not upload Python 2
The Debian packaging for FRRouting is currently maintained in upstream
git and supported on Debian jessie, stretch, buster, sid as well as
Ubuntu 14.04, 16.04, 17.10, 18.04 (+ 18.10.) This build dependency was
a concession to make building on old platforms easier - probably for
Ubuntu 12.04 (which has been dropped upstream in 6.0.) The entire
package works fine with only Python3 and no remains of Python2
installed.
Since both Ubuntu 14.04 and Debian jessie do have python3-sphinx, I'll
check whether we can ditch the Python2 stuff in general (there's also a
python/python3-dev build-dep) without breaking 14.04/jessie.
Cheers,
-David
P.S.: I'm still polishing the packaging, working to reduce the number of
lintian informational messages, but I also noticed some problems with
the init/service architecture that are higher priority to fix.
Bug#911867: RFS: frr/6.0.1-1 [ITP]
Hi, On 10/25/18 3:17 PM, David Lamparter wrote: Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "frr" * Package name: frr Version : 6.0.1-1 Upstream Author : FRRouting-dev * URL : https://frrouting.org/ * License : GPLv2 and LGPLv2.1 Section : net This replaces the "quagga" package, which FRRouting is a fork of. It builds those binary packages: frr - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon forked from Quagga frr-dbg- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (debug symbols) frr-doc- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (documentation) frr-pythontools - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (Python Tools) frr-rpki-rtrlib - FRRouting RTRlib RPKI support frr-snmp - FRRouting SNMP support To access further information about this package, please visit the following URL: https://mentors.debian.net/package/frr Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/f/frr/frr_6.0.1-1.dsc More information about frr can be obtained from https://frrouting.org Changes since the last upload is not applicable since this is the first upload. I expect there still is feedback that I need to address in regards to the Debian packaging on this and I will likely be uploading further revisions in the coming days. I did not build the package. My comment: There are many lintian info warnings that can be fixed easily: I no-symbols-control-file usr/lib/x86_64-linux-gnu/libfrrospfapiclient.so.0.0.0 usr/lib/x86_64-linux-gnu/libfrr.so.0.0.0 https://wiki.debian.org/UsingSymbolsFiles I possible-documentation-but-no-doc-base-registration I spelling-error-in-binary # a lot I spelling-error-in-manpage # a lot I systemd-service-file-missing-documentation-key lib/systemd/system/frr.service O package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0 (override comment: libfrr* are for internal use only and do not provide a stable API or ABI. soname / library versioning is irrelevant and they must always be shipped exact-matching to the daemons compiled against it) It is a package name. That's all. The lib can not be trusted? O systemd-service-file-refers-to-unusual-wantedby-target lib/systemd/system/frr.service network-online.target (override comment: we're a bit special since we provide network connectivity by starting up routing protocols.) X duplicate-files usr/share/doc/frr/examples/pbrd.conf.sample usr/share/doc/frr/examples/staticd.conf.sample frr-rpki-rtrlib I extended-description-is-probably-too-short I hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/frr/modules/bgpd_rpki.so frr source I debian-control-has-obsolete-dbg-package frr-dbg I duplicate-long-description frr-doc frr-pythontools I ored-build-depends-on-obsolete-package build-depends: dh-systemd => use debhelper (>= 9.20160709) P debian-watch-does-not-check-gpg-signature P package-uses-old-debhelper-compat-version 9 There is a problem with version 11? O alternatively-build-depends-on-python-sphinx-and-python3-sphinx (override comment: these are for build-compatibility on older distros (e.g. Ubuntu 14.04)) It is a new package. It is preferable to not upload Python 2 X upstream-metadata-file-is-missing
Bug#911867: RFS: frr/6.0.1-1 [ITP]
Hi, On 10/25/18 3:17 PM, David Lamparter wrote: Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "frr" * Package name: frr Version : 6.0.1-1 Upstream Author : FRRouting-dev * URL : https://frrouting.org/ * License : GPLv2 and LGPLv2.1 Section : net This replaces the "quagga" package, which FRRouting is a fork of. It builds those binary packages: frr - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon forked from Quagga frr-dbg- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (debug symbols) frr-doc- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (documentation) frr-pythontools - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (Python Tools) frr-rpki-rtrlib - FRRouting RTRlib RPKI support frr-snmp - FRRouting SNMP support To access further information about this package, please visit the following URL: https://mentors.debian.net/package/frr Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/f/frr/frr_6.0.1-1.dsc More information about frr can be obtained from https://frrouting.org Changes since the last upload is not applicable since this is the first upload. I expect there still is feedback that I need to address in regards to the Debian packaging on this and I will likely be uploading further revisions in the coming days. I did not build the package. My comment: There are many lintian info warnings that can be fixed easily: I no-symbols-control-file usr/lib/x86_64-linux-gnu/libfrrospfapiclient.so.0.0.0 usr/lib/x86_64-linux-gnu/libfrr.so.0.0.0 https://wiki.debian.org/UsingSymbolsFiles I possible-documentation-but-no-doc-base-registration I spelling-error-in-binary # a lot I spelling-error-in-manpage # a lot I systemd-service-file-missing-documentation-key lib/systemd/system/frr.service O package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0 (override comment: libfrr* are for internal use only and do not provide a stable API or ABI. soname / library versioning is irrelevant and they must always be shipped exact-matching to the daemons compiled against it) It is a package name. That's all. The lib can not be trusted? O systemd-service-file-refers-to-unusual-wantedby-target lib/systemd/system/frr.service network-online.target (override comment: we're a bit special since we provide network connectivity by starting up routing protocols.) X duplicate-files usr/share/doc/frr/examples/pbrd.conf.sample usr/share/doc/frr/examples/staticd.conf.sample frr-rpki-rtrlib I extended-description-is-probably-too-short I hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/frr/modules/bgpd_rpki.so frr source I debian-control-has-obsolete-dbg-package frr-dbg I duplicate-long-description frr-doc frr-pythontools I ored-build-depends-on-obsolete-package build-depends: dh-systemd => use debhelper (>= 9.20160709) P debian-watch-does-not-check-gpg-signature P package-uses-old-debhelper-compat-version 9 There is a problem with version 11? O alternatively-build-depends-on-python-sphinx-and-python3-sphinx (override comment: these are for build-compatibility on older distros (e.g. Ubuntu 14.04)) It is a new package. It is preferable to not upload Python 2 X upstream-metadata-file-is-missing Regards, Herbert
Bug#911867: RFS: frr/6.0.1-1 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "frr" * Package name: frr Version : 6.0.1-1 Upstream Author : FRRouting-dev * URL : https://frrouting.org/ * License : GPLv2 and LGPLv2.1 Section : net This replaces the "quagga" package, which FRRouting is a fork of. It builds those binary packages: frr - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon forked from Quagga frr-dbg- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (debug symbols) frr-doc- BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (documentation) frr-pythontools - BGP/OSPF/RIP/RIPng/ISIS/PIM/LDP routing daemon (Python Tools) frr-rpki-rtrlib - FRRouting RTRlib RPKI support frr-snmp - FRRouting SNMP support To access further information about this package, please visit the following URL: https://mentors.debian.net/package/frr Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/f/frr/frr_6.0.1-1.dsc More information about frr can be obtained from https://frrouting.org Changes since the last upload is not applicable since this is the first upload. I expect there still is feedback that I need to address in regards to the Debian packaging on this and I will likely be uploading further revisions in the coming days. Regards, David Lamparter
