Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
On 10/29/18 10:13 PM, Faidon Liambotis wrote: > On Mon, Oct 29, 2018 at 09:10:40PM +0100, Sebastiaan Couwenberg wrote: >>> I disagree on that -- excessive and spurious logging is a serious issue >>> and filling up logs of the Nagios server fast is as well. Logrotate >>> helps, but not with that rate, and regardless, not a great solution >>> either (the logs become just an endless sea of garbage). >> >> Then we'll have to agree to disagree. As maintainer of the package I >> have evaluated the severity of this issue, and not deemed it high enough >> to be eligible for a stable update. >> >>> And really, what's the downside? These logs are useless; the patch is >>> upstream, is tiny, safe and easily backportable. If you're concerned >>> about the effort... I'd be happy to provide patches and/or NMU! >> >> If you're going to the effort to patch the package, why bother arguing >> in this issue? Just provide the package in your local repo and be done >> with it. > > We've already done that (in fact, before even reporting this bug!): > https://phabricator.wikimedia.org/T207775#4693987 > https://apt.wikimedia.org/wikimedia/pool/main/n/nagios-nrpe/ > > ...but, given that we encountered this, and we already battle-tested it, > we thought it might be preferrable for other Debian users to benefit > from the fix as well. Given the Nagios forum link above, it doesn't look > like we were the only ones affected. All of us in the Wikimedia team > (three of us DDs) in that loop agreed on this FWIW :) But none of you are active in the Nagios team, (co-)maintainers of the nrpe package, nor SRMs. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
On Mon, Oct 29, 2018 at 09:10:40PM +0100, Sebastiaan Couwenberg wrote: > > I disagree on that -- excessive and spurious logging is a serious issue > > and filling up logs of the Nagios server fast is as well. Logrotate > > helps, but not with that rate, and regardless, not a great solution > > either (the logs become just an endless sea of garbage). > > Then we'll have to agree to disagree. As maintainer of the package I > have evaluated the severity of this issue, and not deemed it high enough > to be eligible for a stable update. > > > And really, what's the downside? These logs are useless; the patch is > > upstream, is tiny, safe and easily backportable. If you're concerned > > about the effort... I'd be happy to provide patches and/or NMU! > > If you're going to the effort to patch the package, why bother arguing > in this issue? Just provide the package in your local repo and be done > with it. We've already done that (in fact, before even reporting this bug!): https://phabricator.wikimedia.org/T207775#4693987 https://apt.wikimedia.org/wikimedia/pool/main/n/nagios-nrpe/ ...but, given that we encountered this, and we already battle-tested it, we thought it might be preferrable for other Debian users to benefit from the fix as well. Given the Nagios forum link above, it doesn't look like we were the only ones affected. All of us in the Wikimedia team (three of us DDs) in that loop agreed on this FWIW :) Regards, Faidon
Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
On 10/29/18 8:53 PM, Faidon Liambotis wrote: > On Mon, Oct 29, 2018 at 06:12:21PM +0100, Sebastiaan Couwenberg wrote: >>> Could you explain a little bit more your rationale about this? It feels >>> to me like a prime candidate for an SPU: serious issue affecting the >>> overall stability of the system, that has a tiny, safe and easily >>> backportable patch. >> >> The version packet logging is not a serious issue, it's a normal or >> minor issue as it doesn't affect the usability of the package. >> >> If this causes an issue on large installation as reported in the OP, >> then logrotate can be used to rotate the logs more frequently. Or the >> newer version from stretch-backports can be installed. > > I disagree on that -- excessive and spurious logging is a serious issue > and filling up logs of the Nagios server fast is as well. Logrotate > helps, but not with that rate, and regardless, not a great solution > either (the logs become just an endless sea of garbage). Then we'll have to agree to disagree. As maintainer of the package I have evaluated the severity of this issue, and not deemed it high enough to be eligible for a stable update. > And really, what's the downside? These logs are useless; the patch is > upstream, is tiny, safe and easily backportable. If you're concerned > about the effort... I'd be happy to provide patches and/or NMU! If you're going to the effort to patch the package, why bother arguing in this issue? Just provide the package in your local repo and be done with it. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
On Mon, Oct 29, 2018 at 06:12:21PM +0100, Sebastiaan Couwenberg wrote: > > Could you explain a little bit more your rationale about this? It feels > > to me like a prime candidate for an SPU: serious issue affecting the > > overall stability of the system, that has a tiny, safe and easily > > backportable patch. > > The version packet logging is not a serious issue, it's a normal or > minor issue as it doesn't affect the usability of the package. > > If this causes an issue on large installation as reported in the OP, > then logrotate can be used to rotate the logs more frequently. Or the > newer version from stretch-backports can be installed. I disagree on that -- excessive and spurious logging is a serious issue and filling up logs of the Nagios server fast is as well. Logrotate helps, but not with that rate, and regardless, not a great solution either (the logs become just an endless sea of garbage). And really, what's the downside? These logs are useless; the patch is upstream, is tiny, safe and easily backportable. If you're concerned about the effort... I'd be happy to provide patches and/or NMU! Thanks! Faidon
Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
Hi Sebastiaan, On Fri, Oct 26, 2018 at 05:32:56PM +0200, Sebastiaan Couwenberg wrote: > > Applying > > https://github.com/NagiosEnterprises/nrpe/commit/fe006d2556c906de84321188630ab0d25c317cc1 > > and > > https://github.com/NagiosEnterprises/nrpe/commit/fe006d2556c906de84321188630ab0d25c317cc1 > > appear to resolve the issue in our installation. > > These changes are unlikely to find their way into a stable update. > > Install nrpe from stretch-backports if you need those changes. Could you explain a little bit more your rationale about this? It feels to me like a prime candidate for an SPU: serious issue affecting the overall stability of the system, that has a tiny, safe and easily backportable patch. Regards, Faidon
Bug#911958: [Pkg-nagios-devel] Bug#911958: nagios-nrpe-plugin: On large installations, check_nrpe logs are very spammy around nrpe packet version.
On 10/29/18 5:59 PM, Faidon Liambotis wrote: > On Fri, Oct 26, 2018 at 05:32:56PM +0200, Sebastiaan Couwenberg wrote: >>> Applying >>> https://github.com/NagiosEnterprises/nrpe/commit/fe006d2556c906de84321188630ab0d25c317cc1 >>> and >>> https://github.com/NagiosEnterprises/nrpe/commit/fe006d2556c906de84321188630ab0d25c317cc1 >>> appear to resolve the issue in our installation. >> >> These changes are unlikely to find their way into a stable update. >> >> Install nrpe from stretch-backports if you need those changes. > > Could you explain a little bit more your rationale about this? It feels > to me like a prime candidate for an SPU: serious issue affecting the > overall stability of the system, that has a tiny, safe and easily > backportable patch. The version packet logging is not a serious issue, it's a normal or minor issue as it doesn't affect the usability of the package. If this causes an issue on large installation as reported in the OP, then logrotate can be used to rotate the logs more frequently. Or the newer version from stretch-backports can be installed. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
