Bug#912231: bnd FTBFS with OpenJDK 11

2018-12-20 Thread Emmanuel Bourg
Le 20/12/2018 à 18:35, Markus Koschany a écrit :

> Thanks for fixing this bug. I believe others will be affected by it too
> in the future. Shouldn't that be fixed in gradle-debian-helper instead?
> I mean it's not obvious that one has to export HOME now.

I'm not sure, this seems very specific to bnd since, as I understand, it
uses its own Gradle plugin to build itself. That's quite non standard.
Usually for a build using gradle-debian-helper the poms land in
/generated/debian/ and not under the home directory.



Bug#912231: bnd FTBFS with OpenJDK 11

2018-12-20 Thread Markus Koschany
Hi,

Am 19.12.18 um 22:32 schrieb Emmanuel Bourg:
> Le 29/10/2018 à 23:32, Markus Koschany a écrit :
>> The OpenJDK 11 issue is rather simple to fix, however the build fails
>> later on with this error message, a Gradle issue?
> 
> I've figured out what is causing the second issue, the poms are
> installed into .gradle/daemon/4.4.1/debian/.m2/ instead of debian/.m2/.
> 
> Due to the way gradle-debian-helper 2.0.1 injects its code in the Gradle
> classpath the Gradle daemon is always started, and the daemon uses a
> different working directory (.gradle/daemon/4.4.1/). Since the location
> of the Maven repository where the artifacts are installed is specified
> as a relative path, it's shifted under the daemon working directory and
> maven-repo-helper no longer finds the artifacts at the expected path.
> 
> This can be fixed by setting the repository location with an absolute
> path (the HOME variable in debian/rules).
> 
> Emmanuel Bourg

Thanks for fixing this bug. I believe others will be affected by it too
in the future. Shouldn't that be fixed in gradle-debian-helper instead?
I mean it's not obvious that one has to export HOME now. I have no
immediate solution though.

Regards,

Markus



signature.asc
Description: OpenPGP digital signature


Bug#912231: bnd FTBFS with OpenJDK 11

2018-12-19 Thread Emmanuel Bourg
Le 29/10/2018 à 23:32, Markus Koschany a écrit :
> The OpenJDK 11 issue is rather simple to fix, however the build fails
> later on with this error message, a Gradle issue?

I've figured out what is causing the second issue, the poms are
installed into .gradle/daemon/4.4.1/debian/.m2/ instead of debian/.m2/.

Due to the way gradle-debian-helper 2.0.1 injects its code in the Gradle
classpath the Gradle daemon is always started, and the daemon uses a
different working directory (.gradle/daemon/4.4.1/). Since the location
of the Maven repository where the artifacts are installed is specified
as a relative path, it's shifted under the daemon working directory and
maven-repo-helper no longer finds the artifacts at the expected path.

This can be fixed by setting the repository location with an absolute
path (the HOME variable in debian/rules).

Emmanuel Bourg



Bug#912231: bnd FTBFS with OpenJDK 11

2018-10-29 Thread Markus Koschany
The OpenJDK 11 issue is rather simple to fix, however the build fails
later on with this error message, a Gradle issue?

Patch is attached.

Cannot find pom file
/build/bnd-3.5.0/debian/.m2/repository/biz/aQute/bnd/aQute.libg/3.5.0/aQute.libg-3.5.0.pom
Oct 29, 2018 7:44:01 PM org.debian.maven.repo.POMCleaner cleanPom
SEVERE: null
java.io.FileNotFoundException:
debian/.m2/repository/biz/aQute/bnd/aQute.libg/3.5.0/aQute.libg-3.5.0.pom (No
such file or directory)
>---at java.base/java.io.FileInputStream.open0(Native Method)
>---at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
>---at java.base/java.io.FileInputStream.(FileInputStream.java:157)
>---at org.debian.maven.util.Readers.read(Readers.java:50)
>---at org.debian.maven.repo.POMReader.readPom(POMReader.java:57)
>---at
org.debian.maven.repo.POMTransformer.transformPom(POMTransformer.java:226)
>---at
org.debian.maven.repo.POMTransformer.transformPom(POMTransformer.java:211)
>---at org.debian.maven.repo.POMCleaner.cleanPom(POMCleaner.java:75)
>---at org.debian.maven.repo.POMCleaner.main(POMCleaner.java:372)

Cannot find pom file
/build/bnd-3.5.0/debian/.m2/repository/biz/aQute/bnd/aQute.libg/3.5.0/aQute.libg-3.5.0.pom
Oct 29, 2018 7:44:02 PM org.debian.maven.repo.POMCleaner cleanPom
SEVERE: null
java.io.FileNotFoundException:
debian/.m2/repository/biz/aQute/bnd/aQute.libg/3.5.0/aQute.libg-3.5.0.pom (No
such file or directory)
>---at java.base/java.io.FileInputStream.open0(Native Method)
>---at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
>---at java.base/java.io.FileInputStream.(FileInputStream.java:157)
>---at org.debian.maven.util.Readers.read(Readers.java:50)
>---at org.debian.maven.repo.POMReader.readPom(POMReader.java:57)
>---at
org.debian.maven.repo.POMTransformer.transformPom(POMTransformer.java:226)
>---at
org.debian.maven.repo.POMTransformer.transformPom(POMTransformer.java:211)
>---at org.debian.maven.repo.POMCleaner.cleanPom(POMCleaner.java:75)
>---at org.debian.maven.repo.POMCleaner.main(POMCleaner.java:372)

/usr/bin/mh_installpom: line 148: debian/.mh/pom.properties: No such
file or directory
make: *** [debian/rules:9: binary] Error 1
From: Markus Koschany 
Date: Mon, 29 Oct 2018 20:36:31 +0100
Subject: java11

Fix biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java:41: error:
nullOutputStream() in RedirectOutput cannot override nullOutputStream() in
OutputStream private static PrintStream nullOutputStream() { ^ attempting to
assign weaker access privileges; was public

Bug-Debian: https://bugs.debian.org/912231
Forwarded: no
---
 biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java b/biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java
index 28ee248..fde8e95 100644
--- a/biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java
+++ b/biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java
@@ -38,7 +38,7 @@ public class RedirectOutput extends PrintStream {
 		this.err = err;
 	}
 
-	private static PrintStream nullOutputStream() {
+	public static PrintStream nullOutputStream() {
 		return new PrintStream(new NullOutputStream());
 	}
 


signature.asc
Description: OpenPGP digital signature


Bug#912231: bnd FTBFS with OpenJDK 11

2018-10-29 Thread Adrian Bunk
Source: bnd
Version: 3.5.0-3
Severity: serious
Tags: ftbfs

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/bnd.html

...
Compiling with JDK Java compiler API.
Generated bundles: 
[/build/1st/bnd-3.5.0/biz.aQute.tester/generated/biz.aQute.tester.jar]
:biz.aQute.tester:jar (Thread[Task worker for ':' Thread 9,5,main]) completed. 
Took 0.132 secs.
/build/1st/bnd-3.5.0/biz.aQute.remote/src/aQute/remote/agent/RedirectOutput.java:41:
 error: nullOutputStream() in RedirectOutput cannot override nullOutputStream() 
in OutputStream
private static PrintStream nullOutputStream() {
   ^
  attempting to assign weaker access privileges; was public
1 error
:biz.aQute.remote:compileJava FAILED
:biz.aQute.remote:compileJava (Thread[Task worker for ':' Thread 3,5,main]) 
completed. Took 0.596 secs.
:biz.aQute.repository:compileJava (Thread[Task worker for ':' Thread 
11,5,main]) completed. Took 1.962 secs.

FAILURE: Build failed with an exception.