Bug#914554: clxclient FTBFS: freetype-config not found

2018-12-16 Thread Sebastian Ramacher
On 2018-11-25 13:32:18, Mattia Rizzolo wrote:
> On Sun, Nov 25, 2018 at 10:51:22AM +, Hugh McMaster wrote:
> > clxclient (build-)depends on libxft-dev, which depends on libfreetype6-dev.
> > So, it looks like clxclient used the secondary dependency to
> > get access to freetype-config.
> 
> Even so, it tries to use stuff provided by libfreetype6-dev
> directly, so it also should have a direct build-depdency.

No, it doesn't. clxclient actually needs to invoke pkg-config for Xft instead of
handling Xft's dependencies.

Cheers
-- 
Sebastian Ramacher


signature.asc
Description: PGP signature


Bug#914554: clxclient FTBFS: freetype-config not found

2018-11-25 Thread Mattia Rizzolo
On Sun, Nov 25, 2018 at 10:51:22AM +, Hugh McMaster wrote:
> clxclient (build-)depends on libxft-dev, which depends on libfreetype6-dev.
> So, it looks like clxclient used the secondary dependency to
> get access to freetype-config.

Even so, it tries to use stuff provided by libfreetype6-dev
directly, so it also should have a direct build-depdency.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#914554: clxclient FTBFS: freetype-config not found

2018-11-24 Thread Mattia Rizzolo
On Sat, Nov 24, 2018 at 09:43:31PM +0100, Helmut Grohne wrote:
> Source: clxclient
> Version: 3.9.0-4
> Severity: serious
> Tags: ftbfs patch upstream
> 
> clxclient fails to build from source in unstable, because
> freetype-config got removed. You're supposed to use pkg-config instead.
> The attached patch fixes the build.

That's despite the package not build-dependending on freetype nor any
binary having a dependency on it.
That's wrong on several levels, so please investigate why is it so, I'd
expect both a build-dep and a runtime dependency.


-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#914554: clxclient FTBFS: freetype-config not found

2018-11-24 Thread Helmut Grohne
Source: clxclient
Version: 3.9.0-4
Severity: serious
Tags: ftbfs patch upstream

clxclient fails to build from source in unstable, because
freetype-config got removed. You're supposed to use pkg-config instead.
The attached patch fixes the build.

Helmut
--- clxclient-3.9.0.orig/Makefile
+++ clxclient-3.9.0/Makefile
@@ -31,8 +31,9 @@
 VERSION = $(MAJVERS).$(MINVERS)
 
 
-CPPFLAGS += -Wall -I. -I/usr/X11R6/include `freetype-config --cflags` -fpic -DVERSION=\"$(VERSION)\" -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -O2 
-LDFLAGS += -L/usr/X11R6/$(LIBDIR) -Wl,--as-needed `freetype-config --libs`
+PKG_CONFIG ?= pkg-config
+CPPFLAGS += -Wall -I. -I/usr/X11R6/include `$(PKG_CONFIG) freetype2 --cflags` -fpic -DVERSION=\"$(VERSION)\" -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -O2 
+LDFLAGS += -L/usr/X11R6/$(LIBDIR) -Wl,--as-needed `$(PKG_CONFIG) freetype2 --libs`
 LDLIBS +=