On Fri, Nov 30, 2018 at 12:20:28AM +0100, Bill Allombert wrote:
> Hello Mattia, the actual Debian tarball is generated by
> debian/tarball, so if debian/watch mangles the version
> then debian/tarball must be changed not to do it.
oh, sorry. I clearly didn't look around the package. However I believe
you wouldn't need to modify anything in that file even after my proposed
change. However looking at that file I couldn't help but think that
what you do that is nowadays suggested to do though a Files-Excluded
field in d/copyright following copyright-format 1.0 (something that gap
is not using, and could potentially be quite a big task to adopt, even
if I recommend it).
What my changes do is only to mangle the internal view that uscan uses
to compare against the version used upstream, i.e. even after that
change it would still download a file named e.g. 1.10.0.
> It seems to me there might be some benefit to your change that you are
> not communicating.
I was only thinking of that because I noticed the message "A new
upstream version is available" on the tracker, that I believe is always
present with the watchfile as it is now, even when the software is fully
up to date. Whereas I think that with my changes uscan would finally be
able to properly compare the debian version against upstream and such
you wouldn't needlessly have such message (same for the DDPO, of
course).
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
