Bug#915354: Bug#921482: RFS: note/1.3.26-3 +help
[2019-02-15 23:21] eamanu15 > I've just upload to m.d.n the update. > > https://mentors.debian.net/debian/pool/main/n/note/note_1.3.26-3.dsc Let's see. Here is commented debdiff (difference between note=1.3.26-2 and proposed note=1.3.26-3) > > diff -Nru note-1.3.26/debian/changelog note-1.3.26/debian/changelog > > --- note-1.3.26/debian/changelog2019-01-16 17:26:39.0 + > > +++ note-1.3.26/debian/changelog2019-01-30 01:31:36.0 + > > @@ -1,3 +1,14 @@ > > +note (1.3.26-3) unstable; urgency=medium > > + > > + * Set myself as Maintainer. There is no change of `debian/control'. I do not fully understand what happened in git, but there is no such change between source packages. > > + * Update fix-spelling.patch because is old. Please, reword as "Refresh fix-spelling.patch". More conventional. > > + * Update d/watch file to download the upstream version > > +from CPAN repository. > > + * Adding on d/rules a sentence to delete README from > > +/usr/share/perl5/NOTEDB/ I am not language expert, but last entry seems overly complicated. What about "Do not install README into /usr/share/perl5."? If you disagree, we can call l10n-english@ for advice of language experts. > > + > > + -- Emmanuel Arias Wed, 30 Jan 2019 01:31:36 > > + > > + > > note (1.3.26-2) unstable; urgency=medium > > > >* New Maintainer (Closes: 900663). > > diff -Nru note-1.3.26/debian/patches/fix-spelling.patch > > note-1.3.26/debian/patches/fix-spelling.patch > > --- note-1.3.26/debian/patches/fix-spelling.patch 2018-12-24 > > 06:42:23.0 + > > +++ note-1.3.26/debian/patches/fix-spelling.patch 2019-01-30 > > 01:31:36.0 + > > @@ -1,39 +1,36 @@ > > -Description: Fix spelling problems detected by Lintian. > > -Author: Alexandre De Dommelin > > -Forwarded: yes > > -Last-Updated: 2017-08-16 > > a/note.pod > > -+++ b/note.pod > > -@@ -316,7 +316,7 @@ You can achieve the same result by simpl > > - You can create a new note by simply pressing B or B. You favorite > > - editor will be started and you can enter your note text. If you are > > already > > - under a topic then this new note will automatically go to this topic. > > --note adds an aditional line to the top of the note with the topic. But > > -+note adds an additional line to the top of the note with the topic. But > > - you can of course specify your own topic. > > - > > - Note will tell you which number it has assigned to the newly created note. > > -@@ -393,7 +393,7 @@ Quit note. > > - > > - You can also dump the contents of your note-database into a > > - ASCII-textfile(I<-D>). You can use this file later to import it into > > --your note-database(-I). This is usefull, if you want quickly trans- > > -+your note-database(-I). This is useful, if you want quickly trans- > > - fer your notes from one host to another (i.e. you could mail > > - your note-dump form your office to home and import it there > > - for further use). > > -@@ -467,7 +467,7 @@ character. Here are the available things > > - The text will be formatted using the actually note-color. > > - > > - The hidden formatting will use blue forground and blue background > > --to hide a string from the terminal, which is usefull for passwords. > > -+to hide a string from the terminal, which is useful for passwords. > > - > > - If you set "FormatText" to I then the formatting can be > > - done this way instead: > > a/lib/NOTEDB/mysql.pm > > -+++ b/lib/NOTEDB/mysql.pm > > -@@ -382,7 +382,7 @@ NOTEDB::mysql - module lib for accessing > > +Fix spelling on several filesIndex: note/lib/NOTEDB/README > > +=== > > +Index: note/lib/NOTEDB/README > > +=== > > +--- note.orig/lib/NOTEDB/README > > note/lib/NOTEDB/README > > +@@ -1,7 +1,7 @@ > > + perl modules for note used as database backends. > > + the install.sh script will install both of them, > > + although you may only need one backend. Perhaps > > +-other users on your system have oter ideas in mind... > > ++other users on your system have other ideas in mind... > > + > > + Therefore, please ignore these file. There is nothing > > + to edit or to do. Simply leave this directory :-) > > +Index: note/lib/NOTEDB/binary.pm > > +=== > > +--- note.orig/lib/NOTEDB/binary.pm > > note/lib/NOTEDB/binary.pm > > +@@ -481,7 +481,7 @@ However, both versions provides identica > > + not need to change your code, if you want to switch to another database > > format. > > + > > + Currently, NOTEDB module is only used by note itself. But feel free to > > use it > > +-within your own project! Perhaps someone want to implement a webinterface > > to > > ++within your own project! Perhaps someone want to implement a web > > interface to > > + note... > > + > > + =head1 USAGE > > +Index:
Bug#915354: Bug#921482: RFS: note/1.3.26-3 +help
I've just upload to m.d.n the update. https://mentors.debian.net/debian/pool/main/n/note/note_1.3.26-3.dsc El vie., 15 de feb. de 2019 a la(s) 15:06, eamanu15 ( emmanuelaria...@gmail.com) escribió: > Hi, > > > El vie., 15 de feb. de 2019 a la(s) 14:27, Dmitry Bogatov ( > kact...@debian.org) escribió: > >> >> [2019-02-11 22:00] eamanu15 >> > If you look >> > >> https://salsa.debian.org/eamanu-guest/note/commit/b2fbec0443dd078dfbcf05efab7729ee3b2e6e3e >> > you will see that I set myself as maintainer. The Version of note on >> salsa >> > was: 1.3.22 >> > But on unstable was 1.3.26 >> > >> > For this reason, I download the files from package.debian >> > the 1.3.26 and updated it on salsa: >> > >> https://salsa.debian.org/eamanu-guest/note/commit/0bb88562fd7c3b2a2035bd0d0f5b919b4a24af15 >> > >> > But, when I continue working on the package on >> > >> https://salsa.debian.org/eamanu-guest/note/commit/5bc4330c7f174713549f4bf4e1839d669e637551 >> > I forgot set myself as maintainer. Was my foul. >> > >> > For this reason In this new package version 1.3.26-3 I add me >> > on Maintainer field. >> >> So I believe simple "Set myself as Maintainer" would do. Or am I missing >> something again? >> > > Nope, you are right. I will write that > > Thanks > >> -- >> Note, that I send and fetch email in batch, once every 24 hours. >> If matter is urgent, try https://t.me/kaction >> >>-- >> > > > -- > Arias Emmanuel > http://eamanu.com > Github/Gitlab; @eamanu > Debian: @eamanu-guest > -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
Bug#915354: Bug#921482: RFS: note/1.3.26-3 +help
Hi, El vie., 15 de feb. de 2019 a la(s) 14:27, Dmitry Bogatov ( kact...@debian.org) escribió: > > [2019-02-11 22:00] eamanu15 > > If you look > > > https://salsa.debian.org/eamanu-guest/note/commit/b2fbec0443dd078dfbcf05efab7729ee3b2e6e3e > > you will see that I set myself as maintainer. The Version of note on > salsa > > was: 1.3.22 > > But on unstable was 1.3.26 > > > > For this reason, I download the files from package.debian > > the 1.3.26 and updated it on salsa: > > > https://salsa.debian.org/eamanu-guest/note/commit/0bb88562fd7c3b2a2035bd0d0f5b919b4a24af15 > > > > But, when I continue working on the package on > > > https://salsa.debian.org/eamanu-guest/note/commit/5bc4330c7f174713549f4bf4e1839d669e637551 > > I forgot set myself as maintainer. Was my foul. > > > > For this reason In this new package version 1.3.26-3 I add me > > on Maintainer field. > > So I believe simple "Set myself as Maintainer" would do. Or am I missing > something again? > Nope, you are right. I will write that Thanks > -- > Note, that I send and fetch email in batch, once every 24 hours. > If matter is urgent, try https://t.me/kaction > >-- > -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
Bug#915354: Bug#921482: RFS: note/1.3.26-3 +help
[2019-02-11 22:00] eamanu15 > If you look > https://salsa.debian.org/eamanu-guest/note/commit/b2fbec0443dd078dfbcf05efab7729ee3b2e6e3e > you will see that I set myself as maintainer. The Version of note on salsa > was: 1.3.22 > But on unstable was 1.3.26 > > For this reason, I download the files from package.debian > the 1.3.26 and updated it on salsa: > https://salsa.debian.org/eamanu-guest/note/commit/0bb88562fd7c3b2a2035bd0d0f5b919b4a24af15 > > But, when I continue working on the package on > https://salsa.debian.org/eamanu-guest/note/commit/5bc4330c7f174713549f4bf4e1839d669e637551 > I forgot set myself as maintainer. Was my foul. > > For this reason In this new package version 1.3.26-3 I add me > on Maintainer field. So I believe simple "Set myself as Maintainer" would do. Or am I missing something again? -- Note, that I send and fetch email in batch, once every 24 hours. If matter is urgent, try https://t.me/kaction --
Bug#915354: Bug#921482: RFS: note/1.3.26-3 +help
control: tags -1 +help I add @bugs.d.o with the tag. El sáb., 9 de feb. de 2019 a la(s) 13:36, Dmitry Bogatov (kact...@debian.org) escribió: > > control: tags -1 +help > > [2019-02-07 14:39] eamanu15 > > > > > > > > * Add me to Maintainer Field on d/control: > > > > - For some reason that I ignore the Maintainer field > > > > on d/control was not updated. > > > > > > Sorry, I do not understand this sentense. Mind to simplify explaination > > > what changed? > > > > > In the middle of my ITA, I have the "little" problem that > > the unstable version was different with the salsa. I contacted > > with the maintainer to push the last version on salsa, but I did not > > have response. So, I download the orig.tar.gz and debian.tz file. > > Then, and replace the files and > > I forgot change the Maintainer field d/control. > > > > Because of that I write: "For some reason that I ignore the Maintainer > field > > on d/control was not updated." > > Still do not understand. You either updated Maintainer field, in which > case you should write something like "Set myself as maintainer", maybe > with "(Closes: #O-Bug-Number)", or you did not. It is changelog. > If you look https://salsa.debian.org/eamanu-guest/note/commit/b2fbec0443dd078dfbcf05efab7729ee3b2e6e3e you will see that I set myself as maintainer. The Version of note on salsa was: 1.3.22 But on unstable was 1.3.26 For this reason, I download the files from package.debian the 1.3.26 and updated it on salsa: https://salsa.debian.org/eamanu-guest/note/commit/0bb88562fd7c3b2a2035bd0d0f5b919b4a24af15 But, when I continue working on the package on https://salsa.debian.org/eamanu-guest/note/commit/5bc4330c7f174713549f4bf4e1839d669e637551 I forgot set myself as maintainer. Was my foul. For this reason In this new package version 1.3.26-3 I add me on Maintainer field. > > Added tag +help. Fellow developers, I need help reviewing this entry. > > > > > * Delete NOTEDB folder and NOTEDB.pm because they are > > > > not on upstream from ad6cb95 commit (Github). > > > > > > What is ad6cb95 commit? For person who do not follow upstream > > > development, this changelog entry brings more questions, then > > > explainations. > > > > > > > Ok I will write > > * Delete NOTEDB folder and NOTEDB.pm because they > > are not necessary. > > > > What about it? > > In this case I understand "what" is done, but still do not understand > "why". You package some specific release. What is the purpose of > backporting changes from upstream HEAD? > > > No, but I want to have the package as close as possible to the upstream. > > In general, we at Debian package releases, we do not follow upstream > development commit-after-commit. Usually, we backport patches only to > fix some bug. > Ok I will delete that patch. Thanks for the review. Regards > -- > Note, that I send and fetch email in batch, once every 24 hours. > If matter is urgent, try https://t.me/kaction > >-- > -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
