Bug#915925: libxfce4util: Uses vendor-specific patch series file (ubuntu.series)

2018-12-15 Thread Mattia Rizzolo 
Hi,

On Thu, Dec 13, 2018 at 10:37:38PM +0100, Chris Lamb wrote:
> > > Please migrate away from such series files and consider alternatives
> > > such differing source packages or modify the build process to behave
> > > conditionally or to conditionally patch files explicitly.
> […] 
> > is there a documented way to actually do that in a simple/maintainable way
> 
> I'm not aware of a documented way that matches this description, alas.

Indeed, the ctte decision didn't provide any migration path.

> I've had some brief discussions with in Mattia (CC'd) that might be
> useful though; he had migrated away from an foo.series in another
> package and I had mooted writing a possible "include"-able .mk snippet.

I moved avay from foo.series in hexchat.
https://salsa.debian.org/debian/hexchat/commit/dd1b936d907d664c0f9e10119778d99228591f60
That thing seems to work correctly, but it's kind of horrible.  At least
you don't have to distiguish between ubuntu-specific and debian-specific
patches.

Another way would be to wrap the ubuntu specific code in #ifdef and set
that conditionally in d/rules.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#915925: libxfce4util: Uses vendor-specific patch series file (ubuntu.series)

2018-12-13 Thread Chris Lamb 
[Adding mat...@debian.org to CC]

Hi Yves-Alexis Perez,

> > Please migrate away from such series files and consider alternatives
> > such differing source packages or modify the build process to behave
> > conditionally or to conditionally patch files explicitly.
[…] 
> is there a documented way to actually do that in a simple/maintainable way

I'm not aware of a documented way that matches this description, alas.

I've had some brief discussions with in Mattia (CC'd) that might be
useful though; he had migrated away from an foo.series in another
package and I had mooted writing a possible "include"-able .mk snippet.

Hope that helps in the meantime.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#915925: libxfce4util: Uses vendor-specific patch series file (ubuntu.series)

2018-12-13 Thread Yves-Alexis Perez 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On Fri, 2018-12-07 at 23:16 +0100, Chris Lamb wrote:
> Please migrate away from such series files and consider alternatives
> such differing source packages or modify the build process to behave
> conditionally or to conditionally patch files explicitly.

Hi,

is there a documented way to actually do that in a simple/maintainable way
(and not annoying for Ubuntu maintainers)?

Regards,
- -- 
Yves-Alexis
-BEGIN PGP SIGNATURE-

iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAlwSz7QACgkQ3rYcyPpX
RFuQyQf/YxXmt7h1+1pslK/6IqUsxOWfsdx3hdlEgXClthYkkNSez+BpOE/tNnc6
AHpE/kg4Re8+bw18ODax9PZw4dX/cPEeStJfq+Qjcnoff4uAQoZa0ZzMJuCzyIdq
wxOqio2Xqtrykit3HqltCyMnFnIUmamzAzAG2Orkv3MozfTgfITpAVgEPuc4CI2A
HfRrV8JIzJfQ5RXZmUVe5FJZr3/HD+Nd4bydHOkfOnMC1t8HmmDOc9KsZS5rvMAV
ye0Y3/MD2d8wo6KY8mA/sNp3aCiTi41GKDC0KRaAHRggBUo/avT2tSLJyAjBbLva
VBIk3tkoeHQfdsWe0QV1g8B683f+LQ==
=zEC/
-END PGP SIGNATURE-

Bug#915925: libxfce4util: Uses vendor-specific patch series file (ubuntu.series)

2018-12-07 Thread Chris Lamb 
Source: libxfce4util
Version: 4.13.2-1
Severity: important
User: la...@debian.org
Usertags: package-uses-vendor-specific-patch-series

Dear Maintainer,

libxfce4util appears to use a vendor-specific patch series file:

  debian/patches/ubuntu.series

This is feature of dpkg that can be used to apply a different series
of quilt patches when the source package is unpacked on different
systems. However, since Debian source packages are usually treated as
a pure transport format this can cause confusion and frustration.

Please migrate away from such series files and consider alternatives
such differing source packages or modify the build process to behave
conditionally or to conditionally patch files explicitly.

After Buster is released, the presence of a vendor-specific patch
series will be a violation of a MUST directive in Debian policy.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-