Bug#917726: globus-gass-copy: FTBFS: tests failed

2019-01-08 Thread Lucas Nussbaum
On 08/01/19 at 10:16 +0100, Mattias Ellert wrote:
> mån 2019-01-07 klockan 09:20 +0100 skrev Lucas Nussbaum:
> > Hi,
> > 
> > On 07/01/19 at 08:28 +0100, Mattias Ellert wrote:
> > > Hi!
> > > 
> > > The globus-gass-copy package and dependent packaged have now been
> > > tagged for autoremoval due to this RC bug. So I need to resolve this
> > > with some urgency.
> > > 
> > > Since I did not receive any reply to my previous comment I need to
> > > resolve this without the additional feedback I requested.
> > > 
> > > I will close this as "not a bug" since I believe the failure to be due
> > > to a misconfiguration of the rebuild test build server, and not a real
> > > bug (see the above mentioned comment for details).
> > > 
> > > If this is not satisfactory, please feel welcome to reopen the bug and
> > > provide additional information about why you believe the bug report is
> > > valid.
> > > 
> > >   Mattias
> > 
> > Well, I'm not sure about this bug.
> > 
> > It seems that it fails to build with '!' in /etc/shadow, with '*' in
> > /etc/shadow, and even with a password in /etc/shadow. I don't know if
> > sbuild is doing something strange, but it doesn't look like it.
> > 
> > Also, this is (AFAIK) the only package failing because of this.
> > 
> > Lucas
> 
> Checking the code of the server binary used during the test, what is
> checked by the server to ensure logins are not enabled is:
> 
> 1. That a shell is defined for the user and that this shell exists
> 2. That the defined shell is a regular file
> 3. That the defined shell has executable permissions.

Ah! thanks! I can confirm that after setting a shell, it builds fine.

I'll go through the other failures to detect misfiled bugs.

Lucas


signature.asc
Description: PGP signature


Bug#917726: globus-gass-copy: FTBFS: tests failed

2019-01-08 Thread Mattias Ellert
mån 2019-01-07 klockan 09:20 +0100 skrev Lucas Nussbaum:
> Hi,
> 
> On 07/01/19 at 08:28 +0100, Mattias Ellert wrote:
> > Hi!
> > 
> > The globus-gass-copy package and dependent packaged have now been
> > tagged for autoremoval due to this RC bug. So I need to resolve this
> > with some urgency.
> > 
> > Since I did not receive any reply to my previous comment I need to
> > resolve this without the additional feedback I requested.
> > 
> > I will close this as "not a bug" since I believe the failure to be due
> > to a misconfiguration of the rebuild test build server, and not a real
> > bug (see the above mentioned comment for details).
> > 
> > If this is not satisfactory, please feel welcome to reopen the bug and
> > provide additional information about why you believe the bug report is
> > valid.
> > 
> > Mattias
> 
> Well, I'm not sure about this bug.
> 
> It seems that it fails to build with '!' in /etc/shadow, with '*' in
> /etc/shadow, and even with a password in /etc/shadow. I don't know if
> sbuild is doing something strange, but it doesn't look like it.
> 
> Also, this is (AFAIK) the only package failing because of this.
> 
> Lucas

Checking the code of the server binary used during the test, what is
checked by the server to ensure logins are not enabled is:

1. That a shell is defined for the user and that this shell exists
2. That the defined shell is a regular file
3. That the defined shell has executable permissions.

Mattias



signature.asc
Description: This is a digitally signed message part


Bug#917726: globus-gass-copy: FTBFS: tests failed

2019-01-07 Thread Lucas Nussbaum
Hi,

On 07/01/19 at 08:28 +0100, Mattias Ellert wrote:
> Hi!
> 
> The globus-gass-copy package and dependent packaged have now been
> tagged for autoremoval due to this RC bug. So I need to resolve this
> with some urgency.
> 
> Since I did not receive any reply to my previous comment I need to
> resolve this without the additional feedback I requested.
> 
> I will close this as "not a bug" since I believe the failure to be due
> to a misconfiguration of the rebuild test build server, and not a real
> bug (see the above mentioned comment for details).
> 
> If this is not satisfactory, please feel welcome to reopen the bug and
> provide additional information about why you believe the bug report is
> valid.
> 
>   Mattias

Well, I'm not sure about this bug.

It seems that it fails to build with '!' in /etc/shadow, with '*' in
/etc/shadow, and even with a password in /etc/shadow. I don't know if
sbuild is doing something strange, but it doesn't look like it.

Also, this is (AFAIK) the only package failing because of this.

Lucas


signature.asc
Description: PGP signature


Bug#917726: globus-gass-copy: FTBFS: tests failed

2019-01-02 Thread Mattias Ellert
Hi Lucas.

I have a question regarding your report.

Is it really a requirement that the package build should succeed even
if the user account doing the package build is disabled for logins?

Not accepting remote logins during the build is very reasonable. But a
test that starts a server on the build machine to accept logins from
test scripts running on the same build machine should be allowed.

This has not been a problem before. These tests work fine when building
using pbuilder locally, and there has never been a problem when running
the tests during the builds on the buildd servers either in the past.

Is this a misconfiguration of the FTBFS test build server, or is it
really intended to block logins from localhost to localhost during the
build?

It is not impossible to fix this. The server binary that is used during
the test has an -allow-disabled-logins flag already, so I can add that
to the test wrapper script. But I just wanted to check that this
restriction was really intended before I do this.

Mattias

lör 2018-12-29 klockan 23:26 +0100 skrev Lucas Nussbaum:
> Source: globus-gass-copy
> Version: 10.3-2
> Severity: serious
> Justification: FTBFS on amd64
> Tags: buster sid
> Usertags: ftbfs-20181229 ftbfs-buster
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
> 
> > # 
> > # error: globus_ftp_client: the server responded with an error
> > # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> The full build log is available from:
>http://aws-logs.debian.net/2018/12/29/globus-gass-copy_10.3-2_unstable.log
> 
> A list of current common problems and possible solutions is available at
> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
> 
> About the archive rebuild: The rebuild was done on EC2 VM instances from
> Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
> failed build was retried once to eliminate random failures.



smime.p7s
Description: S/MIME cryptographic signature


Bug#917726: globus-gass-copy: FTBFS: tests failed

2018-12-29 Thread Lucas Nussbaum
Source: globus-gass-copy
Version: 10.3-2
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20181229 ftbfs-buster

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> make[4]: Entering directory '/<>/test'
> FAIL: guc-fw.pl
> FAIL: guc-pp-cc.pl
> FAIL: guc-stack.pl
> FAIL: guc-cc.pl
> FAIL: guc-cc-fast.pl
> FAIL: guc-cc-p2.pl
> FAIL: guc-cc-p4.pl
> FAIL: guc-cc-stripe.pl
> FAIL: guc-cc-stripe-p4.pl
> 
>globus_gass_copy 10.3: test/test-suite.log
> 
> 
> # TOTAL: 9
> # PASS:  0
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  9
> # XPASS: 0
> # ERROR: 0
> 
> .. contents:: :depth: 2
> 
> FAIL: guc-fw.pl
> ===
> 
> # Started server at port 45897
> 1..32
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 1 - guc fw -nodcau exits with 0
> #   Failed test 'guc fw -nodcau exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 2 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 3 - guc fw exits with 0
> #   Failed test 'guc fw exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 4 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 5 - guc fw -dcsafe exits with 0
> #   Failed test 'guc fw -dcsafe exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 6 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 7 - guc fw -dcpriv exits with 0
> #   Failed test 'guc fw -dcpriv exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 8 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 9 - guc fw -fast -nodcau exits with 0
> #   Failed test 'guc fw -fast -nodcau exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 10 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 11 - guc fw -fast exits with 0
> #   Failed test 'guc fw -fast exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 12 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 13 - guc fw -fast -dcsafe exits with 0
> #   Failed test 'guc fw -fast -dcsafe exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 14 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 15 - guc fw -fast -dcpriv exits with 0
> #   Failed test 'guc fw -fast -dcpriv exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 16 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 17 - guc fw -p 2 -nodcau exits with 0
> #   Failed test 'guc fw -p 2 -nodcau exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 18 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 19 - guc fw -p 2 exits with 0
> #   Failed test 'guc fw -p 2 exits with 0'
> #   at ./guc-fw.pl line 121.
> not ok 20 - guc-fw data compare
> #   Failed test 'guc-fw data compare'
> #   at ./guc-fw.pl line 124.
> # stderr:
> # 
> # error: globus_ftp_client: the server responded with an error
> # 530 Login incorrect. : Access denied, user's system account is disabled.
> 
> # 
> not ok 21 - guc fw -p 2 -dcsafe exits