Bug#918760: agree on how to find qhelpgenerator
Control: reassign -1 src:kpackage Control: retitle -1 kpackage should Build-Depends: qttools5-dev Control: block -1 by 915122 Control: tags 915122 + upstream fixed-upstream patch On Wed, Jan 09, 2019 at 02:48:17PM +0300, Dmitry Shachnev wrote: > On Wed, Jan 09, 2019 at 06:24:32AM +0100, Helmut Grohne wrote: > > kpackage fails to cross build from source and the cause is tricky. We > > start our journey on extra-cmake-modules' > > /usr/share/ECM/find-modules/FindQHelpGenerator.cmake. That file assumes > > that it will find a "qhelpgenerator" executable next to the qmake > > executable. The path of qmake is determined using > > > > get_target_property(_qmake_EXECUTABLE Qt5::qmake LOCATION) > > That is the fallback code path. Oh right. > As I said before in #915122, the correct fix is: > > - Cherry-picking commit [1] for extra-cmake-modules or updating it to 5.53.0. > - Making all affected packages build-depend on qttools5-dev. I'm sorry for failing to notice the existing report. I guess I have too many open bug reports now and should slow down filing... I'm repurposing this bug for adding the dependency to kpackage. Helmut
Bug#918760: agree on how to find qhelpgenerator
Hi all, On Wed, Jan 09, 2019 at 06:24:32AM +0100, Helmut Grohne wrote: > kpackage fails to cross build from source and the cause is tricky. We > start our journey on extra-cmake-modules' > /usr/share/ECM/find-modules/FindQHelpGenerator.cmake. That file assumes > that it will find a "qhelpgenerator" executable next to the qmake > executable. The path of qmake is determined using > > get_target_property(_qmake_EXECUTABLE Qt5::qmake LOCATION) That is the fallback code path. The primary code path is retrieving this information from qttools5-dev's Qt5HelpConfigExtras.cmake which has it set to "${_qt5Help_install_prefix}/lib/qt5/bin/qcollectiongenerator". > extra-cmake-modules's assumption on how to find qhelpgenerator is not > presently valid. We'll either have to reinstate the assumption or make > extra-cmake-modules not assume that. > > Now I need your input on which package we need to touch. As I said before in #915122, the correct fix is: - Cherry-picking commit [1] for extra-cmake-modules or updating it to 5.53.0. - Making all affected packages build-depend on qttools5-dev. Dear Maximiliano (Cc-ed), I noticed that you updated the packaging to 5.53.0 in Git. Are you going to upload it to sid? If no, can you please cherry-pick the mentioned commit, or will you mind if I do it myself? [1]: https://cgit.kde.org/extra-cmake-modules.git/commit/?id=96d169b87292d935 -- Dmitry Shachnev signature.asc Description: PGP signature
Bug#918760: agree on how to find qhelpgenerator
Package: qt5-qmake,qttools5-dev-tools,extra-cmake-modules User: helm...@debian.org Usertags: rebootstrap Control: affects -1 + src:kpackage kpackage fails to cross build from source and the cause is tricky. We start our journey on extra-cmake-modules' /usr/share/ECM/find-modules/FindQHelpGenerator.cmake. That file assumes that it will find a "qhelpgenerator" executable next to the qmake executable. The path of qmake is determined using get_target_property(_qmake_EXECUTABLE Qt5::qmake LOCATION) and results in: /usr/lib//qt5/bin/qmake Now, qttools5-dev-tools places qhelpgenerator in /usr/lib/qt5/bin/qhelpgenerator /usr/lib//qt5/bin/qhelpgenerator and qtchooser additionally makes it available as: /usr/bin/qhelpgenerator The end result is that qhelpgenerator is not found and that kpackage fails to cross build. extra-cmake-modules's assumption on how to find qhelpgenerator is not presently valid. We'll either have to reinstate the assumption or make extra-cmake-modules not assume that. Now I need your input on which package we need to touch. Helmut