Bug#920858: [Pkg-javascript-devel] Bug#920858: twitter-bootstrap4: contains generated code not included as source
Quoting Xavier (2019-01-31 08:27:57) > Le 30/01/2019 à 23:47, Jonas Smedegaard a écrit : > > Quoting Xavier (2019-01-30 22:54:53) > >> Le 30/01/2019 à 22:34, Jonas Smedegaard a écrit : > >>> Quoting Xavier (2019-01-30 22:26:57) > Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : > > Source package contains below several files embedding code > > from external project fileOverview Kickass, without source > > included. > > > > Just a clarification: Name of external project is Popper.js: > > "fileOverview" is just a marker, and "Kickass" is first word of > > Popper.js short description. > > > > > I succeed to build source, but this needs: > >>> [snip] > >>> > >>> This bugreport tracks twitter-bootstrap4 violating Policy in > >>> shipping code without source. > >>> > >>> For discussing packaging of that source in a separate package, > >>> please file an ITP bugreport (or an RFP bugreport if you don't > >>> intent on doing the work yourself), and let's discuss packaging > >>> issues there. > > > >> Also is it OK if I remove dist/bootstrap.bundle.* in Files-Excluded ? > > > > Sorry, I don't understand your question. > > > > What do you mean by "also"? Did I miss some previous conversation that > > this is an addition of? > > > > Are you asking if it is ok to violate Debian Policy here? Or is your > > question a different one? Please try rephrase... > > That's not what I said. Sorry for putting words in your mouth. What did you (mean to) say? > Anyway Jérémy found a way to patch this "grave policy violation". Yes, and that is great. I am still interested in understanding what you intended to say above. > In the same way, should you open a similar bug to any of the packages > which embeds bootstrap? Yes. I should, you should, we all should. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#920858: twitter-bootstrap4: contains generated code not included as source
Le 30/01/2019 à 23:47, Jonas Smedegaard a écrit : > Quoting Xavier (2019-01-30 22:54:53) >> Le 30/01/2019 à 22:34, Jonas Smedegaard a écrit : >>> Quoting Xavier (2019-01-30 22:26:57) Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : > Source package contains below several files embedding code > from external project fileOverview Kickass, without source > included. > > Just a clarification: Name of external project is Popper.js: > "fileOverview" is just a marker, and "Kickass" is first word of > Popper.js short description. > > I succeed to build source, but this needs: >>> [snip] >>> >>> This bugreport tracks twitter-bootstrap4 violating Policy in >>> shipping code without source. >>> >>> For discussing packaging of that source in a separate package, >>> please file an ITP bugreport (or an RFP bugreport if you don't >>> intent on doing the work yourself), and let's discuss packaging >>> issues there. > >> Also is it OK if I remove dist/bootstrap.bundle.* in Files-Excluded ? > > Sorry, I don't understand your question. > > What do you mean by "also"? Did I miss some previous conversation that > this is an addition of? > > Are you asking if it is ok to violate Debian Policy here? Or is your > question a different one? Please try rephrase... That's not what I said. Anyway Jérémy found a way to patch this "grave policy violation". In the same way, should you open a similar bug to any of the packages which embeds bootstrap?
Bug#920858: [Pkg-javascript-devel] Bug#920858: twitter-bootstrap4: contains generated code not included as source
Quoting Xavier (2019-01-30 22:54:53) > Le 30/01/2019 à 22:34, Jonas Smedegaard a écrit : > > Quoting Xavier (2019-01-30 22:26:57) > >> Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : > >>> Source package contains below several files embedding code > >>> from external project fileOverview Kickass, without source > >>> included. Just a clarification: Name of external project is Popper.js: "fileOverview" is just a marker, and "Kickass" is first word of Popper.js short description. > >> I succeed to build source, but this needs: > > [snip] > > > > This bugreport tracks twitter-bootstrap4 violating Policy in > > shipping code without source. > > > > For discussing packaging of that source in a separate package, > > please file an ITP bugreport (or an RFP bugreport if you don't > > intent on doing the work yourself), and let's discuss packaging > > issues there. > Also is it OK if I remove dist/bootstrap.bundle.* in Files-Excluded ? Sorry, I don't understand your question. What do you mean by "also"? Did I miss some previous conversation that this is an addition of? Are you asking if it is ok to violate Debian Policy here? Or is your question a different one? Please try rephrase... > Note that "fileOverview Kickass" is provided by popper.js It seems it _is_ Popper.js - see above. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#920858: [Pkg-javascript-devel] Bug#920858: twitter-bootstrap4: contains generated code not included as source
Le 30/01/2019 à 22:34, Jonas Smedegaard a écrit : > Quoting Xavier (2019-01-30 22:26:57) >> Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : >>> Source: twitter-bootstrap4 >>> Version: 4.2.1+dfsg1-1 >>> Severity: serious >>> Justification: Policy 2.1 >>> >>> Source package contains below several files embedding code from >>> external project fileOverview Kickass, without source included. >>> >>> Thanks to Xavier for noticing (although only as comment in copyright >>> file). >>> >>> >>> - Jonas >> >> I succeed to build source, but this needs: > [snip] > > This bugreport tracks twitter-bootstrap4 violating Policy in shipping > code without source. > > For discussing packaging of that source in a separate package, please > file an ITP bugreport (or an RFP bugreport if you don't intent on doing > the work yourself), and let's discuss packaging issues there. > > > - Jonas Also is it OK if I remove dist/bootstrap.bundle.* in Files-Excluded ? Note that "fileOverview Kickass" is provided by popper.js
Bug#920858: [Pkg-javascript-devel] Bug#920858: twitter-bootstrap4: contains generated code not included as source
Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : > Source: twitter-bootstrap4 > Version: 4.2.1+dfsg1-1 > Severity: serious > Justification: Policy 2.1 > > Source package contains below several files embedding code from > external project fileOverview Kickass, without source included. > > Thanks to Xavier for noticing (although only as comment in copyright > file). > > > - Jonas I succeed to build source, but this needs: - to upgrade: rollup-plugin-babel, browserslist - to package or upgrade at least (I reduced this list to the minimum possible): node-releases, rollup-plugin-babel, trim-right, @babel/core @babel/generator @babel/helper-annotate-as-pure @babel/helper-builder-binary-assignment-operator-visitor @babel/helper-call-delegate @babel/helper-define-map @babel/helper-explode-assignable-expression @babel/helper-function-name @babel/helper-get-function-arity @babel/helper-hoist-variables @babel/helper-member-expression-to-functions @babel/helper-module-imports @babel/helper-module-transforms @babel/helper-optimise-call-expression @babel/helper-plugin-utils @babel/helper-regex @babel/helper-remap-async-to-generator @babel/helper-replace-supers @babel/helpers @babel/helper-simple-access @babel/helper-split-export-declaration @babel/helper-wrap-function @babel/highlight @babel/parser @babel/plugin-proposal-async-generator-functions @babel/plugin-proposal-json-strings @babel/plugin-proposal-object-rest-spread @babel/plugin-proposal-optional-catch-binding @babel/plugin-proposal-unicode-property-regex @babel/plugin-syntax-async-generators @babel/plugin-syntax-json-strings @babel/plugin-syntax-object-rest-spread @babel/plugin-syntax-optional-catch-binding @babel/plugin-transform-arrow-functions @babel/plugin-transform-async-to-generator @babel/plugin-transform-block-scoped-functions @babel/plugin-transform-block-scoping @babel/plugin-transform-classes @babel/plugin-transform-computed-properties @babel/plugin-transform-destructuring @babel/plugin-transform-dotall-regex @babel/plugin-transform-duplicate-keys @babel/plugin-transform-exponentiation-operator @babel/plugin-transform-for-of @babel/plugin-transform-function-name @babel/plugin-transform-literals @babel/plugin-transform-modules-amd @babel/plugin-transform-modules-commonjs @babel/plugin-transform-modules-systemjs @babel/plugin-transform-modules-umd @babel/plugin-transform-new-target @babel/plugin-transform-object-super @babel/plugin-transform-parameters @babel/plugin-transform-regenerator @babel/plugin-transform-shorthand-properties @babel/plugin-transform-spread @babel/plugin-transform-sticky-regex @babel/plugin-transform-template-literals @babel/plugin-transform-typeof-symbol @babel/plugin-transform-unicode-regex @babel/preset-env @babel/template @babel/traverse @babel/types However, generated code is readable, not minified and contains some comments, perhaps not enough. So I think it's not a significant DFSG break. I won't package all of them so if we consider than using generated dist/* files is a policy break, I think that twitter-bootstrap4 can't be released in buster. Another crazy alternative: embeds that (4,8 Mo) ! I won't do it.
Bug#920858: [Pkg-javascript-devel] Bug#920858: twitter-bootstrap4: contains generated code not included as source
Quoting Xavier (2019-01-30 22:26:57) > Le 29/01/2019 à 22:17, Jonas Smedegaard a écrit : > > Source: twitter-bootstrap4 > > Version: 4.2.1+dfsg1-1 > > Severity: serious > > Justification: Policy 2.1 > > > > Source package contains below several files embedding code from > > external project fileOverview Kickass, without source included. > > > > Thanks to Xavier for noticing (although only as comment in copyright > > file). > > > > > > - Jonas > > I succeed to build source, but this needs: [snip] This bugreport tracks twitter-bootstrap4 violating Policy in shipping code without source. For discussing packaging of that source in a separate package, please file an ITP bugreport (or an RFP bugreport if you don't intent on doing the work yourself), and let's discuss packaging issues there. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#920858: twitter-bootstrap4: contains generated code not included as source
Source: twitter-bootstrap4 Version: 4.2.1+dfsg1-1 Severity: serious Justification: Policy 2.1 -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Source package contains below several files embedding code from external project fileOverview Kickass, without source included. Thanks to Xavier for noticing (although only as comment in copyright file). - Jonas -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAlxQws0ACgkQLHwxRsGg ASHW+A//ZeD9o9J69NnfOMBYLDRmX7LLSFrzcBpN9UUjIpjL0gcUuvzYBBVftXea LQKrAYwspymsSOaA9yUImVB3U812zsuZOLcB7wXOJcuMAEIRs1NM8+vkQM0n28Sp xu1WmADBmUKOoWpwstlwYwiTAr2T82Fb1zUSDgiw/zUiOZnVZZIGBN6ei9HJBKpx QwICTAuIVO1vovpGnrFNas4kbi0xvEQOUW5tFxo28R9gXSukEOEJWrU6EXjD4njb xc8mxH49774VL8lmKpo/vA+aWQ29xrw4uMT1uuSIY/0LP6nU/cpYh5OBSbSrDZxo BqLMpZIfx+sVhomP/sbCalKGJ8fsyl2bNn+nGXioXp5gTG1CUrDtHc8TT/3EI7z+ YN2tL5hnMeUvsI+sxeY0/SXB0Q5vHHPrR2FOmULdFVf52yAVivTjvyzrwOkAnTeR RTi+K866ayM9A6bkV3n5yVaOqa9DO/WIa20LApRCZ7QDz5IpkBNKvcz92ZlaZzpG iTy7pdxop+ynjp2bme493gdW4pxzuOw7M0OhK2h+8VX7gD9Yr9GcCozJoccHp28T SMTS6L4NgOEWAPWYicxWwYdRRAmE90PZx7QrJWmCna0OlZJIHhv70rfxGNIHdxkK j6uzLVcMq4X12klIh5BQlIXkGYMFJdn07Gi7AdO6KTT80Vyv8BM= =7bXE -END PGP SIGNATURE-
