Bug#920984: nextcloud-desktop: Client forgets credentials

[kaliko]

Thanks Sandro (and everyone involved) for your work on this :)

Cheers
k



signature.asc
Description: OpenPGP digital signature

Bug#920984: nextcloud-desktop: Client forgets credentials

[Sandro Knauß]

Hey,

I found now a workaround for the issue of not detecting credentials.

Just create this symlink:

ln -s /usr/lib/x86_64-linux-gnu/libsecret-1.so.0 
/usr/lib/x86_64-linux-gnu/libsecret-1.so

But please keep in mind, it is just a workaround - it may break you system 
later.

Otherwise I created a bug at libsecret: 922489 for folling a propper solution.

hefee

signature.asc
Description: This is a digitally signed message part.

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[Sandro Knauß]

Hey,

> Well I wondering if it is even requesting dbus.
> 
> For instance looking at the log with “ dbus-monitor
> "path=/org/freedesktop/secrets" ” I can see other applications requesting
> pwd from Seahorse (ie. polari irc client or Chromium), but launching
> nextcloud-desktop doesn't trigger any similar "method call".

well qtkeychain tries to detect once the backend and falls back to other if 
the backend does not answer. So you may have success if you first request a 
password via seahorse and than afterwards start nextcloud-client?



> Maybe the configure part in the build is failing to activate libsecret
> feature (just a bold guess as I've not look at the source yet)?

well the configure part in the build is quite simple: HAVE_LIBSECRET=1 if the 
lib is found and you see from the builts that this flag is set:
https://buildd.debian.org/status/fetch.php?
pkg=qtkeychain=arm64=0.9.1-1=1549301996=0

Here the entry points to the source. Maybe with more debug messages you find 
out what is going on there:

https://sources.debian.org/src/qtkeychain/0.9.0-2/keychain_unix.cpp/#L135
https://sources.debian.org/src/qtkeychain/0.9.0-2/libsecret.cpp/#L196

hefee

signature.asc
Description: This is a digitally signed message part.

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[kaliko]

Hi,

On 04/02/2019 17:48, Sandro Knauß wrote:>> I just tried, pbuilder with a buster 
image,
still fails to keep credentials
>> in Gnome pwd manager :|
>
> grmpf.
>
>
> Well the bugreport at qtkeychain may gives more insight. Maybe you also have
> to debug via dbus-monitor:
> https://github.com/frankosterfeld/qtkeychain/issues/114
>
Well I wondering if it is even requesting dbus.

For instance looking at the log with “ dbus-monitor 
"path=/org/freedesktop/secrets" ” I
can see other applications requesting pwd from Seahorse (ie. polari irc client 
or
Chromium), but launching nextcloud-desktop doesn't trigger any similar "method 
call".

Maybe the configure part in the build is failing to activate libsecret feature 
(just a
bold guess as I've not look at the source yet)?

Cheers
k



signature.asc
Description: OpenPGP digital signature

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[Sandro Knauß]

Hey kaliko,

> I just tried, pbuilder with a buster image, still fails to keep credentials
> in Gnome pwd manager :|

grmpf.

> I did not take time to investigate any further but building qtkeychain
> raises a warning from dpkg-shlibdeps:
> 
> 8<--
> package could avoid a useless dependency if debian/[…]/libqt5keychain.so.0.
> 9.1 was not linked against libsecret-1.so.0 (it uses none of the library's
> symbols)
> >8--

Well but is uses only the Dbus interface so far I know. That's why I may not 
consume any symbol from libsecret-1.

Well the bugreport at qtkeychain may gives more insight. Maybe you also have 
to debug via dbus-monitor:
https://github.com/frankosterfeld/qtkeychain/issues/114

hefee


signature.asc
Description: This is a digitally signed message part.

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[kaliko]

Sandro,

On 04/02/2019 15:38, Sandro Knauß wrote:
> My best guess that the root of the issue lies in qtkeychain. I saw that there 
> is a new qtkeychain 0.9.1 with a quite promising line in Changelog:
> https://github.com/frankosterfeld/qtkeychain/blob/master/ChangeLog#L6
> "Secret: Don't match the schema name #114 "
> 
> So build qtkeychain 0.9.1 and give that a try.

I just tried, pbuilder with a buster image, still fails to keep credentials in 
Gnome pwd
manager :|

I did not take time to investigate any further but building qtkeychain raises a 
warning
from dpkg-shlibdeps:

8<--
package could avoid a useless dependency if debian/[…]/libqt5keychain.so.0.
9.1 was not linked against libsecret-1.so.0 (it uses none of the library's 
symbols)
>8--

You can find packages (src & bin) here if somebody running Gnome is willing to 
reproduce
(please do I may have missed something):

http://media.kaliko.me/src/nextcloud/

Cheers
k



signature.asc
Description: OpenPGP digital signature

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[Sandro Knauß]

Hey kaliko,

> Can't confirm Thomas fix.

thanks for testing.

> I did force libsecret as a build dependency on nextcloud-desktop, but it did
> not solve the issue.
> 
> Anyway nextcloud-desktop already fetches libsecret with the current build
> (nextcloud-desktop build-dep on qt5keychain-dev → libqt5keychain1 →
> libsecret-1-0)
> 
> I also tried building nextcloud-desktop with a Build-dep on libsecret-1-dev
> as mentioned by Thomas in #909588 [0]
> 
> In both case I patched d/control and built from a clean chroot (pbuilder).
> 
> @Thomas, How did you build your client when you managed to fix this issue ?
> You probably fetch something else or setup a different build env when you
> did.

My best guess that the root of the issue lies in qtkeychain. I saw that there 
is a new qtkeychain 0.9.1 with a quite promising line in Changelog:
https://github.com/frankosterfeld/qtkeychain/blob/master/ChangeLog#L6
"Secret: Don't match the schema name #114 "

So build qtkeychain 0.9.1 and give that a try.

hefee

signature.asc
Description: This is a digitally signed message part.

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[kaliko]

Hi Sandro,

On 04/02/2019 12:05, Sandro Knauß wrote:
>> I can confirm this with XFCE. That is the same issue I filed against the
>> owncloud-client.
>> Building the package with libsecret installed, solved it. I know, there is
>> no dependency
>> on libsecret, but it worked.
> 
> I don't understand why this should help:
> 1. libsecret-1-0 and libsecret-common are already available at build time 
> see, 
> so your solution does not help:
> https://buildd.debian.org/status/fetch.php?pkg=nextcloud-desktop=i386=2.5.1-1=1548676710=0

Can't confirm Thomas fix.

I did force libsecret as a build dependency on nextcloud-desktop, but it did 
not solve
the issue.

Anyway nextcloud-desktop already fetches libsecret with the current build
(nextcloud-desktop build-dep on qt5keychain-dev → libqt5keychain1 → 
libsecret-1-0)

I also tried building nextcloud-desktop with a Build-dep on libsecret-1-dev as 
mentioned
by Thomas in #909588 [0]

In both case I patched d/control and built from a clean chroot (pbuilder).

@Thomas, How did you build your client when you managed to fix this issue ?
You probably fetch something else or setup a different build env when you did.

[0] https://bugs.debian.org/909588



signature.asc
Description: OpenPGP digital signature

Bug#920984: [Pkg-owncloud-maintainers] Bug#920984: nextcloud-desktop: Client forgets credentials

[Sandro Knauß]

Control: reassign -1 libqt5keychain1 0.9.0-2
Control: affects -1 nextcloud-desktop
Control: affects -1 owncloud-client

Hey,

> I can confirm this with XFCE. That is the same issue I filed against the
> owncloud-client.
> Building the package with libsecret installed, solved it. I know, there is
> no dependency
> on libsecret, but it worked.

I don't understand why this should help:
1. libsecret-1-0 and libsecret-common are already available at build time see, 
so your solution does not help:
https://buildd.debian.org/status/fetch.php?pkg=nextcloud-desktop=i386=2.5.1-1=1548676710=0

2. there is no dependency of libsecrect in nextcloud-destop nor owncloud-
client (for owncloud-client, there is a copy of qtkeyking in the sources, so 
you may triggered by your own build to use this one). But please beleave me, 
the whole logic is inside qtkeychain. 

hefee


signature.asc
Description: This is a digitally signed message part.

Bug#920984: nextcloud-desktop: Client forgets credentials

[Thomas Maaß]

Package: nextcloud-desktop
Version: 2.5.1-1
Followup-For: Bug #920984

I can confirm this with XFCE. That is the same issue I filed against the
owncloud-client.
Building the package with libsecret installed, solved it. I know, there is no
dependency
on libsecret, but it worked.

Regards
Thomas



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), 
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages nextcloud-desktop depends on:
ii  libc6 2.28-5
ii  libgcc1   1:8.2.0-15
ii  libnextcloudsync0 2.5.1-1
ii  libqt5concurrent5 5.11.3+dfsg-2
ii  libqt5core5a  5.11.3+dfsg-2
ii  libqt5dbus5   5.11.3+dfsg-2
ii  libqt5gui55.11.3+dfsg-2
ii  libqt5keychain1   0.9.0-2
ii  libqt5network55.11.3+dfsg-2
ii  libqt5positioning55.11.3+dfsg-2
ii  libqt5printsupport5   5.11.3+dfsg-2
ii  libqt5qml55.11.3-2
ii  libqt5quick5  5.11.3-2
ii  libqt5sql5-sqlite 5.11.3+dfsg-2
ii  libqt5webchannel5 5.11.3-2
ii  libqt5webenginecore5  5.11.3+dfsg-2+b1
ii  libqt5webenginewidgets5   5.11.3+dfsg-2+b1
ii  libqt5webkit5 5.212.0~alpha2-19
ii  libqt5widgets55.11.3+dfsg-2
ii  libqt5xml55.11.3+dfsg-2
ii  libsqlite3-0  3.26.0+fossilbc891ac6b-2
ii  libssl1.1 1.1.1a-1
ii  libstdc++68.2.0-15
ii  nextcloud-desktop-common  2.5.1-1
ii  nextcloud-desktop-l10n2.5.1-1
ii  zlib1g1:1.2.11.dfsg-1

Versions of packages nextcloud-desktop recommends:
ii  nextcloud-desktop-doc  2.5.1-1

nextcloud-desktop suggests no packages.

-- no debconf information

Bug#920984: nextcloud-desktop: Client forgets credentials

[kaliko]

Package: nextcloud-desktop
Version: 2.5.1-1
Severity: important
Tags: upstream

Hi,

On X session startup the client keeps asking for the password.

It looks like it fails to communicate with my password manager
(gnome/seahorse in my case).

The issue seems to be known upstream, since libgnome-keyring0 is
deprecated (and out of buster), upstream would need to use libsecret
instead.

https://github.com/nextcloud/desktop/issues/883
https://github.com/nextcloud/desktop/issues/427

By the way, thanks Sandro Knauß for working on these packages :)
Cheers
k


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages nextcloud-desktop depends on:
ii  libc6 2.28-5
ii  libgcc1   1:8.2.0-15
ii  libnextcloudsync0 2.5.1-1
ii  libqt5concurrent5 5.11.3+dfsg-2
ii  libqt5core5a  5.11.3+dfsg-2
ii  libqt5dbus5   5.11.3+dfsg-2
ii  libqt5gui55.11.3+dfsg-2
ii  libqt5keychain1   0.9.0-2
ii  libqt5network55.11.3+dfsg-2
ii  libqt5positioning55.11.3+dfsg-2
ii  libqt5printsupport5   5.11.3+dfsg-2
ii  libqt5qml55.11.3-2
ii  libqt5quick5  5.11.3-2
ii  libqt5sql5-sqlite 5.11.3+dfsg-2
ii  libqt5webchannel5 5.11.3-2
ii  libqt5webenginecore5  5.11.3+dfsg-2+b1
ii  libqt5webenginewidgets5   5.11.3+dfsg-2+b1
ii  libqt5webkit5 5.212.0~alpha2-19
ii  libqt5widgets55.11.3+dfsg-2
ii  libqt5xml55.11.3+dfsg-2
ii  libsqlite3-0  3.26.0+fossilbc891ac6b-2
ii  libssl1.1 1.1.1a-1
ii  libstdc++68.2.0-15
ii  nextcloud-desktop-common  2.5.1-1
ii  nextcloud-desktop-l10n2.5.1-1
ii  zlib1g1:1.2.11.dfsg-1

Versions of packages nextcloud-desktop recommends:
ii  nextcloud-desktop-doc  2.5.1-1

nextcloud-desktop suggests no packages.

-- no debconf information