Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Hello
On Sun, Apr 26, 2020 at 06:16:30PM +0200, Julien Cristau wrote:
Control: tag -1 confirmed
On Tue, Feb 05, 2019 at 12:56:50PM +0800, gustavo panizzo wrote:
hello
On Mon, Feb 04, 2019 at 05:05:25PM +0100, Bastian Blank wrote:
> On Mon, Feb 04, 2019 at 10:55:26PM +0800, gustavo panizzo wrote:
> > On Mon, Feb 04, 2019 at 09:59:06AM +, Adam D. Barratt wrote:
> > > Control: tags -1 + moreinfo
> > >
> > > On 2019-02-04 08:11, gustavo panizzo wrote:
> > > > I'd like to fix the bug #921186 in stable, only adding a dependency to
> > > > iptables-persistent the bug can be closed
> > >
> > > The metadata for that bug suggests that the bug also affects the package
> > > in unstable, and is not yet fixed there - is that correct? If so, please
> > > fix the bug in unstable first; if not, please fix the metadata.
> > I've fixed the metadata, thanks
>
> The bug is fixed differently in unstable?
>
After thinking on how I solved this issue in unstable (#794037,
#720110) I came up with another solution, similar to what's done in
unstable
Initially I didn't want to modify the scripts but the initial fix (add
kmod to deps) won't solve #720110 for the reporter, I think the current
proposed fix is better and the risk of regressions is low
debdiff attached
Looks OK, but:
diff -Nru iptables-persistent-1.0.4+nmu2/debian/changelog
iptables-persistent-1.0.4+nmu3/debian/changelog
--- iptables-persistent-1.0.4+nmu2/debian/changelog 2017-03-18
21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/debian/changelog 2019-02-03
19:18:27.0 +0800
@@ -1,3 +1,10 @@
+iptables-persistent (1.0.4+nmu3) stable; urgency=medium
Please make that "1.0.4+nmu2+deb9u1" and "stretch".
thanks, I've uploaded the package
Cheers,
Julien
+
+ * Non-maintainer upload
+ * Catch errors in calls to modprobe, thanks Hugo, Closes (#921186)
+
+ -- gustavo panizzo Sun, 03 Feb 2019 19:18:27 +0800
+
iptables-persistent (1.0.4+nmu2) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables
iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables
--- iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables 2017-03-18
21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables 2019-02-03
19:18:27.0 +0800
@@ -31,7 +31,7 @@
{
#save IPv4 rules
#need at least iptable_filter loaded:
- /sbin/modprobe -q iptable_filter
+ /sbin/modprobe -q iptable_filter || true
if [ ! -f /proc/net/ip_tables_names ]; then
echo "Warning: skipping IPv4 (no modules loaded)"
elif [ -x /sbin/iptables-save ]; then
diff -Nru iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables
iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables
--- iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables 2017-03-18
21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables 2019-02-03
19:18:27.0 +0800
@@ -31,7 +31,7 @@
{
#save IPv6 rules
#need at least ip6table_filter loaded:
- /sbin/modprobe -q ip6table_filter
+ /sbin/modprobe -q ip6table_filter || true
if [ ! -f /proc/net/ip6_tables_names ]; then
log_action_cont_msg "Warning: skipping IPv6 (no modules loaded)"
elif [ -x /sbin/ip6tables-save ]; then
--
IRC: gfa
GPG: 0x27263FA42553615F904A7EBE2A40A2ECB8DAD8D5
OLD GPG: 0x44BB1BA79F6C6333
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Control: tag -1 confirmed
On Tue, Feb 05, 2019 at 12:56:50PM +0800, gustavo panizzo wrote:
> hello
>
> On Mon, Feb 04, 2019 at 05:05:25PM +0100, Bastian Blank wrote:
> > On Mon, Feb 04, 2019 at 10:55:26PM +0800, gustavo panizzo wrote:
> > > On Mon, Feb 04, 2019 at 09:59:06AM +, Adam D. Barratt wrote:
> > > > Control: tags -1 + moreinfo
> > > >
> > > > On 2019-02-04 08:11, gustavo panizzo wrote:
> > > > > I'd like to fix the bug #921186 in stable, only adding a dependency to
> > > > > iptables-persistent the bug can be closed
> > > >
> > > > The metadata for that bug suggests that the bug also affects the package
> > > > in unstable, and is not yet fixed there - is that correct? If so, please
> > > > fix the bug in unstable first; if not, please fix the metadata.
> > > I've fixed the metadata, thanks
> >
> > The bug is fixed differently in unstable?
> >
>
> After thinking on how I solved this issue in unstable (#794037,
> #720110) I came up with another solution, similar to what's done in
> unstable
>
> Initially I didn't want to modify the scripts but the initial fix (add
> kmod to deps) won't solve #720110 for the reporter, I think the current
> proposed fix is better and the risk of regressions is low
>
> debdiff attached
>
Looks OK, but:
> diff -Nru iptables-persistent-1.0.4+nmu2/debian/changelog
> iptables-persistent-1.0.4+nmu3/debian/changelog
> --- iptables-persistent-1.0.4+nmu2/debian/changelog 2017-03-18
> 21:11:49.0 +0800
> +++ iptables-persistent-1.0.4+nmu3/debian/changelog 2019-02-03
> 19:18:27.0 +0800
> @@ -1,3 +1,10 @@
> +iptables-persistent (1.0.4+nmu3) stable; urgency=medium
Please make that "1.0.4+nmu2+deb9u1" and "stretch".
Cheers,
Julien
> +
> + * Non-maintainer upload
> + * Catch errors in calls to modprobe, thanks Hugo, Closes (#921186)
> +
> + -- gustavo panizzo Sun, 03 Feb 2019 19:18:27 +0800
> +
> iptables-persistent (1.0.4+nmu2) unstable; urgency=medium
>
>* Non-maintainer upload.
> diff -Nru iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables
> iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables
> --- iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables 2017-03-18
> 21:11:49.0 +0800
> +++ iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables 2019-02-03
> 19:18:27.0 +0800
> @@ -31,7 +31,7 @@
> {
> #save IPv4 rules
> #need at least iptable_filter loaded:
> - /sbin/modprobe -q iptable_filter
> + /sbin/modprobe -q iptable_filter || true
> if [ ! -f /proc/net/ip_tables_names ]; then
> echo "Warning: skipping IPv4 (no modules loaded)"
> elif [ -x /sbin/iptables-save ]; then
> diff -Nru iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables
> iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables
> --- iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables 2017-03-18
> 21:11:49.0 +0800
> +++ iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables 2019-02-03
> 19:18:27.0 +0800
> @@ -31,7 +31,7 @@
> {
> #save IPv6 rules
> #need at least ip6table_filter loaded:
> - /sbin/modprobe -q ip6table_filter
> + /sbin/modprobe -q ip6table_filter || true
> if [ ! -f /proc/net/ip6_tables_names ]; then
> log_action_cont_msg "Warning: skipping IPv6 (no modules loaded)"
> elif [ -x /sbin/ip6tables-save ]; then
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Hi On Wed, Mar 13, 2019 at 11:10:34AM +, Adam D. Barratt wrote: On 2019-03-13 11:04, gustavo panizzo wrote: Hi release team any update on this? can I have this for the next point release or before the distribution is archived? Sarcasm really isn't necessary here, and doesn't help encourage people to deal with your request. Sorry if it came as sarcasm, it wasn't my intention at all. really. I would like to have this update before stretch moves to oldstable, that's what I meant. Apologies for the poor wording. (I assume that was your intent, given "before the distribution is archived", as that won't be for at least another few years.) Regards, Adam -- IRC: gfa GPG: 0X44BB1BA79F6C6333
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
On 2019-03-13 11:04, gustavo panizzo wrote: Hi release team any update on this? can I have this for the next point release or before the distribution is archived? Sarcasm really isn't necessary here, and doesn't help encourage people to deal with your request. (I assume that was your intent, given "before the distribution is archived", as that won't be for at least another few years.) Regards, Adam
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Hi release team any update on this? can I have this for the next point release or before the distribution is archived? thanks! -- IRC: gfa GPG: 0X44BB1BA79F6C6333
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
hello
On Mon, Feb 04, 2019 at 05:05:25PM +0100, Bastian Blank wrote:
On Mon, Feb 04, 2019 at 10:55:26PM +0800, gustavo panizzo wrote:
On Mon, Feb 04, 2019 at 09:59:06AM +, Adam D. Barratt wrote:
> Control: tags -1 + moreinfo
>
> On 2019-02-04 08:11, gustavo panizzo wrote:
> > I'd like to fix the bug #921186 in stable, only adding a dependency to
> > iptables-persistent the bug can be closed
>
> The metadata for that bug suggests that the bug also affects the package
> in unstable, and is not yet fixed there - is that correct? If so, please
> fix the bug in unstable first; if not, please fix the metadata.
I've fixed the metadata, thanks
The bug is fixed differently in unstable?
After thinking on how I solved this issue in unstable (#794037,
#720110) I came up with another solution, similar to what's done in
unstable
Initially I didn't want to modify the scripts but the initial fix (add
kmod to deps) won't solve #720110 for the reporter, I think the current
proposed fix is better and the risk of regressions is low
debdiff attached
--
IRC: gfa
GPG: 0X44BB1BA79F6C6333
diff -Nru iptables-persistent-1.0.4+nmu2/debian/changelog iptables-persistent-1.0.4+nmu3/debian/changelog
--- iptables-persistent-1.0.4+nmu2/debian/changelog 2017-03-18 21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/debian/changelog 2019-02-03 19:18:27.0 +0800
@@ -1,3 +1,10 @@
+iptables-persistent (1.0.4+nmu3) stable; urgency=medium
+
+ * Non-maintainer upload
+ * Catch errors in calls to modprobe, thanks Hugo, Closes (#921186)
+
+ -- gustavo panizzo Sun, 03 Feb 2019 19:18:27 +0800
+
iptables-persistent (1.0.4+nmu2) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables
--- iptables-persistent-1.0.4+nmu2/plugins/15-ip4tables 2017-03-18 21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/plugins/15-ip4tables 2019-02-03 19:18:27.0 +0800
@@ -31,7 +31,7 @@
{
#save IPv4 rules
#need at least iptable_filter loaded:
- /sbin/modprobe -q iptable_filter
+ /sbin/modprobe -q iptable_filter || true
if [ ! -f /proc/net/ip_tables_names ]; then
echo "Warning: skipping IPv4 (no modules loaded)"
elif [ -x /sbin/iptables-save ]; then
diff -Nru iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables
--- iptables-persistent-1.0.4+nmu2/plugins/25-ip6tables 2017-03-18 21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/plugins/25-ip6tables 2019-02-03 19:18:27.0 +0800
@@ -31,7 +31,7 @@
{
#save IPv6 rules
#need at least ip6table_filter loaded:
- /sbin/modprobe -q ip6table_filter
+ /sbin/modprobe -q ip6table_filter || true
if [ ! -f /proc/net/ip6_tables_names ]; then
log_action_cont_msg "Warning: skipping IPv6 (no modules loaded)"
elif [ -x /sbin/ip6tables-save ]; then
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
On Mon, Feb 04, 2019 at 10:55:26PM +0800, gustavo panizzo wrote: > On Mon, Feb 04, 2019 at 09:59:06AM +, Adam D. Barratt wrote: > > Control: tags -1 + moreinfo > > > > On 2019-02-04 08:11, gustavo panizzo wrote: > > > I'd like to fix the bug #921186 in stable, only adding a dependency to > > > iptables-persistent the bug can be closed > > > > The metadata for that bug suggests that the bug also affects the package > > in unstable, and is not yet fixed there - is that correct? If so, please > > fix the bug in unstable first; if not, please fix the metadata. > I've fixed the metadata, thanks The bug is fixed differently in unstable? Bastian -- To live is always desirable. -- Eleen the Capellan, "Friday's Child", stardate 3498.9
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Hi On Mon, Feb 04, 2019 at 09:59:06AM +, Adam D. Barratt wrote: Control: tags -1 + moreinfo On 2019-02-04 08:11, gustavo panizzo wrote: I'd like to fix the bug #921186 in stable, only adding a dependency to iptables-persistent the bug can be closed The metadata for that bug suggests that the bug also affects the package in unstable, and is not yet fixed there - is that correct? If so, please fix the bug in unstable first; if not, please fix the metadata. I've fixed the metadata, thanks Regards, Adam -- IRC: gfa GPG: 0X44BB1BA79F6C6333
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Control: tags -1 + moreinfo On 2019-02-04 08:11, gustavo panizzo wrote: I'd like to fix the bug #921186 in stable, only adding a dependency to iptables-persistent the bug can be closed The metadata for that bug suggests that the bug also affects the package in unstable, and is not yet fixed there - is that correct? If so, please fix the bug in unstable first; if not, please fix the metadata. Regards, Adam
Bug#921319: stretch-pu: package iptables-persistent/1.0.4+nmu2
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu
Hello release team
I'd like to fix the bug #921186 in stable, only adding a dependency to
iptables-persistent the bug can be closed
debdiff attached
thanks!
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable')
Architecture: arm64 (aarch64)
Kernel: Linux 4.19.0-1-arm64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8), LANGUAGE=en_US (charmap=UTF-8) (ignored: LC_ALL set to
en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru iptables-persistent-1.0.4+nmu2/debian/changelog
iptables-persistent-1.0.4+nmu3/debian/changelog
--- iptables-persistent-1.0.4+nmu2/debian/changelog 2017-03-18
21:11:49.0 +0800
+++ iptables-persistent-1.0.4+nmu3/debian/changelog 2019-02-03
19:18:27.0 +0800
@@ -1,3 +1,11 @@
+iptables-persistent (1.0.4+nmu3) stable; urgency=medium
+
+ * Non-maintainer upload
+ * Depend on kmod as /sbin/modprobe is called unconditionally
+Thanks Hugo, Closes (#921186)
+
+ -- gustavo panizzo Sun, 03 Feb 2019 19:18:27 +0800
+
iptables-persistent (1.0.4+nmu2) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru iptables-persistent-1.0.4+nmu2/debian/control
iptables-persistent-1.0.4+nmu3/debian/control
--- iptables-persistent-1.0.4+nmu2/debian/control 2017-03-17
12:50:20.0 +0800
+++ iptables-persistent-1.0.4+nmu3/debian/control 2019-02-03
19:18:17.0 +0800
@@ -21,7 +21,7 @@
Package: iptables-persistent
Architecture: all
-Depends: netfilter-persistent (= ${source:Version}), iptables, ${misc:Depends}
+Depends: netfilter-persistent (= ${source:Version}), iptables, kmod,
${misc:Depends}
Description: boot-time loader for netfilter rules, iptables plugin
netfilter-persistent is a loader for netfilter configuration using a
plugin-based architecture.
