Bug#921376: frr: missing Breaks+Replaces

2019-02-04 Thread Andreas Beckmann 
Hi David,

On 2019-02-04 22:01, David Lamparter wrote:
> I've added Conflicts: lines, as that seemed to be the most conservative
> option to me.  ("Replaces: quagga" is a 'layer 9' discussion that I
> think it's a bit early to have at this point.)
> 
> If you have any comments/opinions/input, I'd appreciate that.

Looks good to me. You can reconsider the Breaks+Replaces once you
implement whatever conclusion such a 'layer 9' discussion has reached.

I'll come back to you in case you missed to Conflicts: some package :-)

Andreas

Bug#921376: frr: missing Breaks+Replaces

2019-02-04 Thread David Lamparter 
Hi Andreas,


I've added Conflicts: lines, as that seemed to be the most conservative
option to me.  ("Replaces: quagga" is a 'layer 9' discussion that I
think it's a bit early to have at this point.)

If you have any comments/opinions/input, I'd appreciate that.
Diff is at:
https://github.com/FRRouting/frr/commit/7ad413ce0ff5295fbbab840be533b3eb112c0dc8

Cheers,


-David

Bug#921376: frr: missing Breaks+Replaces

2019-02-04 Thread David Lamparter 
Hi Andreas,


Thanks for the report!

On Mon, Feb 04, 2019 at 07:26:59PM +0100, Andreas Beckmann wrote:
> if I understood the changelog entry correctly, frr is a successor to
> quagga. There are a lot of Breaks+Replaces missing for taking over files
> owned by quagga-*:

FRR is indeed a (the?) successor to quagga.  I wasn't sure whether it is
appropriate to use "Replaces:" and had only put a "Conflicts: quagga" on
the frr binary package.  Got fooled by simply copying the quagga/zebra
conflict :/.

Also, it's currently a "Conflicts:" since I followed Debian policy 7.4
"Conflicts should be used when two packages provide the same file and
will continue to do so, [...]".  I guess if a "Replaces:" is
appropriate, the "Conflicts:" should be a "Breaks:" instead?

> frr-doc=6.0.2-1 has file conflicts in sid with
>   - quagga-doc=1.2.4-3

I was about to say this shouldn't be the case, then I noticed they
install the same .png files in /usr/share/info :( - adding Conflicts.
(I'll look into possibly fixing the conflict at a later point - need to
dive into texinfo for that one.)

> frr=6.0.2-1 has file conflicts in sid with
>   - quagga-bgpd=1.2.4-3
>   - quagga-core=1.2.4-3
>   - quagga-isisd=1.2.4-3
>   - quagga-ospf6d=1.2.4-3
>   - quagga-ospfd=1.2.4-3
>   - quagga-pimd=1.2.4-3
>   - quagga-ripd=1.2.4-3
>   - quagga-ripngd=1.2.4-3
>
> There is also a conflict of frr=6.0.2-1 with pimd=2.3.2-2 over the file
> 
>   usr/share/man/man8/pimd.8.gz

Indeed all of those should be Conflicts/Breaks.  (Although I suppose we
could rename the man pages to "frr-.8"?  The daemons are
installed "private" under /usr/lib/frr... but then it's confusing if a
user gets a man page for another daemon...)

Cheers,


-David

Bug#921376: frr: missing Breaks+Replaces

2019-02-04 Thread Andreas Beckmann 
Source: frr
Version: 6.0.2-1
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts  

 

Hi,

if I understood the changelog entry correctly, frr is a successor to
quagga. There are a lot of Breaks+Replaces missing for taking over files
owned by quagga-*:

frr-doc=6.0.2-1 has file conflicts in sid with
  - quagga-doc=1.2.4-3

frr=6.0.2-1 has file conflicts in sid with
  - quagga-bgpd=1.2.4-3
  - quagga-core=1.2.4-3
  - quagga-isisd=1.2.4-3
  - quagga-ospf6d=1.2.4-3
  - quagga-ospfd=1.2.4-3
  - quagga-pimd=1.2.4-3
  - quagga-ripd=1.2.4-3
  - quagga-ripngd=1.2.4-3

There is also a conflict of frr=6.0.2-1 with pimd=2.3.2-2 over the file

  usr/share/man/man8/pimd.8.gz



Andreas