Bug#925221: [Pkg-freeipa-devel] Bug#925221: python3-lib389: Instance removal fails due to hard-coded path

2019-03-21 Thread Jörg Behrmann 
On Thu, Mar 21, 2019 at 03:29:00PM +0200, Timo Aaltonen wrote:
> Thanks a lot for sending it upstream. I wonder if it should/could be
> pushed for buster too.
> 

I got an answer from upstream and for the 1.4.1.X release cycle they revamped
that part of the code [1], since lib389 was merged into 389-ds-base and I was
looking at the old lib389 repo. I will need to see, whether this fixes the
issue, but I already noted, that they still hardcode /etc/sysconfig there at one
point.

For the 1.4.0.X releases it would then make sense to push this for buster, since
otherwise instances cannot be deleted with dsctl.

[1] https://pagure.io/389-ds-base/issue/50208


signature.asc
Description: PGP signature

Bug#925221: [Pkg-freeipa-devel] Bug#925221: python3-lib389: Instance removal fails due to hard-coded path

2019-03-21 Thread Timo Aaltonen 
On 21.3.2019 14.25, Jörg Behrmann wrote:
> Package: python3-lib389
> Version: 1.4.0.21-1
> Severity: normal
> Tags: patch upstream
> 
> Running "dsctil  remove --do-it" or "dsctl --remove-all" fail fails
> in lib389/instance/remove.py:remove_ds_instance when asserting the existence
> of its marker file, which on RH systems is in 
> /etc/sysconfig/dirsrv-,
> but in Debian is in /etc/default/dirsrv-. Unfortunately this path
> is hard-coded.
> 
> A patch is attached and will be submitted upstream.

Thanks a lot for sending it upstream. I wonder if it should/could be
pushed for buster too.


-- 
t

Bug#925221: python3-lib389: Instance removal fails due to hard-coded path

2019-03-21 Thread Jörg Behrmann 
Package: python3-lib389
Version: 1.4.0.21-1
Severity: normal
Tags: patch upstream

Running "dsctil  remove --do-it" or "dsctl --remove-all" fail fails
in lib389/instance/remove.py:remove_ds_instance when asserting the existence
of its marker file, which on RH systems is in /etc/sysconfig/dirsrv-,
but in Debian is in /etc/default/dirsrv-. Unfortunately this path
is hard-coded.

A patch is attached and will be submitted upstream.

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages python3-lib389 depends on:
ii  python3   3.7.2-1
ii  python3-argcomplete   1.8.1-1
ii  python3-argparse-manpage  1.1-1
ii  python3-dateutil  2.7.3-3
ii  python3-ldap  3.1.0-2
ii  python3-pyasn10.4.2-3
ii  python3-pyasn1-modules0.2.1-0.2
ii  python3-pytest3.10.1-2
ii  python3-six   1.12.0-1

python3-lib389 recommends no packages.

python3-lib389 suggests no packages.

-- no debconf information
--- remove.py   2019-03-21 11:37:29.093572057 +0100
+++ remove.py.fixed 2019-03-21 11:36:23.389675946 +0100
@@ -39,7 +39,7 @@
 remove_paths['tmpfiles_d'] = dirsrv.ds_paths.tmpfiles_d + "/dirsrv-" + 
dirsrv.serverid + ".conf"
 remove_paths['inst_dir'] = dirsrv.ds_paths.inst_dir
 
-marker_path = "%s/sysconfig/dirsrv-%s" % (dirsrv.ds_paths.sysconf_dir, 
dirsrv.serverid)
+marker_path = "%s/dirsrv-%s" % (dirsrv.ds_paths.initconfig_dir, 
dirsrv.serverid)
 etc_dirsrv_path = os.path.join(dirsrv.ds_paths.sysconf_dir, 'dirsrv/')
 ssca_path = os.path.join(etc_dirsrv_path, 'ssca/')