Bug#925498: Subject: Re: Bug#925498: afterstep: v2.2.12-12 FTBFS due to patch#57 generates libAfterImage/Makefile incorrectly.

2019-04-06 Thread Chris Hofstaedtler
Control: tags -1 + moreinfo
Control: severity -1 normal

* Jim Turner  [190406 15:00]:
> > The configure script is regenerated
> > during the build process, so there
> > is no need to change it via a patch.
> 
> I was wondering a/b that, but it DOESN'T rebuild configure for me???!!!, 
> after running make clean; ./configure ...?!  What am I doing wrong?
> (I simply did:  $>apt-get source afterstep; which applied all 57 patches, cd 
> to it, did $>make clean; $>./configure...; $>make...)  There was no 
> autogen.sh or anything like that.

At the Salzburg BSP I've given rebuilding afterstep 2.2.12-12 with
the official Debian build methods a try, and it builds fine for me
on amd64.
Lowering severity because of this.

Cheers,
Chris



Bug#925498: afterstep: v2.2.12-12 FTBFS due to patch#57 generates libAfterImage/Makefile incorrectly.

2019-03-26 Thread Robert Luberda
Jim Turner pisze:

Hi,

> truetype fonts, and instead use pkg-config.  Problem is that the patch
> properly removes it from configure.in, but NOT from configure itself

The configure script is regenerated during the build process, so there
is no need to change it via a patch.

> I simply untacked the latest source package v2.2.12-12 from Debian Testing
> (http://ftp.gr.debian.org/debian/) on March 25, 2019, ran:
> 
> ./configure
> make


This is not a proper way to build Debian packages. Use 'quilt push -a &&
debian/rules binary' or tools like dpkg-buildpackage or debuild instead.


Regards,
robert



Bug#925498: afterstep: v2.2.12-12 FTBFS due to patch#57 generates libAfterImage/Makefile incorrectly.

2019-03-25 Thread Jim Turner
Package: afterstep
Version: 2.2.12-12
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

Bug is actually against the latest Debian maintainer patch (patch#57)
by Robert Luberda , 30-Aug, 2018; which causes a FTBFS:

Issue 1:  (FTBFS) due to an extraneous, "@TTF_CFLAGS@" variable
appended to line 107 ("NCS_EXTRA=...") of libAfterImage/Makefile.in, which
is unreplaced in the generated Makefile, causing compile failure.

Issue 2:  The purpose of patch#57 was to remove the now-depreciated (and
now non-existing) "freetype-config" function once used to configure
truetype fonts, and instead use pkg-config.  Problem is that the patch
properly removes it from configure.in, but NOT from configure itself
causing "--with-ttf" to no longer work (effectively always "no").

I simply untacked the latest source package v2.2.12-12 from Debian Testing
(http://ftp.gr.debian.org/debian/) on March 25, 2019, ran:

./configure
make

and it fails to compile;
...
gcc -O3 -DNO_DEBUG_OUTPUT -fPIC  -c xwrap.c
/bin/rm -f libAfterBase.a
ar clq libAfterBase.a ashash.o aslist.o asvector.o audit.o fs.o layout.o
mystri$
ranlib libAfterBase.a
make[1]: Leaving directory '/tmp/pristine/afterstep-2.2.12/libAfterBase'
make[1]: Entering directory '/tmp/pristine/afterstep-2.2.12/libAfterImage'
 asimage.c
 gcc -O3 -DNO_DEBUG_OUTPUT -fPIC  -mmmx -Winline --param inline-unit-
growth=100$
 gcc: error: TTF_CFLAGS@: No such file or directory
 make[1]: *** [Makefile:381: asimage.o] Error 1
 make[1]: Leaving directory '/tmp/pristine/afterstep-2.2.12/libAfterImage'
 make: *** [Makefile:177: all] Error 1

 I was successful in building afterstep after applying the following patch
 I created to correct both these issues, please consider, and edit as
 necessary for a new "patch#58" to resolve these two issues.

 Thanks,

Jim Turner



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0-3.1-liquorix-amd64 (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_US.iso88591, LC_CTYPE=en_US.iso88591 (charmap=ISO-8859-1), 
LANGUAGE=en_US.iso88591 (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages afterstep depends on:
ii  afterstep-data  2.2.12-12
ii  aterm   9.22-6
ii  imagemagick 8:6.9.10.23+dfsg-2
ii  imagemagick-6.q16 [imagemagick] 8:6.9.10.23+dfsg-2
ii  libafterimage0  2.2.12-12
ii  libafterstep1   2.2.12-12
ii  libc6   2.28-8
ii  libdbus-1-3 1.12.12-1.0nosystemd1
ii  libglib2.0-02.58.3-1
ii  libgtk2.0-0 2.24.32-3
ii  libreadline77.0-5
ii  libx11-62:1.6.7-1
ii  libxext62:1.3.3-1+b2
ii  lxterminal [x-terminal-emulator]0.3.2-1
ii  menu2.1.47
ii  menu-xdg0.6
ii  perl5.28.1-4
ii  roxterm-gtk3 [x-terminal-emulator]  2.9.5-1
ii  rxvt-unicode [x-terminal-emulator]  9.22-6
ii  sensible-utils  0.0.12
ii  ucf 3.0038+nmu1

Versions of packages afterstep recommends:
ii  gnome-themes-extra  3.28-1

Versions of packages afterstep suggests:
pn  asmail
ii  asmon 0.71-5.1+b1
ii  mc3:4.8.22-1
pn  wmcpuload 
ii  wmitime   0.5-2+b1
ii  xscreensaver  5.42+dfsg1-1

-- no debconf information
diff libAfterImage/configure libAfterImage/configure.NEW
index bc74bfe..9995dda 100755
--- libAfterImage/configure
+++ libAfterImage/configure.NEW
@@ -6443,210 +6443,257 @@ AFTERIMAGE_LIBS="$AFTERIMAGE_LIBS -lm"
 
 
 TTF_INCLUDES=
+have_ttf=
+if test "$with_ttf" = no; then
+   have_ttf=disabled
+else
+   if test -z "$PKG_CONFIG"; then
+   # Extract the first word of "pkg-config", so it can be a 
program name with args.
+set dummy pkg-config; ac_word=$2
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
+$as_echo_n "checking for $ac_word... " >&6; }
+if ${ac_cv_path_PKG_CONFIG+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  case $PKG_CONFIG in
+  [\\/]* | ?:[\\/]*)
+  ac_cv_path_PKG_CONFIG="$PKG_CONFIG" # Let the user override the test with a 
path.
+  ;;
+  *)
+  as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
+for as_dir in $PATH
+do
+  IFS=$as_save_IFS
+  test -z "$as_dir" && as_dir=.
+for ac_exec_ext in '' $ac_executable_extensions; do
+  if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x 
"$as_dir/$ac_word$ac_exec_ext"; }; then
+ac_cv_path_PKG_CONFIG="$as_dir/$ac_word$ac_exec_ext"
+$as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" 
>&5
+break 2
+