Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
Le 27/03/2019 à 12:41, Andrej Shadura a écrit : > I’m not entirely sure it is possible. But maybe someone else is going to > have better luck removing openhft dependencies. I'll get a look during the Paris BSP on sunday. Emmanuel Bourg
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Wed, Mar 27, 2019 at 12:37:17PM +0100, Andrej Shadura wrote: > > (srly? Using dh -N instead of removing the packages from d/control?!…). > > Yes, so that it’s easier to bring them back when they’re unbroken. But that doesn't help anything. You removed two packages because a dependency of them was RC buggy, making other packages uninstallable because of this. > > Anyway, this also wasn't mentioned in the changelog... > > It was, indirectly: > > * Disable jasperreports support since it is RC-buggy. > * Don’t build against libreactor-core-java since it depends on RC- > buggy openhft. We are in freeze, changelogs are read by people who don't always know what this thing is. Reading that I would never suspect that binaries packages have been removed; please try to be more explicit and lengthy in your changelogs. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Tue, 26 Mar 2019 15:27:38 +0100 Emmanuel Bourg wrote:> I think this was done to remove the openhft packages that are > incompatible with Java 11. But maybe the affected Spring modules could > be salvaged by disabling the code using openhft (if it's optional). I’m not entirely sure it is possible. But maybe someone else is going to have better luck removing openhft dependencies. -- Cheers, Andrej
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Tue, 26 Mar 2019 16:35:41 -0700 tony mancill wrote:
> Regarding the OpenHFT, I tried to help the overall situation by
> uploading new versions to experimental several months back but as was
> discussed on the list (I'd have to find the link), was requested to
> hold-off on transitioning them into unstable.
I tried completing that work, but unfortunately I ran into a compiler
bug in openhft-chronicle-wire:
[INFO] Compiling 107 source files to
/tmp/openhft-chronicle-wire/openhft-chronicle-wire/target/classes
compiler message file broken: key=compiler.misc.msg.bug
arguments=11.0.2, {1}, {2}, {3}, {4}, {5}, {6}, {7}
java.lang.AssertionError: exception_index is not set
at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:162)
at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:95)
at
jdk.compiler/com.sun.tools.javac.code.TypeAnnotationPosition.getExceptionIndex(TypeAnnotationPosition.java:307)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writePosition(ClassWriter.java:908)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeTypeAnnotation(ClassWriter.java:879)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeTypeAnnotations(ClassWriter.java:793)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeCode(ClassWriter.java:1352)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeMethod(ClassWriter.java:1220)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeMethods(ClassWriter.java:1715)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeClassFile(ClassWriter.java:1825)
at
jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeClass(ClassWriter.java:1741)
at
jdk.compiler/com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:757)
at
jdk.compiler/com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1635)
at
jdk.compiler/com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1603)
at
jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
at
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
at
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at
org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
at
org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:176)
at
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1129)
at
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:188)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:181)
at org.debian.maven.Wrapper.main(Wrapper.java:89)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchStandard(Launcher.java:330)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:238)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Wed, 27 Mar 2019 12:01:40 +0100 Mattia Rizzolo wrote: > On Tue, Mar 26, 2019 at 04:35:41PM -0700, tony mancill wrote: > > Are you sure about the upload of 4.3.22-2 changing the number of binary > > packages built? If that is the case, it was completely unintentional. > > Meh, apparently nope, I was tricked by that dpkg change in the Binary > field... I had only looked at the uploaded .changes, forgetting it > doesn't list anymore all the produced binaries… > > Sorry for inappropriately pointing at you. > > So, this was instead caused by Andrej's -3 upload, that has > > --- libspring-java-4.3.22/debian/rules 2019-03-04 05:35:23.0 +0100 > +++ libspring-java-4.3.22/debian/rules 2019-03-09 15:46:25.0 +0100 > @@ -5,15 +5,18 @@ > > JAVA_HOME := /usr/lib/jvm/default-java > > -MODULES = aop beans context context-support core expression instrument jdbc > jms messaging orm oxm test tx web webmvc webmvc-portlet > +# MODULES = aop beans context context-support core expression instrument > jdbc jms messaging orm oxm test tx web webmvc webmvc-portlet > +MODULES = aop beans context context-support core expression instrument jdbc > orm oxm test tx web webmvc webmvc-portlet > > %: > - dh $@ --buildsystem=gradle > + dh $@ --buildsystem=gradle -Nlibspring-messaging-java > -Nlibspring-jms-java > > override_dh_auto_build: > dh_auto_build -- jar -x test -x check \ > -x :spring-orm-hibernate4:compileJava \ > -x :spring-orm-hibernate5:compileJava \ > +-x :spring-jms:compileJava \ > +-x :spring-messaging:compileJava \ > -x :spring-instrument-tomcat:compileJava \ > -x :spring-webmvc-tiles2:compileJava \ > -x :spring-websocket:compileJava > > > (srly? Using dh -N instead of removing the packages from d/control?!…). Yes, so that it’s easier to bring them back when they’re unbroken. > Anyway, this also wasn't mentioned in the changelog... It was, indirectly: * Disable jasperreports support since it is RC-buggy. * Don’t build against libreactor-core-java since it depends on RC- buggy openhft. -- Cheers, Andrej
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Tue, Mar 26, 2019 at 04:35:41PM -0700, tony mancill wrote: > Are you sure about the upload of 4.3.22-2 changing the number of binary > packages built? If that is the case, it was completely unintentional. Meh, apparently nope, I was tricked by that dpkg change in the Binary field... I had only looked at the uploaded .changes, forgetting it doesn't list anymore all the produced binaries… Sorry for inappropriately pointing at you. So, this was instead caused by Andrej's -3 upload, that has --- libspring-java-4.3.22/debian/rules 2019-03-04 05:35:23.0 +0100 +++ libspring-java-4.3.22/debian/rules 2019-03-09 15:46:25.0 +0100 @@ -5,15 +5,18 @@ JAVA_HOME := /usr/lib/jvm/default-java -MODULES = aop beans context context-support core expression instrument jdbc jms messaging orm oxm test tx web webmvc webmvc-portlet +# MODULES = aop beans context context-support core expression instrument jdbc jms messaging orm oxm test tx web webmvc webmvc-portlet +MODULES = aop beans context context-support core expression instrument jdbc orm oxm test tx web webmvc webmvc-portlet %: - dh $@ --buildsystem=gradle + dh $@ --buildsystem=gradle -Nlibspring-messaging-java -Nlibspring-jms-java override_dh_auto_build: dh_auto_build -- jar -x test -x check \ -x :spring-orm-hibernate4:compileJava \ -x :spring-orm-hibernate5:compileJava \ +-x :spring-jms:compileJava \ +-x :spring-messaging:compileJava \ -x :spring-instrument-tomcat:compileJava \ -x :spring-webmvc-tiles2:compileJava \ -x :spring-websocket:compileJava (srly? Using dh -N instead of removing the packages from d/control?!…). Anyway, this also wasn't mentioned in the changelog... -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Tue, Mar 26, 2019 at 02:46:35PM +0100, Mattia Rizzolo wrote:
> Source: libspring-java
> Version: 4.3.22-2
> Severity: serious
> X-Debbugs-Cc: tony mancill
> Control: block 925390 924635 924634 by -1
>
> Dear maintainer (and tony, whose upload 4.3.22-2 caused this bug),
>
> your package libspring-java suddenly stopped building two binaries that
> were actively used by other packages, like activemq.
>
> What's very worse, the changelog doesn't mention any reason for doing
> so.
Hi Mattia,
Are you sure about the upload of 4.3.22-2 changing the number of binary
packages built? If that is the case, it was completely unintentional.
I compared the package I uploaded to a clean chroot build of the
previous version *before* I uploaded it on March 3rd:
/data/debian/sponsor/libspring-java/build-area$ ls -al *deb | grep 4.3.22-2 |
wc -l
17
/data/debian/sponsor/libspring-java/build-area$ ls -al *deb | grep 4.3.22-1 |
wc -l
17
The full debdiff for that upload is attached.
Regarding the OpenHFT, I tried to help the overall situation by
uploading new versions to experimental several months back but as was
discussed on the list (I'd have to find the link), was requested to
hold-off on transitioning them into unstable.
Thanks,
tony
diff --git a/debian/changelog b/debian/changelog
index a416f6ad..8a133409 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,17 @@
+libspring-java (4.3.22-2) unstable; urgency=medium
+
+ * Team upload.
+ * Update dependency on aspectj to be versioned (>= 1.9.2)
+Thank you to Matthias Klose for the bug report. (Closes: #923554)
+ * Update Homepage URL in debian/control to use https
+ * Update Source URL in debian/copyright
+ * Freshen debian/copyright year for upstream
+ * Add a patch to use SOURCE_DATE_EPOCH to compute the copyright year
+that appears in JAR files META-INF. This should help with build
+reproducibility.
+
+ -- tony mancill Sun, 03 Mar 2019 20:35:23 -0800
+
libspring-java (4.3.22-1) unstable; urgency=medium
* Team upload.
diff --git a/debian/control b/debian/control
index 838cb945..736eaa53 100644
--- a/debian/control
+++ b/debian/control
@@ -16,7 +16,7 @@ Build-Depends-Indep: bsh,
libactivation-java,
libapache-poi-java (>= 4.0),
libasm-java (>= 5.0),
- libaspectj-java,
+ libaspectj-java (>= 1.9.2),
libatinject-jsr330-api-java,
libc3p0-java,
libcastor-xml-java,
@@ -95,7 +95,7 @@ Build-Depends-Indep: bsh,
Standards-Version: 4.3.0
Vcs-Git: https://salsa.debian.org/java-team/libspring-java.git
Vcs-Browser: https://salsa.debian.org/java-team/libspring-java
-Homepage: http://spring.io/projects/spring-framework
+Homepage: https://spring.io/projects/spring-framework
Package: libspring-core-java
Architecture: all
@@ -104,7 +104,7 @@ Depends: libactivation-java,
libcommons-logging-java,
libjaxb-api-java,
${misc:Depends}
-Suggests: libaspectj-java,
+Suggests: libaspectj-java (>= 1.9.2),
libcommons-collections3-java,
liblog4j1.2-java
Description: modular Java/J2EE application framework - Core
diff --git a/debian/copyright b/debian/copyright
index 6b067e29..002ad044 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,14 +1,14 @@
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Spring Framework
Upstream-Contact: SpringSource Inc.
-Source: http://springframework.org/download
+Source: https://github.com/spring-projects/spring-framework/tags
Files-Excluded: *.jar
.settings
gradlew*
gradle/wrapper/*
Files: *
-Copyright: 2002-2011, the original author or authors
+Copyright: 2002-2019, the original author or authors
2004, 2005 Acegi Technology Pty Limited
2009 SpringSource Inc.
License: Apache-2.0
diff --git a/debian/patches/0051-reproducible-build-source-date.patch
b/debian/patches/0051-reproducible-build-source-date.patch
new file mode 100644
index ..22c413d2
--- /dev/null
+++ b/debian/patches/0051-reproducible-build-source-date.patch
@@ -0,0 +1,15 @@
+Description: use a reproducible copyright date in the JAR metadata
+Author: tony mancill
+Forwarded: not-needed
+
+--- a/build.gradle
b/build.gradle
+@@ -234,7 +234,7 @@
+ include "license.txt"
+ include "notice.txt"
+ into "META-INF"
+- expand(copyright: new Date().format(""), version:
project.version)
++ expand(copyright: new
Date(Long.valueOf(System.getenv("SOURCE_DATE_EPOCH")) * 1000).format(""),
version: project.version)
+ }
+ }
+
diff --git a/debian/patches/series b/debian/patches/series
index 4bd9f9f5..ec84d3b3 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
On Tue, 26 Mar 2019 14:46:35 +0100 Mattia Rizzolo wrote: > Dear maintainer (and tony, whose upload 4.3.22-2 caused this bug), > > your package libspring-java suddenly stopped building two binaries that > were actively used by other packages, like activemq. > > What's very worse, the changelog doesn't mention any reason for doing > so. I think this was done to remove the openhft packages that are incompatible with Java 11. But maybe the affected Spring modules could be salvaged by disabling the code using openhft (if it's optional). Emmanuel Bourg
Bug#925533: libspring-java: stopped building libspring-jms-java and libspring-messaging-java
Source: libspring-java Version: 4.3.22-2 Severity: serious X-Debbugs-Cc: tony mancill Control: block 925390 924635 924634 by -1 Dear maintainer (and tony, whose upload 4.3.22-2 caused this bug), your package libspring-java suddenly stopped building two binaries that were actively used by other packages, like activemq. What's very worse, the changelog doesn't mention any reason for doing so. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
