Bug#925932: logtop FTCBFS: does not pass cross tools to make

2019-03-28 Thread Helmut Grohne
On Thu, Mar 28, 2019 at 10:14:42PM +, Julien Palard wrote:
> I do not feel like re-reading the whole maintainer guide tonight to play the 
> "find the 7 difference" game between "level 7" and the "current level". But 
> don't hesitate to tell me if there's some (simple) steps missing for this 
> cross build to pass.

Take your time. The bug at hand is not release-critical and Debian is
currently frozen. You shouldn't be uploading this to unstable anyway
before buster is released.

The debhelper warning is quite harmless and my patch is sufficient for
making logtop cross build. It is informing you that you are using old
interfaces and should be upgrading eventually, but not necessarily now.
man 7 debhelper has an upgrading checklist for your convenience.

Helmut



Bug#925932: logtop FTCBFS: does not pass cross tools to make

2019-03-28 Thread Julien Palard
Hi! Thanks a lot for reporting and providing a patch, appreciated!

Did not touched this packet since 2012, sorry I'm a bit "rusty" about Debian 
packaging...

Found I did not even versionned my debian/ directory, but I found it on my 
server, so I created a branch for this:

https://github.com/JulienPalard/logtop/tree/debian/sid

I applied your patch, but looks like there's still work to do, 
dpkg-buildpackage whines a lot about "dh: Compatibility levels before 9 are 
deprecated (level 7 in use)", looks like time flies!

I do not feel like re-reading the whole maintainer guide tonight to play the 
"find the 7 difference" game between "level 7" and the "current level". But 
don't hesitate to tell me if there's some (simple) steps missing for this cross 
build to pass.

Bests,
-- 
Julien Palard
https://mdk.fr



Bug#925932: logtop FTCBFS: does not pass cross tools to make

2019-03-28 Thread Helmut Grohne
Source: logtop
Version: 0.4.3-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

logtop fails to cross build from source, because it does not pass cross
tools to make. The easiest way of fixing that - using dh_auto_build -
makes logtop cross buildable. Please consider applying the attached
patch.

Helmut
diff --minimal -Nru logtop-0.4.3/debian/changelog logtop-0.4.3/debian/changelog
--- logtop-0.4.3/debian/changelog   2012-06-05 22:39:38.0 +0200
+++ logtop-0.4.3/debian/changelog   2019-03-28 19:22:57.0 +0100
@@ -1,3 +1,10 @@
+logtop (0.4.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dh_auto_build pass cross tools to make. (Closes: #-1)
+
+ -- Helmut Grohne   Thu, 28 Mar 2019 19:22:57 +0100
+
 logtop (0.4.3-1) unstable; urgency=low
 
   * New Support LDFLAGS in Makefile
diff --minimal -Nru logtop-0.4.3/debian/rules logtop-0.4.3/debian/rules
--- logtop-0.4.3/debian/rules   2012-05-28 13:26:36.0 +0200
+++ logtop-0.4.3/debian/rules   2019-03-28 19:22:56.0 +0100
@@ -5,7 +5,7 @@
 include /usr/share/dpkg/buildflags.mk
 
 override_dh_auto_build:
-   $(MAKE) CFLAGS="$(CFLAGS) -D_FORTIFY_SOURCE=2" LDFLAGS="$(LDFLAGS)"
+   dh_auto_build -- CFLAGS="$(CFLAGS) -D_FORTIFY_SOURCE=2" 
LDFLAGS="$(LDFLAGS)"
 
 %:
dh $@