Bug#926907: unblock: python-django-casclient/1.2.0-2.2
On Sun, Apr 14, 2019 at 08:53:54AM -0400, Bill Blough wrote: > Unfortunately, I noticed the state of the package too late to get > everything in top shape in time for buster, but I would like to get this > particular fix uploaded to stable in the next point release, as well as > get the package updated to the latest upstream release for inclusion in > backports and Bullseye. > > I plan to discuss co-maintenance and/or adoption of the package with the > current maintainer in order to help make all of this happen. > > Does this sound reasonable, or do you think I'm going down the wrong > path here? This is a sound plan. Please go ahead (you will need to discuss fixes in stable with the SRMs separately). Thanks, -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
Bug#926907: unblock: python-django-casclient/1.2.0-2.2
On Sun, Apr 14, 2019 at 01:02:55PM +0100, Jonathan Wiltshire wrote: > On Thu, Apr 11, 2019 at 09:37:03PM -0400, William Blough wrote: > > I do not comment on your proposed fix, but I do question the value of > including this package in buster at all. If it is broken with Django > >=1.10, doesn't that mean the bug affects stable too and nobody has > noticed all this time? That would appear to be the case. Popcon only reports about a dozen installs, so it doesn't appear to be widely used. The only assumptions I can make are that the people with it installed either aren't using it, or are using it with an older version of Django. Or maybe they installed it, discovered that it didn't work, and installed a newer version via pip instead (which admittedly is a wild guess - no evidence one way or the other). Regardless, I agree the numbers are low. > > Besides that it has had just one other upload since it was first in the > archive, which was also an NMU. What are the plans for its long-term > maintenance if it is indeed included in buster? With Stanford's WebAuth now EOL, one of the projects I work on at my employer is moving from WebAuth to CAS for SSO. I already maintain python-django-cas-server under the umbrella of the Python Modules Team, and my intent is to also supply whatever support is needed for python-django-casclient. Unfortunately, I noticed the state of the package too late to get everything in top shape in time for buster, but I would like to get this particular fix uploaded to stable in the next point release, as well as get the package updated to the latest upstream release for inclusion in backports and Bullseye. I plan to discuss co-maintenance and/or adoption of the package with the current maintainer in order to help make all of this happen. Does this sound reasonable, or do you think I'm going down the wrong path here?
Bug#926907: unblock: python-django-casclient/1.2.0-2.2
On Thu, Apr 11, 2019 at 09:37:03PM -0400, William Blough wrote: > Please unblock package python-django-casclient > > As explained in bug #926350 [1], python-django-casclient is broken when used > with Django versions >= 1.10, due to Django middleware API changes. Since > Buster will ship with Django 1.11, python-django-casclient is useless in its > current state. I do not comment on your proposed fix, but I do question the value of including this package in buster at all. If it is broken with Django >=1.10, doesn't that mean the bug affects stable too and nobody has noticed all this time? Besides that it has had just one other upload since it was first in the archive, which was also an NMU. What are the plans for its long-term maintenance if it is indeed included in buster? -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
Bug#926907: unblock: python-django-casclient/1.2.0-2.2
Control: tags -1 confirmed moreinfo Hi, On Thu, Apr 11, 2019 at 09:37:03PM -0400, William Blough wrote: > Please unblock package python-django-casclient > > As explained in bug #926350 [1], python-django-casclient is broken when used > with Django versions >= 1.10, due to Django middleware API changes. Since > Buster will ship with Django 1.11, python-django-casclient is useless in its > current state. > > The patch to fix the issue was obtained from upstream [2]. The source > debdiff between the version in testing/unstable and the fixed version I > would like to upload (via unstable) is attached. Please go ahead with the upload to unstable based on this patch and remove the moreinfo tag from this bug once the builds are done. Thanks, Ivo
Bug#926907: unblock: python-django-casclient/1.2.0-2.2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package python-django-casclient As explained in bug #926350 [1], python-django-casclient is broken when used with Django versions >= 1.10, due to Django middleware API changes. Since Buster will ship with Django 1.11, python-django-casclient is useless in its current state. The patch to fix the issue was obtained from upstream [2]. The source debdiff between the version in testing/unstable and the fixed version I would like to upload (via unstable) is attached. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926350 [2] https://github.com/kstateome/django-cas/pull/64 unblock python-django-casclient/1.2.0-2.2 -- System Information: Debian Release: 9.8 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) diff -Nru python-django-casclient-1.2.0/debian/changelog python-django-casclient-1.2.0/debian/changelog --- python-django-casclient-1.2.0/debian/changelog 2018-09-22 05:04:25.0 -0400 +++ python-django-casclient-1.2.0/debian/changelog 2019-04-03 17:26:47.0 -0400 @@ -1,3 +1,10 @@ +python-django-casclient (1.2.0-2.2) unstable; urgency=medium + + * Non-maintainer upload. + * Apply django 1.10 middleware fix from upstream (Closes: #926350) + + -- William Blough Wed, 03 Apr 2019 17:26:47 -0400 + python-django-casclient (1.2.0-2.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix --- python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix 1969-12-31 19:00:00.0 -0500 +++ python-django-casclient-1.2.0/debian/patches/django_110_middleware_fix 2019-04-03 17:26:47.0 -0400 @@ -0,0 +1,41 @@ +Description: Fix middleware to be compatible with Django 1.10 +Origin: upstream, https://patch-diff.githubusercontent.com/raw/kstateome/django-cas/pull/64.diff +Last-Update: 2019-04-11 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/cas/middleware.py b/cas/middleware.py +@@ -5,6 +5,15 @@ try: + except ImportError: + from urllib.parse import urlencode + ++ ++MIDDLEWARE_BASE = None ++ ++try: ++from django.utils.deprecation import MiddlewareMixin ++MIDDLEWARE_BASE = MiddlewareMixin ++except ImportError: ++MIDDLEWARE_BASE = object ++ + from django.conf import settings + from django.contrib.auth import REDIRECT_FIELD_NAME + from django.contrib.auth import logout as do_logout +@@ -19,7 +28,7 @@ from cas.views import login as cas_login + __all__ = ['CASMiddleware'] + + +-class CASMiddleware(object): ++class CASMiddleware(MIDDLEWARE_BASE): + """ + Middleware that allows CAS authentication on admin pages + """ +@@ -81,7 +90,7 @@ class CASMiddleware(object): + return None + + +-class ProxyMiddleware(object): ++class ProxyMiddleware(MIDDLEWARE_BASE): + + # Middleware used to "fake" the django app that it lives at the Proxy Domain + def process_request(self, request): diff -Nru python-django-casclient-1.2.0/debian/patches/series python-django-casclient-1.2.0/debian/patches/series --- python-django-casclient-1.2.0/debian/patches/series 1969-12-31 19:00:00.0 -0500 +++ python-django-casclient-1.2.0/debian/patches/series 2019-04-03 17:26:47.0 -0400 @@ -0,0 +1 @@ +django_110_middleware_fix
