Bug#928118: libzfs2linux: coredump in zfs send -n -v -I A B

[James Youngman]

On Mon, Apr 29, 2019 at 6:03 PM Mo Zhou  wrote:
> Can this problem be eliminated after aligning the version of all
> ZFS related packages? If so, this would a confirmed bug to be fixed.

That's what I did, and it resolved the problem.   Full details at the
link I provided previously.

(I believe also the command-line tools should be updated such that
they don't abort when a zfs_ioctl() call fails, too)

Bug#928118: libzfs2linux: coredump in zfs send -n -v -I A B

[Mo Zhou]

Hi James,

Can this problem be eliminated after aligning the version of all
ZFS related packages? If so, this would a confirmed bug to be fixed.

On Mon, Apr 29, 2019 at 01:55:06PM +0100, James Youngman wrote:
> Cause and solution are described in some detail here:
> https://www.reddit.com/r/zfs/comments/bicu1g/zfs_send_issues_a_zfs_ioctl_which_fails_with/em1rj9r/?utm_source=share&utm_medium=web2x
>  -- the cause was a config error, and the solution was to correct the
> config error.
> 
> But, when an ioctl() call fails with EINVAL, this should not cause a
> coredump in the zfs tools.  IMO that's still a bug.

Bug#928118: libzfs2linux: coredump in zfs send -n -v -I A B

[James Youngman]

Cause and solution are described in some detail here:
https://www.reddit.com/r/zfs/comments/bicu1g/zfs_send_issues_a_zfs_ioctl_which_fails_with/em1rj9r/?utm_source=share&utm_medium=web2x
 -- the cause was a config error, and the solution was to correct the
config error.

But, when an ioctl() call fails with EINVAL, this should not cause a
coredump in the zfs tools.  IMO that's still a bug.

Bug#928118: libzfs2linux: coredump in zfs send -n -v -I A B

[Mo Zhou]

Hi,

I cannot reproduce this problem with 0.7.13-1.
The following findings seem related:

https://github.com/zfsonlinux/zfs/issues/3666

https://github.com/zfsonlinux/zfs/commit/cf7684bc8d57ace26d086027e8059c725fd9ff92#diff-66bd524398bcd2ac70d90925ab6d8073

but I'm not sure wheter the problem you reported had been fixed by this
change.

Bug#928118: libzfs2linux: coredump in zfs send -n -v -I A B

[James Youngman]

Package: libzfs2linux
Version: 0.7.12-1~bpo9+1
Severity: important

# rm core; /sbin/zfs send -n -v -I zpool1@syncoid_jupiter_2018-07-26:15:23:03 
zpool1@syncoid_jupiter_2019-04-28:14:07:48; echo $?
internal error: Invalid argument
Aborted (core dumped)
134
#  gdb /sbin/zfs core
GNU gdb (Debian 7.12-6) 7.12.0.20161007-git
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
.
Find the GDB manual and other documentation resources online at:
.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /sbin/zfs...(no debugging symbols found)...done.
[New LWP 9895]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/sbin/zfs send -n -v -I 
zpool1@syncoid_jupiter_2018-07-26:15:23:03 zpool1@synco'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51  ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x7f8bd4b6142a in __GI_abort () at abort.c:89
#2  0x7f8bd573d382 in ?? () from /lib/libzfs.so.2
#3  0x7f8bd573d9a7 in zfs_standard_error_fmt () from /lib/libzfs.so.2
#4  0x7f8bd573473d in ?? () from /lib/libzfs.so.2
#5  0x7f8bd57364a8 in ?? () from /lib/libzfs.so.2
#6  0x7f8bd5727f71 in zfs_iter_snapshots_sorted () from /lib/libzfs.so.2
#7  0x7f8bd5733601 in ?? () from /lib/libzfs.so.2
#8  0x7f8bd57356dc in ?? () from /lib/libzfs.so.2
#9  0x7f8bd573b0c7 in zfs_send () from /lib/libzfs.so.2
#10 0x559ffc4c1a1e in ?? ()
#11 0x559ffc4be684 in ?? ()
#12 0x7f8bd4b4d2e1 in __libc_start_main (main=0x559ffc4be3f0, argc=7, 
argv=0x7ffc96434848, 
init=, fini=, rtld_fini=, 
stack_end=0x7ffc96434838) at ../csu/libc-start.c:291
#13 0x559ffc4be7ca in ?? ()


-- System Information:
Debian Release: 9.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_IE:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libzfs2linux depends on:
ii  libblkid12.29.2-1+deb9u1
ii  libc62.24-11+deb9u4
ii  libnvpair1linux  0.7.12-1~bpo9+1
ii  libuuid1 2.29.2-1+deb9u1
ii  libuutil1linux   0.7.12-1~bpo9+1
ii  libzpool2linux   0.7.12-1~bpo9+1
ii  zlib1g   1:1.2.8.dfsg-5

libzfs2linux recommends no packages.

libzfs2linux suggests no packages.

-- no debconf information