Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2021-02-26 Thread Nick Gasson
On 01/17/21 22:54 pm, Sebastian Ramacher wrote:
>> 
>> In https://trac.videolan.org/vlc/ticket/25252, upstream answer :
>> 
>> > That CDDB bug was fixed 9 years ago in VLC contribs. Complain to Debian.
>> 
>> Can you have a look on debian side ?
>
> Reassigning to libcddb2.
>

I believe this is the patch in VLC's vendored copy they are referring
to:

https://code.videolan.org/videolan/vlc/-/commit/29d3ded7194271

It disables the use of alarm() to set a timeout for gethostbyname()
which isn't safe if called from a program with multiple threads.

>
>> 
>> I made test with fedora 33 live + install proccess
>> (https://www.videolan.org/vlc/download-fedora.html).
>> vlc is functional.
>>

Fedora seems to use a different patch which just disables
_FORTIFY_SOURCE in that file to avoid the longjmp() crash:

https://src.fedoraproject.org/rpms/libcddb/blob/rawhide/f/libcddb-1.3.2-rhbz770611.patch

Although I think it still has a problem where SIGALRM can be delivered
to any thread in the program, so it's better to avoid using alarm()
entirely as the VLC patch does. gethostbyname will time out by itself
anyway. I've rebuilt the package with the patch below and tested locally
without any problems.

diff --git a/lib/cddb_net.c b/lib/cddb_net.c
index 7adf37b..aac3967 100644
--- a/lib/cddb_net.c
+++ b/lib/cddb_net.c
@@ -228,6 +228,10 @@ int sock_vfprintf(cddb_conn_t *c, const char *format, 
va_list ap)
 
 /* Time-out enabled work-alikes */
 
+/* Do not use SIGALRM in Debian as it is not safe if used in a program
+   with multiple threads. */
+#undef HAVE_ALARM
+
 #ifdef HAVE_ALARM
 /* time-out jump buffer */
 static jmp_buf timeout_expired;

--
Thanks,
Nick



Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2021-01-17 Thread Sebastian Ramacher
Control: reassign -1 libcddb2 1.3.2-6

On 2021-01-17 15:44:13 +0100, Serge Pouliquen wrote:
> Hello,
> 
> In https://trac.videolan.org/vlc/ticket/25252, upstream answer :
> 
> > That CDDB bug was fixed 9 years ago in VLC contribs. Complain to Debian.
> 
> Can you have a look on debian side ?

Reassigning to libcddb2.

Cheers

> 
> I made test with fedora 33 live + install proccess
> (https://www.videolan.org/vlc/download-fedora.html).
> vlc is functional.
> 
> Regards,
> Serge
> 

-- 
Sebastian Ramacher


signature.asc
Description: PGP signature


Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2021-01-17 Thread Serge Pouliquen

Hello,

In https://trac.videolan.org/vlc/ticket/25252, upstream answer :

> That CDDB bug was fixed 9 years ago in VLC contribs. Complain to Debian.

Can you have a look on debian side ?

I made test with fedora 33 live + install proccess 
(https://www.videolan.org/vlc/download-fedora.html).

vlc is functional.

Regards,
Serge



Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2020-11-15 Thread Serge Pouliquen

Hi,

issue is still present in current version.
reported upstream asĀ  https://trac.videolan.org/vlc/ticket/25252

Regards,
Serge



Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2019-08-27 Thread Sebastian Ramacher
Control: tags -1 + moreinfo

Hi

On 2019-04-29 15:18:19, Serge Pouliquen wrote:
> Package: src:vlc
> Version: 3.0.6-0+deb9u1
> Severity: normal
> 
> Dear Maintainer,
> 
> 
>* What led up to the situation?
> remove wire cable from ethernet
> play cd audio with vlc
>* What exactly did you do (or not do) that was effective (or
>  ineffective)?
> with net connection, vlc can play cd audio and display title from cddb 
> protocol
>* What was the outcome of this action?
> fix network connection
>* What outcome did you expect instead?
> to be able to play cd audio without internet connection

Sorry for the delay. If this issue is still reproducible with 3.0.8,
please install the -dbgsym packages and provide a backtrace (including
the vlc -vvv log). Additionally, please report the issue on upstream's
bug tracker (https://trac.videolan.org/vlc/) and let us know the bug
number.

Cheers

> 
> 
> -- System Information:
> Debian Release: 9.9
>   APT prefers stable-updates
>   APT policy: (700, 'stable-updates'), (700, 'stable'), (80, 'testing'), (58, 
> 'unstable'), (55, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.9.0-9-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), 
> LANGUAGE=en_GB:en (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages vlc depends on:
> ii  dpkg 1.18.25
> ii  vlc-bin  3.0.6-0+deb9u1
> ii  vlc-l10n 3.0.6-0+deb9u1
> ii  vlc-plugin-base  3.0.6-0+deb9u1
> ii  vlc-plugin-qt3.0.6-0+deb9u1
> ii  vlc-plugin-video-output  3.0.6-0+deb9u1
> 
> Versions of packages vlc recommends:
> ii  vlc-plugin-notify  3.0.6-0+deb9u1
> ii  vlc-plugin-samba   3.0.6-0+deb9u1
> ii  vlc-plugin-skins2  3.0.6-0+deb9u1
> ii  vlc-plugin-video-splitter  3.0.6-0+deb9u1
> ii  vlc-plugin-visualization   3.0.6-0+deb9u1
> 
> vlc suggests no packages.
> 
> Versions of packages libvlc-bin depends on:
> ii  libc62.24-11+deb9u4
> ii  libvlc5  3.0.6-0+deb9u1
> 
> Versions of packages libvlc5 depends on:
> ii  dpkg 1.18.25
> ii  libc62.24-11+deb9u4
> ii  libvlccore9  3.0.6-0+deb9u1
> 
> Versions of packages libvlc5 recommends:
> ii  libvlc-bin  3.0.6-0+deb9u1
> 
> Versions of packages vlc-bin depends on:
> ii  libc6   2.24-11+deb9u4
> ii  libvlc-bin  3.0.6-0+deb9u1
> ii  libvlc5 3.0.6-0+deb9u1
> 
> Versions of packages vlc-plugin-base depends on:
> ii  dpkg 1.18.25
> ii  liba52-0.7.4 0.7.4-19
> ii  libarchive13 3.2.2-2+deb9u1
> ii  libasound2   1.1.3-5
> ii  libass5  1:0.13.4-2
> ii  libavahi-client3 0.6.32-2
> ii  libavahi-common3 0.6.32-2
> ii  libavc1394-0 0.5.4-4+b1
> ii  libavcodec57 7:3.2.12-1~deb9u1
> ii  libavformat577:3.2.12-1~deb9u1
> ii  libavutil55  7:3.2.12-1~deb9u1
> ii  libbasicusageenvironment12016.11.28-1+deb9u2
> ii  libbluray1   1:0.9.3-3
> ii  libc62.24-11+deb9u4
> ii  libcairo21.14.8-1
> ii  libcddb2 1.3.2-5
> ii  libchromaprint1  1.4.2-1
> ii  libcrystalhd31:0.0~git20110715.fdd2f19-12
> ii  libdbus-1-3  1.10.26-0+deb9u1
> ii  libdc1394-22 2.2.5-1
> ii  libdca0  0.0.5-10
> ii  libdvbpsi10  1.3.0-5
> ii  libdvdnav4   5.0.3-3
> ii  libdvdread4  5.0.3-2
> ii  libebml4v5   1.3.4-1
> ii  libfaad2 2.8.0~cvs20161113-1+deb9u1
> ii  libflac8 1.3.2-1
> ii  libfontconfig1   2.11.0-6.7+b1
> ii  libfreetype6 2.6.3-3.2
> ii  libfribidi0  0.19.7-1+b1
> ii  libgcc1  1:6.3.0-18+deb9u1
> ii  libgcrypt20  1.7.6-2+deb9u3
> ii  libglib2.0-0 2.50.3-2
> ii  libgnutls30  3.5.8-5+deb9u4
> ii  libgpg-error01.26-2
> ii  libgroupsock82016.11.28-1+deb9u2
> ii  libharfbuzz0b1.4.2-1
> ii  libjpeg62-turbo  1:1.5.1-2
> ii  libkate1 0.4.1-7+b1
> ii  liblirc-client0  0.9.4c-9
> ii  liblivemedia57   2016.11.28-1+deb9u2
> ii  liblua5.2-0  5.2.4-1.1+b2
> ii  libmad0  0.15.1b-8+deb9u1
> ii  libmatroska6v5   1.4.5-2
> ii  libmicrodns0 

Bug#928176: vlc: BOBOOvlc cannot play cd audio without net connection and crash

2019-04-29 Thread Serge Pouliquen
Package: src:vlc
Version: 3.0.6-0+deb9u1
Severity: normal

Dear Maintainer,


   * What led up to the situation?
remove wire cable from ethernet
play cd audio with vlc
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
with net connection, vlc can play cd audio and display title from cddb protocol
   * What was the outcome of this action?
fix network connection
   * What outcome did you expect instead?
to be able to play cd audio without internet connection


-- System Information:
Debian Release: 9.9
  APT prefers stable-updates
  APT policy: (700, 'stable-updates'), (700, 'stable'), (80, 'testing'), (58, 
'unstable'), (55, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-9-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages vlc depends on:
ii  dpkg 1.18.25
ii  vlc-bin  3.0.6-0+deb9u1
ii  vlc-l10n 3.0.6-0+deb9u1
ii  vlc-plugin-base  3.0.6-0+deb9u1
ii  vlc-plugin-qt3.0.6-0+deb9u1
ii  vlc-plugin-video-output  3.0.6-0+deb9u1

Versions of packages vlc recommends:
ii  vlc-plugin-notify  3.0.6-0+deb9u1
ii  vlc-plugin-samba   3.0.6-0+deb9u1
ii  vlc-plugin-skins2  3.0.6-0+deb9u1
ii  vlc-plugin-video-splitter  3.0.6-0+deb9u1
ii  vlc-plugin-visualization   3.0.6-0+deb9u1

vlc suggests no packages.

Versions of packages libvlc-bin depends on:
ii  libc62.24-11+deb9u4
ii  libvlc5  3.0.6-0+deb9u1

Versions of packages libvlc5 depends on:
ii  dpkg 1.18.25
ii  libc62.24-11+deb9u4
ii  libvlccore9  3.0.6-0+deb9u1

Versions of packages libvlc5 recommends:
ii  libvlc-bin  3.0.6-0+deb9u1

Versions of packages vlc-bin depends on:
ii  libc6   2.24-11+deb9u4
ii  libvlc-bin  3.0.6-0+deb9u1
ii  libvlc5 3.0.6-0+deb9u1

Versions of packages vlc-plugin-base depends on:
ii  dpkg 1.18.25
ii  liba52-0.7.4 0.7.4-19
ii  libarchive13 3.2.2-2+deb9u1
ii  libasound2   1.1.3-5
ii  libass5  1:0.13.4-2
ii  libavahi-client3 0.6.32-2
ii  libavahi-common3 0.6.32-2
ii  libavc1394-0 0.5.4-4+b1
ii  libavcodec57 7:3.2.12-1~deb9u1
ii  libavformat577:3.2.12-1~deb9u1
ii  libavutil55  7:3.2.12-1~deb9u1
ii  libbasicusageenvironment12016.11.28-1+deb9u2
ii  libbluray1   1:0.9.3-3
ii  libc62.24-11+deb9u4
ii  libcairo21.14.8-1
ii  libcddb2 1.3.2-5
ii  libchromaprint1  1.4.2-1
ii  libcrystalhd31:0.0~git20110715.fdd2f19-12
ii  libdbus-1-3  1.10.26-0+deb9u1
ii  libdc1394-22 2.2.5-1
ii  libdca0  0.0.5-10
ii  libdvbpsi10  1.3.0-5
ii  libdvdnav4   5.0.3-3
ii  libdvdread4  5.0.3-2
ii  libebml4v5   1.3.4-1
ii  libfaad2 2.8.0~cvs20161113-1+deb9u1
ii  libflac8 1.3.2-1
ii  libfontconfig1   2.11.0-6.7+b1
ii  libfreetype6 2.6.3-3.2
ii  libfribidi0  0.19.7-1+b1
ii  libgcc1  1:6.3.0-18+deb9u1
ii  libgcrypt20  1.7.6-2+deb9u3
ii  libglib2.0-0 2.50.3-2
ii  libgnutls30  3.5.8-5+deb9u4
ii  libgpg-error01.26-2
ii  libgroupsock82016.11.28-1+deb9u2
ii  libharfbuzz0b1.4.2-1
ii  libjpeg62-turbo  1:1.5.1-2
ii  libkate1 0.4.1-7+b1
ii  liblirc-client0  0.9.4c-9
ii  liblivemedia57   2016.11.28-1+deb9u2
ii  liblua5.2-0  5.2.4-1.1+b2
ii  libmad0  0.15.1b-8+deb9u1
ii  libmatroska6v5   1.4.5-2
ii  libmicrodns0 0.0.3-3
ii  libmpcdec6   2:0.1~r495-1+b1
ii  libmpeg2-4   0.5.1-7+b2
ii  libmpg123-0  1.23.8-1+b1
ii  libmtp9  1.1.13-1
ii  libncursesw5 6.0+20161126-1+deb9u2
ii  libnfs8  1.11.0-2
ii  libogg0  1.3.2-1
ii  libopenmpt-modplug1  0.2.7386~beta20.3-3+deb9u3
ii  libopus0 1.2~alpha2-1
ii  libpng16-16  1.6.28-1+deb9u1
ii  libpostproc54