Bug#928972: unblock: debian-security-support/2019.05.14

2019-05-14 Thread Holger Levsen
On Tue, May 14, 2019 at 12:11:41PM +0200, Holger Levsen wrote:
> +  * postinst and check-support-status.hook: add code to create the d-s-s
> +user's home directory if it doesn't exist, as schroot copies /etc/passwd
> +from the host without creating the user home directories. Closes: 
> #928204.
> +Thanks to Santiago Vila.
> 
> Here I decided to also add this code to check-support-status.hook to be on
> the safe side. I believe this is not needed but let's be safe now.
> (Cleaning this up for bullseye is tracked via #928968.)

as you can read in #928968 it was good to stay on the safe side and to
add the relevant code to check-support-status.hook, so that I have
improved the code comments in git further (see
https://salsa.debian.org/debian/debian-security-support/commit/db4096368c49002cfb413d8a9dabb2afffb39f39
if you care about the details) and closed #928968.

tl;dr: debian-security-support 2019.05.14 is still good for buster as it
is.


-- 
tschau,
Holger

---
   holger@(debian|reproducible-builds|layer-acht).org
   PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C


signature.asc
Description: PGP signature


Bug#928972: unblock: debian-security-support/2019.05.14

2019-05-14 Thread Holger Levsen
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
x-debbugs-cc: sanv...@unex.es

Please unblock package debian-security-support, it fixes two RC bugs.

Attached is the debdiff against 2019.04.25 which is not in testing but
has been unblocked by Niels via #926397.

unblock debian-security-support/2019.05.14

The changelog explained:

+  * check-support-status.in: don't fail if security-support-ended.debX does
+not exist for the release d-s-s is running on. Closes: #927450.

For this I just replaced 'exit 1' with 'exit 0'...

+  * postinst and check-support-status.hook: add code to create the d-s-s
+user's home directory if it doesn't exist, as schroot copies /etc/passwd
+from the host without creating the user home directories. Closes: #928204.
+Thanks to Santiago Vila.

Here I decided to also add this code to check-support-status.hook to be on
the safe side. I believe this is not needed but let's be safe now.
(Cleaning this up for bullseye is tracked via #928968.)

+  * d/control: set myself as maintainer to formally adopt the package and drop
+Christoph Biedl on his request. Many thanks for creating this package and
+maintaining it, Christoph!


-- 
tschau,
Holger

---
   holger@(debian|reproducible-builds|layer-acht).org
   PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

Some people say that the climate crisis  is something that we all have created,
but  that is not true,  because if everyone is guilty  then no one is to blame.
And someone is to blame.  Some people, some companies,  some decision-makers in
particular, have known exactly what priceless values they have been sacrificing
to continue making unimaginable amounts of money.
diff -Nru debian-security-support-2019.04.25/check-support-status.hook debian-security-support-2019.05.14/check-support-status.hook
--- debian-security-support-2019.04.25/check-support-status.hook	2019-04-25 11:24:00.0 +0200
+++ debian-security-support-2019.05.14/check-support-status.hook	2019-05-14 11:36:45.0 +0200
@@ -4,6 +4,8 @@
 #%# License: GPL-2.0-only
 
 # This codes duplicates "postinst configure"
+# 20190514: but why? and why all of it, eg the user creation?
+# FIXME: we should drop this after the Buster release, this is tracked as #928968.
 
 set -e
 
@@ -23,6 +25,12 @@
 "$USERNAME"
 fi
 
+# needed for schroots which copy /etc/passwd from the host
+if [ ! -d "$LIB_DIR" ]; then
+mkdir "$LIB_DIR"
+chown $USERNAME:$USERNAME "$LIB_DIR"
+fi
+
 if [ "$TMPDIR" ] && [ "$(stat --format=%a "$TMPDIR")" != '1777' ] ; then
 export TMPDIR='/tmp'
 fi
diff -Nru debian-security-support-2019.04.25/check-support-status.in debian-security-support-2019.05.14/check-support-status.in
--- debian-security-support-2019.04.25/check-support-status.in	2019-04-25 11:20:34.0 +0200
+++ debian-security-support-2019.05.14/check-support-status.in	2019-05-13 21:14:22.0 +0200
@@ -22,7 +22,7 @@
 
 if [ "$DEBIAN_VERSION" -lt "$DEB_LOWEST_VER_ID" ] || [ "$DEBIAN_VERSION" -gt "$DEB_NEXT_VER_ID" ] ; then
 eval_gettext "Unknown DEBIAN_VERSION \$DEBIAN_VERSION. Valid values from \$DEB_LOWEST_VER_ID and \$DEB_NEXT_VER_ID"; echo
-exit 1
+exit 0
 fi
 
 LIST=
diff -Nru debian-security-support-2019.04.25/debian/changelog debian-security-support-2019.05.14/debian/changelog
--- debian-security-support-2019.04.25/debian/changelog	2019-04-25 11:36:54.0 +0200
+++ debian-security-support-2019.05.14/debian/changelog	2019-05-14 11:48:37.0 +0200
@@ -1,3 +1,17 @@
+debian-security-support (2019.05.14) unstable; urgency=medium
+
+  * check-support-status.in: don't fail if security-support-ended.debX does
+not exist for the release d-s-s is running on. Closes: #927450.
+  * postinst and check-support-status.hook: add code to create the d-s-s
+user's home directory if it doesn't exist, as schroot copies /etc/passwd
+from the host without creating the user home directories. Closes: #928204.
+Thanks to Santiago Vila.
+  * d/control: set myself as maintainer to formally adopt the package and drop
+Christoph Biedl on his request. Many thanks for creating this package and
+maintaining it, Christoph!
+
+ -- Holger Levsen   Tue, 14 May 2019 11:48:37 +0200
+
 debian-security-support (2019.04.25) unstable; urgency=medium
 
   * Team upload.
diff -Nru debian-security-support-2019.04.25/debian/control debian-security-support-2019.05.14/debian/control
--- debian-security-support-2019.04.25/debian/control	2019-04-20 16:17:12.0 +0200
+++ debian-security-support-2019.05.14/debian/control	2019-05-14 11:42:09.0 +0200
@@ -1,7 +1,7 @@
 Source: debian-security-support
 Section: admin
 Priority: optional
-Maintainer: Christoph Biedl 
+Maintainer: Holger Levsen 
 Uploaders: Debian Security Tea