Bug#929410: [Pkg-tigervnc-devel] Bug#929410: RANDR extension not present
Hi Ola and Mike, Am 21.07.19 um 14:01 schrieb Mike Gabriel: > Hi Ola, > > On So 21 Jul 2019 11:17:31 CEST, Ola Lundqvist wrote: > >> Hi Joachim >> >> Thank you. Thinking of this some more we actually did not have this package >> at all in old stable. Did we have RANDR support in the other vnc packages? >> >> // Ola > > AFAIR, VNC in Debian hadn't had RandR (i.e. resizing of the VNC session > window resizes the Xvnc server geometry), so far. no, we already have that in Xtigervnc (i.e., tigervnc-standalone-server). However, x0tigervncserver (i.e., tigervnc-scraping-server) needs libxrandr-dev at compile time to enable RANDR support. It uses RANDR to resize the real Xorg server for which it provides the VNC server. > The Cendio people have that feature enabled for years, also X2Go's x2goagent > (and the new x2gokdrive Xserver) have that feature. A really must have thing, > in fact. > > Greets, > Mike signature.asc Description: OpenPGP digital signature
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: Bug#929410: Bug#929410: RANDR extension not present
Hi Ola, On So 21 Jul 2019 11:17:31 CEST, Ola Lundqvist wrote: Hi Joachim Thank you. Thinking of this some more we actually did not have this package at all in old stable. Did we have RANDR support in the other vnc packages? // Ola AFAIR, VNC in Debian hadn't had RandR (i.e. resizing of the VNC session window resizes the Xvnc server geometry), so far. The Cendio people have that feature enabled for years, also X2Go's x2goagent (and the new x2gokdrive Xserver) have that feature. A really must have thing, in fact. Greets, Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpYGx0fWr15q.pgp Description: Digitale PGP-Signatur
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: Bug#929410: Bug#929410: RANDR extension not present
Hi Joachim Thank you. Thinking of this some more we actually did not have this package at all in old stable. Did we have RANDR support in the other vnc packages? // Ola On Thu, 18 Jul 2019 at 22:24, Joachim Falk wrote: > Hi Ola, > > Am 30.06.19 um 19:04 schrieb Ola Lundqvist: > > Hi > > > > It is too late for buster. Deadline has passed more than a week ago. If > I had been faster maybe it had been possible. > > > > Maybe we can get it to a point release. Do you know how much changes > there are between 1.9.0+dfsg-3 and the one you mentioned? > > It seems to fall in the criteria to fix regression against current > stable. > should fit. Debdiff attached. There are three minor bugs fixed 929410, > 932264, and 905905. Only code change is a > different WM_CLASS for xtigervncviewer. Moreover, xrandr libraries are now > enabled. Thus, additional code will be active > in x0tigervncserver. > > Best, > > Joachim > > ___ > Pkg-tigervnc-devel mailing list > pkg-tigervnc-de...@alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-tigervnc-devel -- - Ola Lundqvist --- / o...@debian.org o...@inguza.com \ | http://inguza.com/ +46 (0)70-332 1551 | ---
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: Bug#929410: RANDR extension not present
Hi Ola,
Am 30.06.19 um 19:04 schrieb Ola Lundqvist:
> Hi
>
> It is too late for buster. Deadline has passed more than a week ago. If I had
> been faster maybe it had been possible.
>
> Maybe we can get it to a point release. Do you know how much changes there
> are between 1.9.0+dfsg-3 and the one you mentioned?
> It seems to fall in the criteria to fix regression against current stable.
should fit. Debdiff attached. There are three minor bugs fixed 929410, 932264,
and 905905. Only code change is a
different WM_CLASS for xtigervncviewer. Moreover, xrandr libraries are now
enabled. Thus, additional code will be active
in x0tigervncserver.
Best,
Joachim
diff -Nru tigervnc-1.9.0+dfsg/debian/changelog tigervnc-1.9.0+dfsg/debian/changelog
--- tigervnc-1.9.0+dfsg/debian/changelog 2018-12-01 22:51:29.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/changelog 2019-07-18 17:59:04.0 +0200
@@ -1,3 +1,16 @@
+tigervnc (1.9.0+dfsg-4~RC3) UNRELEASED; urgency=medium
+
+ [ Joachim Falk ]
+ * Fix gnome shell integration of xtigervncviewer by updating
+xtigervncviewer.desktop and WM_CLASS of xtigervncviewer. (Closes: #905905)
+ * Added missing dependencies to enable RANDR support in x0tigervncserver,
+i.e., tigervnc-scraping-server. Also ensure that dropping these
+dependencies will lead to a fatal build error in the future. (Closes: #929410)
+ * Bumped version number in Debian provided man pages to TigerVNC 1.9
+(Closes: #932264).
+
+ -- Joachim Falk Thu, 18 Jul 2019 17:57:33 +0200
+
tigervnc (1.9.0+dfsg-3) unstable; urgency=medium
[ Joachim Falk ]
diff -Nru tigervnc-1.9.0+dfsg/debian/control tigervnc-1.9.0+dfsg/debian/control
--- tigervnc-1.9.0+dfsg/debian/control 2018-12-01 22:51:29.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/control 2019-06-15 20:50:33.0 +0200
@@ -24,6 +24,7 @@
libpam0g-dev,
libxft-dev,
libxcursor-dev,
+ libxrandr-dev,
libwrap0-dev,
libfltk1.3-dev (>= 1.3.3),
xorg-server-source (>= 2:1.20),
diff -Nru tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1
--- tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 2018-12-01 22:50:28.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 2019-07-18 17:53:14.0 +0200
@@ -1,4 +1,4 @@
-.TH tigervncserver 1 "Jan 5th, 2017" "TigerVNC 1.7" "Virtual Network Computing"
+.TH tigervncserver 1 "Jul 18th, 2019" "TigerVNC 1.9" "Virtual Network Computing"
.SH NAME
tigervncserver \- start or stop a TigerVNC server
.SH SYNOPSIS
diff -Nru tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man5/vnc.conf.5x tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man5/vnc.conf.5x
--- tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man5/vnc.conf.5x 2018-12-01 22:50:28.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/helpers/usr/share/man/man5/vnc.conf.5x 2019-07-18 17:52:52.0 +0200
@@ -9,7 +9,7 @@
.\" License as specified in the file COPYING that comes with the
.\" Debian GNU/Linux distribution.
.\"
-.TH vnc.conf 5x "Jan 5th, 2017" "TigerVNC 1.7" "Virtual Network Computing"
+.TH vnc.conf 5x "Jul 18th, 2019" "TigerVNC 1.9" "Virtual Network Computing"
.SH NAME
vnc.conf \- configuration file for Virtual Network Computing
.SH SYNOPSIS
diff -Nru tigervnc-1.9.0+dfsg/debian/patches/0175-xtigervncviewer-WM_CLASS.patch tigervnc-1.9.0+dfsg/debian/patches/0175-xtigervncviewer-WM_CLASS.patch
--- tigervnc-1.9.0+dfsg/debian/patches/0175-xtigervncviewer-WM_CLASS.patch 1970-01-01 01:00:00.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/patches/0175-xtigervncviewer-WM_CLASS.patch 2019-06-15 14:11:27.0 +0200
@@ -0,0 +1,16 @@
+Description: Update WM_CLASS to correspond to the one given in the xtigervncviewer.desktop file
+Author: Joachim Falk
+
+Index: pkg-tigervnc/vncviewer/vncviewer.cxx
+===
+--- pkg-tigervnc.orig/vncviewer/vncviewer.cxx
pkg-tigervnc/vncviewer/vncviewer.cxx
+@@ -197,7 +197,7 @@ static void init_fltk()
+
+ // Proper Gnome Shell integration requires that we set a sensible
+ // WM_CLASS for the window.
+- Fl_Window::default_xclass("vncviewer");
++ Fl_Window::default_xclass("TigerVNC Viewer");
+
+ // Set the default icon for all windows.
+ #ifdef WIN32
diff -Nru tigervnc-1.9.0+dfsg/debian/patches/series tigervnc-1.9.0+dfsg/debian/patches/series
--- tigervnc-1.9.0+dfsg/debian/patches/series 2018-12-01 22:51:29.0 +0100
+++ tigervnc-1.9.0+dfsg/debian/patches/series 2019-06-15 14:11:27.0 +0200
@@ -1,5 +1,6 @@
0102-fix-spelling-error-in-manpages-to-shutup-lintian.patch
0151-make-cmake-enable-options-mandatory-if-turned-on.patch
+0175-xtigervncviewer-WM_CLASS.patch
# rework/0200-add-tcpwrappers-support.patch # This patch is still not ported
# These patches are lifted from RedHat
@@ -16,6 +17,7 @@
#rh/dustbin/tigervnc-xserver119.patch # buster has xserver120 and T
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: Bug#929410: RANDR extension not present
Hi It is too late for buster. Deadline has passed more than a week ago. If I had been faster maybe it had been possible. Maybe we can get it to a point release. Do you know how much changes there are between 1.9.0+dfsg-3 and the one you mentioned? It seems to fall in the criteria to fix regression against current stable. Best regards // Ola // Ola On Sat, 15 Jun 2019 at 21:12, Joachim Falk wrote: > Hi Ola, > > Am 26.05.19 um 21:54 schrieb Ola Lundqvist: > > Hi > > > > Thank you for the report. I cannot reproduce the problem on Debian > stable with version 1.7.0. > > I do not have a system running sid right now. > > I could reproduce this on buster. Fix is integrated in 1.9.0+dfsg-4~RC2 > which is present > on salsa in the master branch. Maybe you or Mike can release this so we > might still hit the buster > release with the bug fix. > > Best, > > Joachim > > -- - Ola Lundqvist --- / o...@debian.org o...@inguza.com \ | http://inguza.com/ +46 (0)70-332 1551 | ---
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: Bug#929410: RANDR extension not present
Hi Ola, Am 26.05.19 um 21:54 schrieb Ola Lundqvist: > Hi > > Thank you for the report. I cannot reproduce the problem on Debian stable > with version 1.7.0. > I do not have a system running sid right now. I could reproduce this on buster. Fix is integrated in 1.9.0+dfsg-4~RC2 which is present on salsa in the master branch. Maybe you or Mike can release this so we might still hit the buster release with the bug fix. Best, Joachim signature.asc Description: OpenPGP digital signature
Bug#929410: [Pkg-tigervnc-devel] Bug#929410: RANDR extension not present
Hi Thank you for the report. I cannot reproduce the problem on Debian stable with version 1.7.0. I do not have a system running sid right now. // Ola On Thu, 23 May 2019 at 00:51, Floris Bos wrote: > Package: tigervnc-scraping-server > > Version: 1.9.0+dfsg-3 > > > Seems the tigervnc package is missing randr support. > > > == > > $ x0tigervncserver -SecurityTypes none > > Wed May 22 22:20:30 2019 > Geometry:Desktop geometry is set to 1024x768+0+0 > XDesktop:Using evdev codemap > > XDesktop:XTest extension present - version 2.2 > XDesktop:RANDR extension not present > XDesktop:Will not be able to handle session resize > Main:Listening on port 5900 > ^C > > == > > > While my system/X server certainly has the RANDR extension: > > > == > > $ xrandr > Screen 0: minimum 320 x 200, current 1024 x 768, maximum 7680 x 7680 > HDMI-1 connected primary 1024x768+0+0 (normal left inverted right x axis > y axis) 0mm x 0mm > 1024x768 60.00* > 800x600 60.3256.25 > 848x480 60.00 > 640x480 59.94 > > == > > > Think you are missing a build dependeny on the libxrandr2 library. > > If HAVE_XRANDR is not set at compile time, it always prints the message > ( > > https://github.com/TigerVNC/tigervnc/blob/master/unix/x0vncserver/XDesktop.cxx#L182 > ) > > ___ > Pkg-tigervnc-devel mailing list > pkg-tigervnc-de...@alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-tigervnc-devel -- - Ola Lundqvist --- / o...@debian.org o...@inguza.com \ | http://inguza.com/ +46 (0)70-332 1551 | ---
Bug#929410: RANDR extension not present
Package: tigervnc-scraping-server Version: 1.9.0+dfsg-3 Seems the tigervnc package is missing randr support. == $ x0tigervncserver -SecurityTypes none Wed May 22 22:20:30 2019 Geometry: Desktop geometry is set to 1024x768+0+0 XDesktop: Using evdev codemap XDesktop: XTest extension present - version 2.2 XDesktop: RANDR extension not present XDesktop: Will not be able to handle session resize Main: Listening on port 5900 ^C == While my system/X server certainly has the RANDR extension: == $ xrandr Screen 0: minimum 320 x 200, current 1024 x 768, maximum 7680 x 7680 HDMI-1 connected primary 1024x768+0+0 (normal left inverted right x axis y axis) 0mm x 0mm 1024x768 60.00* 800x600 60.32 56.25 848x480 60.00 640x480 59.94 == Think you are missing a build dependeny on the libxrandr2 library. If HAVE_XRANDR is not set at compile time, it always prints the message ( https://github.com/TigerVNC/tigervnc/blob/master/unix/x0vncserver/XDesktop.cxx#L182 )
