Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-07-07 Thread Jonas Smedegaard
Quoting Pirate Praveen (2019-07-07 12:53:22)
> [adding Jonas to cc]

Please don't Cc me personally: I receive bugreports!


> Hi Jonas,
> 
> Can you review it and merge if it is okay? Now that buster is out, I'd 
> like some of the packages that missed buster to be made available via 
> buster-backports.

Looking into it now...


 - Jonas


-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature


Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-07-07 Thread Pirate Praveen
[adding Jonas to cc]

On Fri, 21 Jun 2019 08:36:15 +0200 Xavier  wrote:
> Le 21/06/2019 à 06:04, Pirate Praveen a écrit :
> > 
> > 
> > On 2019, ജൂൺ 20 5:08:24 PM IST, Xavier  wrote:
> >> Hello,
> >>
> >> there is something wrong with your patch:
> >> W: node-terser source: binaries-have-file-conflict node-terser
> >> uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js
> >>
> >> Your link overrides a regular file
> > 
> > Only node-terser should include this file, uglifyjs.terser already depends 
> > on node-terser.
> 
> OK, since I don't understand why this source package has been split so
> (part of node-terser in uglifyjs.terser), I let uploaders fix this RC-bug.
> 
> 

Hi yadd,

I have updated the patch to remove conflicts.

https://salsa.debian.org/js-team/node-terser/commit/c175315f185282004753fec9d29a02daf4c0ba4a

Hi Jonas,

Can you review it and merge if it is okay? Now that buster is out, I'd
like some of the packages that missed buster to be made available via
buster-backports.

Thanks
Praveen



signature.asc
Description: OpenPGP digital signature


Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-07-07 Thread Pirate Praveen
[adding Jonas to cc]

On Fri, 21 Jun 2019 08:36:15 +0200 Xavier  wrote:
> Le 21/06/2019 à 06:04, Pirate Praveen a écrit :
> > 
> > 
> > On 2019, ജൂൺ 20 5:08:24 PM IST, Xavier  wrote:
> >> Hello,
> >>
> >> there is something wrong with your patch:
> >> W: node-terser source: binaries-have-file-conflict node-terser
> >> uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js
> >>
> >> Your link overrides a regular file
> > 
> > Only node-terser should include this file, uglifyjs.terser already depends 
> > on node-terser.
> 
> OK, since I don't understand why this source package has been split so
> (part of node-terser in uglifyjs.terser), I let uploaders fix this RC-bug.
> 
> 

Hi yadd,

I have updated the patch to remove conflicts.

https://salsa.debian.org/js-team/node-terser/commit/c175315f185282004753fec9d29a02daf4c0ba4a

Hi Jonas,

Can you review it and merge if it is okay? Now that buster is out, I'd
like some of the packages that missed buster to be made available via
buster-backports.

Thanks
Praveen



signature.asc
Description: OpenPGP digital signature


Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-07-07 Thread Pirate Praveen
[adding Jonas to cc]

On Fri, 21 Jun 2019 08:36:15 +0200 Xavier  wrote:
> Le 21/06/2019 à 06:04, Pirate Praveen a écrit :
> > 
> > 
> > On 2019, ജൂൺ 20 5:08:24 PM IST, Xavier  wrote:
> >> Hello,
> >>
> >> there is something wrong with your patch:
> >> W: node-terser source: binaries-have-file-conflict node-terser
> >> uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js
> >>
> >> Your link overrides a regular file
> > 
> > Only node-terser should include this file, uglifyjs.terser already depends 
> > on node-terser.
> 
> OK, since I don't understand why this source package has been split so
> (part of node-terser in uglifyjs.terser), I let uploaders fix this RC-bug.
> 
> 

Hi yadd,

I have updated the patch to remove conflicts.

https://salsa.debian.org/js-team/node-terser/commit/c175315f185282004753fec9d29a02daf4c0ba4a

Hi Jonas,

Can you review it and merge if it is okay? Now that buster is out, I'd
like some of the packages that missed buster to be made available via
buster-backports.

Thanks
Praveen



signature.asc
Description: OpenPGP digital signature


Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-06-21 Thread Xavier
Le 21/06/2019 à 06:04, Pirate Praveen a écrit :
> 
> 
> On 2019, ജൂൺ 20 5:08:24 PM IST, Xavier  wrote:
>> Hello,
>>
>> there is something wrong with your patch:
>> W: node-terser source: binaries-have-file-conflict node-terser
>> uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js
>>
>> Your link overrides a regular file
> 
> Only node-terser should include this file, uglifyjs.terser already depends on 
> node-terser.

OK, since I don't understand why this source package has been split so
(part of node-terser in uglifyjs.terser), I let uploaders fix this RC-bug.



Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-06-20 Thread Pirate Praveen



On 2019, ജൂൺ 20 5:08:24 PM IST, Xavier  wrote:
>Hello,
>
>there is something wrong with your patch:
>W: node-terser source: binaries-have-file-conflict node-terser
>uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js
>
>Your link overrides a regular file

Only node-terser should include this file, uglifyjs.terser already depends on 
node-terser.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-06-20 Thread Xavier
Hello,

there is something wrong with your patch:
W: node-terser source: binaries-have-file-conflict node-terser
uglifyjs.terser usr/lib/nodejs/terser/dist/bundle.js

Your link overrides a regular file



Bug#930618: node-terser does not install file mentioned in package.json's main field and fails Error: Cannot find module 'terser'

2019-06-16 Thread Pirate Praveen

Package: node-terser
version: 3.14.1-2
severity: grave
Control: tags -1 patch

pravi@andhaka:~/forge/debian/git/js-team/vue.js$ sudo apt install 
node-terser

[sudo] password for pravi:
Sorry, try again.
[sudo] password for pravi:
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
 node-terser
0 upgraded, 1 newly installed, 0 to remove and 1017 not upgraded.
Need to get 0 B/156 kB of archives.
After this operation, 919 kB of additional disk space will be used.
Selecting previously unselected package node-terser.
(Reading database ... 213014 files and directories currently installed.)
Preparing to unpack .../node-terser_3.14.1-2_all.deb ...
Unpacking node-terser (3.14.1-2) ...
Setting up node-terser (3.14.1-2) ...
pravi@andhaka:~/forge/debian/git/js-team/vue.js$ node -e 
"require('terser');"

internal/modules/cjs/loader.js:583
   throw err;
   ^

Error: Cannot find module 'terser'
   at Function.Module._resolveFilename 
(internal/modules/cjs/loader.js:581:15)

   at Function.Module._load (internal/modules/cjs/loader.js:507:25)
   at Module.require (internal/modules/cjs/loader.js:637:17)
   at require (internal/modules/cjs/helpers.js:22:18)
   at [eval]:1:1
   at Script.runInThisContext (vm.js:96:20)
   at Object.runInThisContext (vm.js:303:38)
   at Object. ([eval]-wrapper:6:22)
   at Module._compile (internal/modules/cjs/loader.js:689:30)
   at evalScript (internal/bootstrap/node.js:587:27)

In package.json, "main": "dist/bundle.js" is specified, which is not 
installed in the node module path.


/usr/share/javascript/terser/bundle.js should be linked to 
/usr/lib/nodejs/terser/dist/bundle.js and libjs-terser added to Depends 
of node-terser.


Patch: 
https://salsa.debian.org/js-team/node-terser/commit/78f0922edff4010c8b9789b3c2c5fe1397fceefe 
available in fix-main-path branch in salsa repo.