Bug#934925: remove debian/patches/unbundle-sip.patch to provide wx.siplib ?
On Fri, 16 Aug 2019, Yaroslav Halchenko wrote: Newer upstream version of fsleyes uses wx.siplib (ref: https://github.com/pauldmccarthy/fsleyes/issues/29) build of which is apparently stripped away from the package in Debian: https://salsa.debian.org/freewx-team/wxpython4.0/blob/master/debian/patches/unbundle-sip.patch with the name suggeting that it would have its own package but I failed to find it: > apt-cache search python wx sip > so I guess it never saw a life. Unfortunately patch also doesn't provide any other details/hints on why unbundling was needed and how was it handled. So I wondered if just it could be built/shipped along? wx.siplib is unbundled for multiple reasons: 1) It is Debian policy to not use bundled code, see [1]. 2) The wxPython distribution doesn't include all of the source code for sip, so it's not possible to build it. The upstream build process for wxPython downloads a precompiled binary from the internet which is not allowed in Debian. As far as how to address this I can think of a few options: 1) You can patch fsleyes to use the public sip module (provided by the python3-sip package) instead of the wx.siplib module. In other words, you would 'import sip' instead of 'import wx.siplib'. 2) I could try to look into providing some sort of wx.siplib wrapper around the public sip module. Scott [1] https://www.debian.org/doc/debian-policy/ch-source.html#convenience-copies-of-code
Bug#934925: remove debian/patches/unbundle-sip.patch to provide wx.siplib ?
Source: wxpython4.0 Version: 4.0.6+dfsg-1 Severity: normal Newer upstream version of fsleyes uses wx.siplib (ref: https://github.com/pauldmccarthy/fsleyes/issues/29) build of which is apparently stripped away from the package in Debian: https://salsa.debian.org/freewx-team/wxpython4.0/blob/master/debian/patches/unbundle-sip.patch with the name suggeting that it would have its own package but I failed to find it: > apt-cache search python wx sip > so I guess it never saw a life. Unfortunately patch also doesn't provide any other details/hints on why unbundling was needed and how was it handled. So I wondered if just it could be built/shipped along? Thanks in advance -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental'), (100, 'unstable-debug') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
