Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
On Sun, Sep 01, 2019 at 09:23:06AM -0700, Rob Savoury wrote: > Package: sponsorship-requests > dget -x > https://mentors.debian.net/debian/pool/main/v/vnstat/vnstat_2.4-0.1.dsc Hey Rob and Christian, the package looks good to me. I've uploaded it to delayed-3 in case Christian objects the upload. From what I understood he's fine with the NMU, but just in case. So Christian in case you object to this upload give me a short notice and I can cancel it within the next three days. Rob the "ITA" tag in the bug is a bit misleading in the sense that if you want to adopt someting (ITA - Intent To Adopt), you usually set yourself as the package maintainer in debian/control. I'm not sure what Christian is up to, but maybe it makes sense to move the package to https://salsa.debian.org/debian and have it group maintained. But that's up to Christian to decide. Sven
Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
Package: sponsorship-requests Severity: normal Control: retitle 935390 RFS: vnstat/2.4-0.1 [NMU] -- This package has been updated and is now passing Lintian, with thanks to Christian Göttsche (great that he is back in action!) for pointing out two small build issues. -- Dear mentors, I am looking for a sponsor for my package "vnstat" * Package name: vnstat Version : 2.4-0.1 Upstream Author : Teemu Toivola * URL : https://humdi.net/vnstat/ * License : GPL-2 * Vcs : https://salsa.debian.org/cgzones-guest/vnstat Section : net It builds those binary packages: vnstat - console-based network traffic monitor vnstati - image output support for vnStat To access further information about this package, please visit the following URL: https://mentors.debian.net/package/vnstat Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/v/vnstat/vnstat_2.4-0.1.dsc Changes since the last upload: * Non-maintainer upload * New upstream version 2.4 - Image output has been refactored since 1.x versions (Closes: #692330) - Single database file avoids issue with new interfaces (Closes: #749019) - There is no "--create" interface option in vnstat 2.x (Closes: #881811) - Daemon in 2.x handles operations for if-up/down events (Closes: #722534) - Daemon in 2.x automatically populates vnstat database (Closes: #668969) - Better handling of integer rollover in kernel traffic counters including auto-adjust of UpdateInterval based on MaxBandwidth (Closes: #804131) . * debian/ - control: bump to Standards version 4.4.0 and compat level 12 + add libsqlite3-dev build dependency (vnstat 2.x requirement) - patches/ + drop timeout patch (fixed upstream) and rebase pidfile/systemd patches + add systemd_man.diff to fix vnstatd man path due file move upstream - tests/ + remove loopback test due no "--create" option with vnstat 2.x + add fulltest using similar commands upstream uses for build tests - copyright: update entries for maintainers in debian/* files paragraph and change upstream email to the correct current address -- Regards, Rob Savoury
Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
Hi Sven, Teemu (vnstat dev) was kind enough to write me a lengthy and helpful commentary today on the situation relative vnstat. He pointed out various inconsistencies in the way I have presented the package (and also confusion from me sending two initial two emails, Teemu mentioned that policy says a new RFS should only come after the 21 days -- my apologies for being too quick on that without clear grasp of all the Debian policies). So I have removed the package from mentors and will work on gaining a fuller understanding of the correct way to package vnstat for Debian over the coming weeks. With the quite detailed analysis given me by Teemu, relative patches, possible closing of bugs (if a version v2.x moves into the Debian repositories) and tips about correct ways to make the package, there is much for me to learn! In any case, thank you again for your response and attention to my (unintended) slightly incorrect approach relative the intention of getting a newer vnstat into Debian repos. -Rob On 08/22/2019 03:10 AM, Rob Savoury wrote: > Hi Sven, > > Thanks for the reply. Spent the whole day (and evening!) doing my best > to go through all the necessary steps to learn how to create a reliable > first Debian package, but guess I'm not totally surprised it is not > quite correct somehow! > > In any case, along with the RFS another email sent was an "ITS: vnstat" > [1] due this package qualifying for salvaging. So my intent is actually > to move towards being maintainer of vnstat (starting out with sponsored > maintainership, of course). That was actually Teemu (the developer's) > suggestive prompt to me in an email yesterday (after I alerted him to a > minor cosmetic bug in vnstat and he alerted me to the situation of the > vnstat package in Debian apparently having a "MIA" maintainer). > > The very problem appears to be a one year lack of any sign of activity > from Christian relative this package, so that's why the ITS and RFS from > me today. My understanding is that a three week window is given for the > maintainer to respond to an ITS so we will see if Christian returns into > some communication about vnstat during that time. Until then, I'll keep > brushing up on my new learning with the whole complexity of the Debian > packaging process! > > Thanks, > Rob > > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935391 > > > On 08/22/2019 02:45 AM, Sven Hoexter wrote: >> On Thu, Aug 22, 2019 at 01:26:35AM -0700, Rob Savoury wrote: >> >> Hey Rob, >> >>> Changes since the last upload: >>> >>>* New upstream version 2.4 >>> . >>>* debian/patches/ >>>+ drop patch applied upstream (timeout for restart) >>>+ modify pidfile and systemd patches for new source files >>>* d/control: bump to std version 4.4.0 and add libsqlite3-dev BD (vnstat >>> 2.x) >> >> While I value the work, this is not properly packaged as an NMU. >> I uploaded the last NMU by Teemu because it made perfectly sense to upload >> those changes which were already implemented by Christian Göttsche. But >> Christian >> is still the maintainer of the package as far as I can tell. >> >> So would be nice to have an ACK from him if such kind of informal team >> uploads >> are ok. And beside of that NMUs which implement major version changes are >> mostly >> an exception. I would prefer either some team upload or some notice by >> Christian >> how he intents to handle this package. >> >> Sven >> >>
Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
Hi Sven, Thanks for the reply. Spent the whole day (and evening!) doing my best to go through all the necessary steps to learn how to create a reliable first Debian package, but guess I'm not totally surprised it is not quite correct somehow! In any case, along with the RFS another email sent was an "ITS: vnstat" [1] due this package qualifying for salvaging. So my intent is actually to move towards being maintainer of vnstat (starting out with sponsored maintainership, of course). That was actually Teemu (the developer's) suggestive prompt to me in an email yesterday (after I alerted him to a minor cosmetic bug in vnstat and he alerted me to the situation of the vnstat package in Debian apparently having a "MIA" maintainer). The very problem appears to be a one year lack of any sign of activity from Christian relative this package, so that's why the ITS and RFS from me today. My understanding is that a three week window is given for the maintainer to respond to an ITS so we will see if Christian returns into some communication about vnstat during that time. Until then, I'll keep brushing up on my new learning with the whole complexity of the Debian packaging process! Thanks, Rob [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935391 On 08/22/2019 02:45 AM, Sven Hoexter wrote: > On Thu, Aug 22, 2019 at 01:26:35AM -0700, Rob Savoury wrote: > > Hey Rob, > >> Changes since the last upload: >> >>* New upstream version 2.4 >> . >>* debian/patches/ >>+ drop patch applied upstream (timeout for restart) >>+ modify pidfile and systemd patches for new source files >>* d/control: bump to std version 4.4.0 and add libsqlite3-dev BD (vnstat >> 2.x) > > While I value the work, this is not properly packaged as an NMU. > I uploaded the last NMU by Teemu because it made perfectly sense to upload > those changes which were already implemented by Christian Göttsche. But > Christian > is still the maintainer of the package as far as I can tell. > > So would be nice to have an ACK from him if such kind of informal team uploads > are ok. And beside of that NMUs which implement major version changes are > mostly > an exception. I would prefer either some team upload or some notice by > Christian > how he intents to handle this package. > > Sven > >
Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
On Thu, Aug 22, 2019 at 01:26:35AM -0700, Rob Savoury wrote: Hey Rob, > Changes since the last upload: > >* New upstream version 2.4 > . >* debian/patches/ >+ drop patch applied upstream (timeout for restart) >+ modify pidfile and systemd patches for new source files >* d/control: bump to std version 4.4.0 and add libsqlite3-dev BD (vnstat > 2.x) While I value the work, this is not properly packaged as an NMU. I uploaded the last NMU by Teemu because it made perfectly sense to upload those changes which were already implemented by Christian Göttsche. But Christian is still the maintainer of the package as far as I can tell. So would be nice to have an ACK from him if such kind of informal team uploads are ok. And beside of that NMUs which implement major version changes are mostly an exception. I would prefer either some team upload or some notice by Christian how he intents to handle this package. Sven
Bug#935390: RFS: vnstat/2.4-1 [NMU] [ITA]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "vnstat" * Package name: vnstat Version : 2.4-1 Upstream Author : Teemu Toivola * URL : https://humdi.net/vnstat/ * License : GPL-2 * Vcs : https://salsa.debian.org/cgzones-guest/vnstat Section : net It builds those binary packages: vnstat - console-based network traffic monitor vnstati - image output support for vnStat To access further information about this package, please visit the following URL: https://mentors.debian.net/package/vnstat Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/v/vnstat/vnstat_2.4-1.dsc Changes since the last upload: * New upstream version 2.4 . * debian/patches/ + drop patch applied upstream (timeout for restart) + modify pidfile and systemd patches for new source files * d/control: bump to std version 4.4.0 and add libsqlite3-dev BD (vnstat 2.x) Regards, Rob Savoury
