Bug#939516: dpkg: debian/rules 'configure' rule does not always recreate configure file

2019-09-05 Thread Sven Joachim
Control: notfound -1 1.20.0
Control: found -1 1.19.7

On 2019-09-05 14:46 -0400, Dan Streetman wrote:

> Package: dpkg
> Version: 1.20.0

That version does not exist in Debian.

> Severity: normal
>
> Dear Maintainer,
>
> The debian/rules file has a manual rule for the 'configure' file, but this
> results in the 'configure' file not always being recreated.
>
> For example:
> $ head -1 debian/changelog
> dpkg (1.20.0) UNRELEASED; urgency=medium
> $ echo hello > configure
> $ chmod 755 configure
> $ dpkg-buildpackage
> ...
> ../configure: 1: hello: not found
>
> While that's a silly example, and unlikely to ever cause real issues for
> Debian since the Debian dpkg source doesn't carry the 'configure' file,
> the Ubuntu dpkg source *does* unfortunately carry the 'configure' file,
> and this caused a real regression:
> https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/1842947

The Debian dpkg source also includes the 'configure' file, only the git
repository does not have it.  That being said it would make sense to
always run autoreconf at package build time, I think that's considered
best practice these days.

Cheers,
   Sven



Bug#939516: dpkg: debian/rules 'configure' rule does not always recreate configure file

2019-09-05 Thread Dan Streetman
Package: dpkg
Version: 1.20.0
Severity: normal

Dear Maintainer,

The debian/rules file has a manual rule for the 'configure' file, but this
results in the 'configure' file not always being recreated.

For example:
$ head -1 debian/changelog 
dpkg (1.20.0) UNRELEASED; urgency=medium
$ echo hello > configure
$ chmod 755 configure
$ dpkg-buildpackage
...
../configure: 1: hello: not found

While that's a silly example, and unlikely to ever cause real issues for
Debian since the Debian dpkg source doesn't carry the 'configure' file,
the Ubuntu dpkg source *does* unfortunately carry the 'configure' file,
and this caused a real regression:
https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/1842947