Bug#942200: [Pkg-javascript-devel] Bug#942200: Bug#942200: Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-14 Thread Pirate Praveen 



On Mon, Oct 14, 2019 at 10:26, Xavier  wrote:
tsc has some problem to parse /usr/share. Try to add this module to 
debian/nodejs/extlinks


I think the problem is in node-rollup-pluginutils itself (rollup was 
showing Unresolved dependency error for micromatch), but when trying to 
add system paths to node-resolve plugin, the build fails with error,


Error: 'default' is not exported by 
../../../usr/share/nodejs/micromatch/index.js


So we should first fix node-rollup-pluginutils build (opened a bug 
against it). Please try if you can fix that.

Bug#942200: [Pkg-javascript-devel] Bug#942200: Bug#942200: Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-14 Thread Xavier 
tsc has some problem to parse /usr/share. Try to add this module to 
debian/nodejs/extlinks


Le 14 octobre 2019 09:43:31 GMT+02:00, Pirate Praveen 
 a écrit :
>
>
>On Sun, Oct 13, 2019 at 19:13, Xavier  wrote:
>> Thanks a lot for your work !
>> 
>
>You are welcome :)
>>> We'll need to update node-rollup-pluginutils to 2.6 and drop 
>>> src_babel generation as tsc can consume ES module directly. I'm 
>>> going to try this tomorrow.
>
>After updating node-rollup-pluginutils, I get
>
>../../../../../../../usr/share/nodejs/rollup-pluginutils/src/createFilter.ts:1:16
>
>- error TS2307: Cannot find module 'micromatch'.
>
>1 import mm from 'micromatch';
> 
>
>../../../../../../../usr/share/nodejs/rollup-pluginutils/src/extractAssignedNames.ts:1:22
>
>- error TS2307: Cannot find module 'estree-walker'.
>
>1 import { Node } from 'estree-walker';
>   ~~~
>
>I think we'll need to include the type definitions in these two 
>packages (or add them to node-typescript-types). I will try this now.

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma 
brièveté.

Bug#942200: [Pkg-javascript-devel] Bug#942200: Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-14 Thread Pirate Praveen 



On Sun, Oct 13, 2019 at 19:13, Xavier  wrote:

Thanks a lot for your work !



You are welcome :)
We'll need to update node-rollup-pluginutils to 2.6 and drop 
src_babel generation as tsc can consume ES module directly. I'm 
going to try this tomorrow.


After updating node-rollup-pluginutils, I get

../../../../../../../usr/share/nodejs/rollup-pluginutils/src/createFilter.ts:1:16 
- error TS2307: Cannot find module 'micromatch'.


1 import mm from 'micromatch';


../../../../../../../usr/share/nodejs/rollup-pluginutils/src/extractAssignedNames.ts:1:22 
- error TS2307: Cannot find module 'estree-walker'.


1 import { Node } from 'estree-walker';
  ~~~

I think we'll need to include the type definitions in these two 
packages (or add them to node-typescript-types). I will try this now.

Bug#942200: [Pkg-javascript-devel] Bug#942200: Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-13 Thread Xavier 
Thanks a lot for your work !

Le 13 octobre 2019 17:02:20 GMT+02:00, Pirate Praveen 
 a écrit :
>
>
>On Sun, Oct 13, 2019 at 20:15, Pirate Praveen 
> wrote:
>> This seems like a bug in rollup 1.0.2. Using with rollup 1.0.2 in 
>> package.json, npm i; npm run test also fails. Works fine with rollup 
>> 1.8.
>
>Now trying to update to 1.10.1 (which also works).
>
>Found debian/nodejs/./build
>   cd ./. && sh -e debian/nodejs/./build
>src/Module.ts:5:34 - error TS2307: Cannot find module 
>'rollup-pluginutils/src/extractAssignedNames'.
>
>5 import extractAssignedNames from 
>'rollup-pluginutils/src/extractAssignedNames';
>   
>~
>
>src/watch/index.ts:4:26 - error TS2307: Cannot find module 
>'rollup-pluginutils/src/createFilter'.
>
>4 import createFilter from 'rollup-pluginutils/src/createFilter';
>   ~
>
>
>Found 4 errors.
>
>We'll need to update node-rollup-pluginutils to 2.6 and drop src_babel 
>generation as tsc can consume ES module directly. I'm going to try this
>
>tomorrow.

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma 
brièveté.

Bug#942200: [Pkg-javascript-devel] Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-13 Thread Pirate Praveen 



On Sun, Oct 13, 2019 at 20:15, Pirate Praveen 
 wrote:
This seems like a bug in rollup 1.0.2. Using with rollup 1.0.2 in 
package.json, npm i; npm run test also fails. Works fine with rollup 
1.8.


Now trying to update to 1.10.1 (which also works).

Found debian/nodejs/./build
cd ./. && sh -e debian/nodejs/./build
src/Module.ts:5:34 - error TS2307: Cannot find module 
'rollup-pluginutils/src/extractAssignedNames'.


5 import extractAssignedNames from 
'rollup-pluginutils/src/extractAssignedNames';
  
~


src/watch/index.ts:4:26 - error TS2307: Cannot find module 
'rollup-pluginutils/src/createFilter'.


4 import createFilter from 'rollup-pluginutils/src/createFilter';
  ~


Found 4 errors.

We'll need to update node-rollup-pluginutils to 2.6 and drop src_babel 
generation as tsc can consume ES module directly. I'm going to try this 
tomorrow.

Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-13 Thread Pirate Praveen 


Control: reassign -1 rollup
Control: found -1 1.0.2-1
Control: retitle -1 rollup 1.0.2 creates broken bundle for node-d3

On Sun, Oct 13, 2019 at 16:48, Pirate Praveen 
 wrote:

On Sat, 12 Oct 2019 13:04:10 +0530 Pirate Praveen
mailto:prav...@onenetbeyond.org>> wrote:

 package: node-d3
 version: 4.13.0-10


With node-d3 5.12, build succeeds and one test fails,

# version matches package.json
ok 1 should be equal
# d3.event is a getter for d3Selection.event
ok 2 should be equal
not ok 3 should be equal
  ---
operator: equal
expected: 42
actual:   null
at: Test. (/<>/test/d3-test.js:15:10)
stack: |-
  Error: should be equal
  at Test.assert [as _assert]
(/usr/lib/nodejs/tape/lib/test.js:235:54)
  at Test.bound [as _assert]
(/usr/lib/nodejs/tape/lib/test.js:87:32)
  at Test.equal (/usr/lib/nodejs/tape/lib/test.js:395:10)
  at Test.bound [as equal] 
(/usr/lib/nodejs/tape/lib/test.js:87:32)

  at Test. (/<>/test/d3-test.js:15:10)
  at Test.bound [as _cb] 
(/usr/lib/nodejs/tape/lib/test.js:87:32)

  at Test.run (/usr/lib/nodejs/tape/lib/test.js:106:10)
  at Test.bound [as run] 
(/usr/lib/nodejs/tape/lib/test.js:87:32)

  at Immediate.next [as _onImmediate]
(/usr/lib/nodejs/tape/lib/results.js:71:15)
  at runCallback (timers.js:705:18)
  ...


This seems like a bug in rollup 1.0.2. Using with rollup 1.0.2 in 
package.json, npm i; npm run test also fails. Works fine with rollup 
1.8.

Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-13 Thread Pirate Praveen 
On Sat, 12 Oct 2019 13:04:10 +0530 Pirate Praveen
 wrote:
> package: node-d3
> version: 4.13.0-10

With node-d3 5.12, build succeeds and one test fails,

# version matches package.json
ok 1 should be equal
# d3.event is a getter for d3Selection.event
ok 2 should be equal
not ok 3 should be equal
  ---
operator: equal
expected: 42
actual:   null
at: Test. (/<>/test/d3-test.js:15:10)
stack: |-
  Error: should be equal
  at Test.assert [as _assert]
(/usr/lib/nodejs/tape/lib/test.js:235:54)
  at Test.bound [as _assert]
(/usr/lib/nodejs/tape/lib/test.js:87:32)
  at Test.equal (/usr/lib/nodejs/tape/lib/test.js:395:10)
  at Test.bound [as equal] (/usr/lib/nodejs/tape/lib/test.js:87:32)
  at Test. (/<>/test/d3-test.js:15:10)
  at Test.bound [as _cb] (/usr/lib/nodejs/tape/lib/test.js:87:32)
  at Test.run (/usr/lib/nodejs/tape/lib/test.js:106:10)
  at Test.bound [as run] (/usr/lib/nodejs/tape/lib/test.js:87:32)
  at Immediate.next [as _onImmediate]
(/usr/lib/nodejs/tape/lib/results.js:71:15)
  at runCallback (timers.js:705:18)
  ...

Bug#942200: rollup 1.0 transition: node-d3 built with rollup 1.0 gives error in test

2019-10-12 Thread Pirate Praveen 

package: node-d3
version: 4.13.0-10
severity: important

With rollup 1.0 in experimental, build trew some warning and test failed

Found debian/nodejs/./build
cd ./. && sh -e debian/nodejs/./build

index → build/d3.js...
(!) node-resolve plugin: The onwrite hook used by plugin node-resolve 
is deprecated. The generateBundle hook should be used instead.
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/select.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/selectAll.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/filter.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/data.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/data.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/enter.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/exit.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/merge.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-selection/src/selection/index.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/sort.js -> 
../../../usr/share/nodejs/d3-selection/src/selection/index.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-interpolate/src/value.js -> 
../../../usr/lib/nodejs/d3-interpolate/src/array.js -> 
../../../usr/lib/nodejs/d3-interpolate/src/value.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-interpolate/src/value.js -> 
../../../usr/lib/nodejs/d3-interpolate/src/object.js -> 
../../../usr/lib/nodejs/d3-interpolate/src/value.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-transition/src/transition/index.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/filter.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-transition/src/transition/index.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/merge.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-transition/src/transition/index.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/select.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-transition/src/transition/index.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/selectAll.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/index.js
(!) Circular dependency: 
../../../usr/share/nodejs/d3-transition/src/transition/index.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/transition.js -> 
../../../usr/share/nodejs/d3-transition/src/transition/index.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Beach.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Cell.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Edge.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Beach.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Cell.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Beach.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Circle.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js
(!) Circular dependency: 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Beach.js -> 
../../../usr/lib/nodejs/d3-voronoi/src/Diagram.js

created build/d3.js in 3.9s
  dh_auto_test --buildsystem=nodejs
/bin/sh -e debian/tests/pkg-js/test
/<>/build/d3.node.js:1
undefinedObject.defineProperty(exports, "event", {get: function() { 
return d3Selection.event; }});

^

ReferenceError: undefinedObject is not defined
   at Object. (/<>/build/d3.node.js:1:1)
   at Module._compile