Package: xen-tools
Version: 4.8-1
Severity: normal
Tags: patch
Dear Maintainer,
I have been using xen-create-image and LVM as the backing for the
disks for a long time. Now I have made a LVM ThinPool and was glad to
find support for that in xen-tools. However it fails to work due to
the name of the VG is specifed on the cmd-line for the lvcreate
command and it should not be that way when a ThinPool is used.
I have fixed the xen-create-image command on my machine and it works
with both regular LVM and LVM with ThinPool on my setup. See the patch
included in this report for the details on what I did.
-- System Information:
Debian Release: 10.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-6-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages xen-tools depends on:
ii debootstrap 1.0.114
ii libconfig-inifiles-perl 3.000001-1
ii libdata-validate-domain-perl 0.10-1
ii libdata-validate-ip-perl 0.27-1
ii libdata-validate-uri-perl 0.07-1
ii libfile-slurp-perl 9999.26-1
ii libfile-which-perl 1.23-1
ii libsort-versions-perl 1.62-1
ii libterm-ui-perl 0.46-1
ii libtext-template-perl 1.55-1
ii openssh-client 1:7.9p1-10+deb10u1
ii perl 5.28.1-6
Versions of packages xen-tools recommends:
ii debian-archive-keyring 2019.1
ii e2fsprogs 1.44.5-1+deb10u2
pn libexpect-perl <none>
ii lvm2 2.03.02-3
pn rinse <none>
ii ubuntu-keyring [ubuntu-archive-keyring] 2018.09.18.1-5
ii xen-hypervisor-4.11-amd64 [xen-hypervisor] 4.11.1+92-g6c33308a8d-2
ii xen-utils-4.11 [xen-utils] 4.11.1+92-g6c33308a8d-2
Versions of packages xen-tools suggests:
pn btrfs-progs | btrfs-tools <none>
pn cfengine2 <none>
ii grub-xen-host 2.02+dfsg1-20
pn reiserfsprogs <none>
pn xfsprogs <none>
-- Configuration Files:
/etc/xen-tools/xen-tools.conf changed [not included]
/etc/xen-tools/xm.tmpl changed [not included]
-- no debconf information
--- /usr/bin/xen-create-image~ 2019-02-09 01:56:51.000000000 +0100
+++ /usr/bin/xen-create-image 2019-10-12 21:33:07.000000000 +0200
@@ -3224,12 +3224,11 @@
# The commands to create the volume.
#
my $disk_cmd =
- "lvcreate $CONFIG{'lvm'} ".
- ($lvm_needs_yes ? '--yes' : '').
- ' '.
+ "lvcreate ".
+ ($lvm_needs_yes ? '--yes ' : '').
($CONFIG{ 'lvm_thin' } ?
"-T $CONFIG{'lvm'}/$CONFIG{'lvm_thin'} -V" :
- '-L').
+ "$CONFIG{'lvm'} -L").
" $partition->{'size'} -n $disk";
#
