Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
Hello Tobias, thanks for the Merge Request. I've just reviewed it and merged it. My understanding of arch/indep was not very clear, now it's better :) The reproducible issue is a bug in doxygen, similar to: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970431 It has been fixed upstream but not released yet: https://github.com/doxygen/doxygen/issues/8037 Minor question: you let the "export DH_VERBOSE=1" uncommented in d/rules file. I know it adds extra logging. Is it OK to keep it for the final upload? The package is uploaded at mentors. Could you please check that everything is fine and upload it to experimental? Thanks, François signature.asc Description: This is a digitally signed message part
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
On Mon, Oct 12, 2020 at 06:06:58PM +0200, Tobias Frost wrote: > > > > d/rules + d/control: > > > - It looks like as your rules already supports building docs in > > > build-indep. > > > Please see if you can move doxygen / graphviz B-D to Build-Depends- > > > Indep. > > > > Done > > I have problems building only the arch:all packages, but I will > need to investigate first if the problem is on my side. > (Running out of time right now) Following up on that one: No, it was not on my side… It was a combination of limited build system support for building only the documentation and more targets needs to be overriden in d/rules for -arch and -indep. It unearthed also a bug in the override for dh_auto_install-indep: The generated makefile does not have a doc target… I sent a MR towards you, which fixes this. The changes for this are: - include /usr/share/dpkg/architecture.mk to get DEB_HOST_GNU_TYPE - override override_dh_auto_configure-arch to only enable tests there. - override_dh_auto_build-indep: use DEB_HOST_GNU_TYPE to enter build dir and use $(MAKE) zipios_Documentation to create docs. (make docs wont work) - as make install is not working for docs only builds, override_dh_auto_install-indep simulating this. In the same MR, I remove the manpages: I just saw (when debugging above) that those are doxygen generated manpages and, franky, not very useful. (on top, they are leaking build paths) Another small fix: d/copyright does not needed to be mentioned in libzipios++-doc.install. Its picked up automatically. (so deleted the file) d/dirs is not needed, and can be deleted. I left it up to you to make nice d/changlog entries for those changes… Afterwards I guess we are ready to upload it. For subsequent uploads, you might want to take a look at: usr/share/doc/libzipios-dev/html/classzipios_1_1VirtualSeeker.html, why it has the buildpath in it. (lintian I-type tag) (This possibly fixes also the reproducible build issue) Cheers, -- tobi
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
On Fri, Oct 09, 2020 at 10:43:09PM +0200, François Mazen wrote: > Hello Tobias, > > thanks a lot for this valuable review! > > I did my best to update the packages. It's uploaded to mentors: > https://mentors.debian.net/package/zipios++/ > > Please note that the upstream applied some of my patches and they > released a new version (2.2.6). I've updated the package with this new > release. > > Comments inline below: > > > So, yes, sourceful upload of all r-depends it will be… And you > > likely will need > > to provide patches. (Luckily, those r-depends are just two: freecad > > and enigma) > > > > I've forked freecad and enigma in my salsa account and I'm working on > patches. > > > - On the dev package: > > It should not Conflict/Replaces, It should be Breaks/Replaces. > > Done > > > - On the library package: > > be a need for the Conflict/Replace, not even a Breaks/Replaces. > > Done > > > - On the docs package: > >This is a classic "package renaming" situation explained here: > >https://wiki.debian.org/RenamingPackages. > >So you will need a transistional package here as well. > >Or not renaming the -doc package. > > I've added a transitional package libzipios++-doc that depends on the > new one. > > d/docs: > > - don't install README.md > > > - NEWS should be installed as upstream changelog (see > > dh_installchangelogs) > > Done Thanks for fixing all that ^^ > > d/rules + d/control: > > - It looks like as your rules already supports building docs in > > build-indep. > > Please see if you can move doxygen / graphviz B-D to Build-Depends- > > Indep. > > Done I have problems building only the arch:all packages, but I will need to investigate first if the problem is on my side. (Running out of time right now) > > - The docs package has references to the old package: > > References removed. > > > BTW, it is _NOT_ recommended to replace the jsquery from doxygen. > > read /usr/share/doc/doxygen/README.jquery. > > No more replace, thanks for the documentation pointer. You can also drop the Depends on libjs-query ;-) > > - The dev package has the following files, which shoudln't be there: > > drwxr-xr-x root/root 0 2020-03-07 14:08 > > ./usr/share/doc/libzipios-doc/ > > -rw-r--r-- root/root 1654 2019-08-17 00:13 > > ./usr/share/doc/libzipios-doc/NEWS.gz > > -rw-r--r-- root/root 2352 2019-08-17 00:13 > > ./usr/share/doc/libzipios-doc/README.md.gz > > Files removed. > > > - The dev package isntalls the man pages. Shouldn't they go to the > > -doc package? > > Moved manpages to libzipios-doc.manpages > > > - d/rules: > > What was the problem with > > "# dh_installdocs does not detect the doc main package correctly."? > > By default, dh_installdocs installs the html documentation under > /usr/share/doc/libzipios-dev instead of /usr/share/doc/libzipios-doc > inside the libzipios-doc package. > > I can't figure out why. Any help is welcome! > For the moment the only solution I get is to override dh_installdocs. I think that is actually intended: The documentation should be installed to the libzios-dev folder. (Policy 12.3 suggests that, the paragraph saying: Additional documentation included in the package should be installed under /usr/share/doc/package. If the documentation is packaged separately, as package-doc for example, it may be installed under either that path or into the documentation directory for the separate documentation package (/usr/share/doc/package-doc in this example). > > - There is also dh_doxygen. > > Perfect tool! It removes md5 and map files, but it does not solve the > issue above. > > > - As per Policy 12.3, the -dev package should Suggest: the -doc > > package. > > Done > > Thanks, > François (Sorry for the incomplete review, ran out of time) -- tobi
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
Hello Tobias, thanks a lot for this valuable review! I did my best to update the packages. It's uploaded to mentors: https://mentors.debian.net/package/zipios++/ Please note that the upstream applied some of my patches and they released a new version (2.2.6). I've updated the package with this new release. Comments inline below: > So, yes, sourceful upload of all r-depends it will be… And you > likely will need > to provide patches. (Luckily, those r-depends are just two: freecad > and enigma) > I've forked freecad and enigma in my salsa account and I'm working on patches. > - On the dev package: > It should not Conflict/Replaces, It should be Breaks/Replaces. Done > - On the library package: > be a need for the Conflict/Replace, not even a Breaks/Replaces. Done > - On the docs package: >This is a classic "package renaming" situation explained here: >https://wiki.debian.org/RenamingPackages. >So you will need a transistional package here as well. >Or not renaming the -doc package. I've added a transitional package libzipios++-doc that depends on the new one. > d/docs: > - don't install README.md > - NEWS should be installed as upstream changelog (see > dh_installchangelogs) Done > d/rules + d/control: > - It looks like as your rules already supports building docs in > build-indep. > Please see if you can move doxygen / graphviz B-D to Build-Depends- > Indep. Done > - The docs package has references to the old package: References removed. > BTW, it is _NOT_ recommended to replace the jsquery from doxygen. > read /usr/share/doc/doxygen/README.jquery. No more replace, thanks for the documentation pointer. > - The dev package has the following files, which shoudln't be there: > drwxr-xr-x root/root 0 2020-03-07 14:08 > ./usr/share/doc/libzipios-doc/ > -rw-r--r-- root/root 1654 2019-08-17 00:13 > ./usr/share/doc/libzipios-doc/NEWS.gz > -rw-r--r-- root/root 2352 2019-08-17 00:13 > ./usr/share/doc/libzipios-doc/README.md.gz Files removed. > - The dev package isntalls the man pages. Shouldn't they go to the > -doc package? Moved manpages to libzipios-doc.manpages > - d/rules: > What was the problem with > "# dh_installdocs does not detect the doc main package correctly."? By default, dh_installdocs installs the html documentation under /usr/share/doc/libzipios-dev instead of /usr/share/doc/libzipios-doc inside the libzipios-doc package. I can't figure out why. Any help is welcome! For the moment the only solution I get is to override dh_installdocs. > - There is also dh_doxygen. Perfect tool! It removes md5 and map files, but it does not solve the issue above. > - As per Policy 12.3, the -dev package should Suggest: the -doc > package. Done Thanks, François signature.asc Description: This is a digitally signed message part
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
Control: tags -1 moreinfo On Wed, Sep 30, 2020 at 10:43:36PM +0200, François Mazen wrote: > Hello Tobias, > > > # please do not reopen new bugs if the old one was not sponsored. > > # -- otherwise context is lost. > > Sorry for the mess, I thought that I had to open a new sponsorship > request due to different package name. > > > You need to upload it to experimental first. > > Updated package ready to experimental at mentors: > https://mentors.debian.net/package/zipios++/ > > Could you please upload and review? d/control: - I'm seeing that the -dev package is now renamed. That will force you to do sourceful uploads of all the reverse dependencies during the transitions. Additionally, upstream includes changed directory names and lots of other changes that break API… So, yes, sourceful upload of all r-depends it will be… And you likely will need to provide patches. (Luckily, those r-depends are just two: freecad and enigma) TL;DR: its ok… - On the dev package: It should not Conflict/Replaces, It should be Breaks/Replaces. (see policy 7.4; you are moving a file from the old one to the new one.) (disclaimer: I'm 100% sure on that one, happy if someone could chime in) - On the library package: Here I'm pretty sure the conflict will do harm: it will make the transition harder. The binary library packages should be coinstallable with the old one, so there shouldn't be a need for the Conflict/Replace, not even a Breaks/Replaces. (The old one had one due to the c++-abi transition a few years ago, IIRC) (This is also not a package rename situation, as libraries are pulled in by reverse dependencies; and in contrast to renames, you don't want to uninstall the old one automatically: there might be packages (outside of the Debian archives) that still needs it,.) - On the docs package: This is a classic "package renaming" situation explained here: https://wiki.debian.org/RenamingPackages. So you will need a transistional package here as well. Or not renaming the -doc package. d/docs: - don't install README.md -- it does not have important information (mostly how to build, which is not relevant in binary packages) - NEWS should be installed as upstream changelog (see dh_installchangelogs) d/rules + d/control: - It looks like as your rules already supports building docs in build-indep. Please see if you can move doxygen / graphviz B-D to Build-Depends-Indep. (doxygen has a huge dependency list, so it is worth to do that) - The docs package has references to the old package: uilding the docs package shows in the package the following paths, I guess they are not updated: drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/ drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/html/ (...) lrwxrwxrwx root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/html/jquery.js -> ../../../javascript/jquery/jquery.min.js BTW, it is _NOT_ recommended to replace the jsquery from doxygen. read /usr/share/doc/doxygen/README.jquery. If lintian complains, override it. - The dev package has the following files, which shoudln't be there: drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios-doc/ -rw-r--r-- root/root 1654 2019-08-17 00:13 ./usr/share/doc/libzipios-doc/NEWS.gz -rw-r--r-- root/root 2352 2019-08-17 00:13 ./usr/share/doc/libzipios-doc/README.md.gz - The dev package isntalls the man pages. Shouldn't they go to the -doc package? (probably you just need to mv d/manpages d/libzipios-doc.manpages) - d/rules: What was the problem with "# dh_installdocs does not detect the doc main package correctly."? (Very often dh not working is not a problem with dh, but some packaging issue) Blindly guessing, it might be this: --doc-main-package is usually used to install the documentation to the _main_ binary package, not the main _doc_ package (see dh_installdocs). Policy 12.3 could be read to suggests to install the docs for a shared libary in /usr/share/doc/libzipios-dev (so the -doc package would ship the docs in this directory, but 1) that could be my reading and 2) its optional. This overrides could also be the reason for the spourious files mentioned above (-dev) - There is also dh_doxygen. Maybe this is helpful to avoid needing the overrides above. It should take care about those md5's. - As per Policy 12.3, the -dev package should Suggest: the -doc package. (I ran out of time here, so I can't analyze whats causes the problems above. Sorry for only pointing out the problems without providing pointers/solutions.) -- tobi signature.asc Description: PGP signature
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
Hello Tobias, > # please do not reopen new bugs if the old one was not sponsored. > # -- otherwise context is lost. Sorry for the mess, I thought that I had to open a new sponsorship request due to different package name. > You need to upload it to experimental first. Updated package ready to experimental at mentors: https://mentors.debian.net/package/zipios++/ Could you please upload and review? Thanks, François signature.asc Description: This is a digitally signed message part
Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
Control: reopen 942884 Control: forcemerge 942884 971395 Control: tags -1 moreinfo # please do not reopen new bugs if the old one was not sponsored. # -- otherwise context is lost. On Tue, Sep 29, 2020 at 10:17:31PM +0200, François Mazen wrote: > Changes since the last upload: > > zipios++ (2.2.5.0-1) unstable; urgency=high (...) . >* Rename library package from libzipios++0v5 to libzipios2 This starts a library transision: You need to upload it to experimental first. See: https://wiki.debian.org/Teams/ReleaseTeam/Transitions (Did not check the package otherwise) -- tobi
