Bug#943566: FTBFS with nettle 3.5.1

[peter green]

tags 943566 +patch
thanks


Currently the nettle 3.5.1 transition is going on. I tried to binNMU
your package but it fails to build from source on all architectures.


I had a fiddle around with the order of includes and this led me to some 
different error messages which led me to the real problem.

Utils.h includes  inside the pktannon namespace. This causes the 
sockaddr definition to be incorrectly placed in the pktannon namespace which causes 
problems later.

The fix is to move the include of  outside the namespace.

I then ran into a testsuite failure, it seems the testsuite needs ncat and 
tshark, initially I thought this may be extra tests activated by building as 
root, but it also seemed to happen when building as nobody. So I went ahead and 
added the build-dependencies, but I still had a bunch of test failures.

Looking back at the last succesful Debian build I noticed the testsuite was not 
being run on the autobuilders because runtest was not installed. However the 
chroot I was testing in did have runtest installed. I decided to go ahead and 
disable the testsuite and remove the extra build-depends I added.

I also extended the clean target to clean up some files that were left behind 
after said failed testsuite run. I have not checked if the same files are left 
behind by a successful testsuite run.

I have uploaded my fix to Raspbian, A debdiff should appear soon at 
https://debdiffs.raspbian.org/main/p/pktanon , no intent to NMU in Debian.

Bug#943566: FTBFS with nettle 3.5.1

[Paul Gevers]

Source: pktanon
Version: 2~git20160407.0.2bde4f2+dfsg-5
Severity: serious
Tags: ftbfs
Justification: ftbfs
Control: block 941150 by -1

Dear maintainer,

Currently the nettle 3.5.1 transition is going on. I tried to binNMU
your package but it fails to build from source on all architectures.

Paul

https://buildd.debian.org/status/package.php?p=pktanon

Tail of log for pktanon on amd64:

   65 |__SOCKADDR_ARG __addr, socklen_t *__restrict __addr_len)
  |   ^
In file included from RawSocketRecordsHandler.cpp:20:
/usr/include/net/if.h:90:12: note: class type ‘sockaddr’ is incomplete
   90 | struct sockaddr ifa_addr; /* Address of interface.  */
  |^~~~
g++ -DPACKAGE_NAME=\"pktanon\" -DPACKAGE_TARNAME=\"pktanon\"
-DPACKAGE_VERSION=\"2.0-beta\" -DPACKAGE_STRING=\"pktanon\ 2.0-beta\"
-DPACKAGE_BUGREPORT=\"bl...@kit.edu\" -DPACKAGE_URL=\"\"
-DPACKAGE=\"pktanon\" -DVERSION=\"2.0-beta\" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
-DHAVE_STDDEF_H=1 -DHAVE_CXX11=1 -DHAVE_SOCKET=1 -DHAVE_SYS_SOCKET_H=1
-DHAVE_ARPA_INET_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_NETINET_IN_H=1
-DHAVE_LINUX_IF_ETHER_H=1 -DHAVE_NETPACKET_PACKET_H=1 -DHAVE_NET_IF_H=1
-DHAVE_SYS_IOCTL_H=1 -DHAVE_FCNTL_H=1 -DHAVE_PCAP_PCAP_H=1 -I.  -O2
-pipe -Werror=return-type -I../include -g -DTRACE_ENABLED -DHAVE_LIBPCAP
-I../libpktanon -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat
-Werror=format-security -c -o SocketOutput.o SocketOutput.cpp
g++ -DPACKAGE_NAME=\"pktanon\" -DPACKAGE_TARNAME=\"pktanon\"
-DPACKAGE_VERSION=\"2.0-beta\" -DPACKAGE_STRING=\"pktanon\ 2.0-beta\"
-DPACKAGE_BUGREPORT=\"bl...@kit.edu\" -DPACKAGE_URL=\"\"
-DPACKAGE=\"pktanon\" -DVERSION=\"2.0-beta\" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
-DHAVE_STDDEF_H=1 -DHAVE_CXX11=1 -DHAVE_SOCKET=1 -DHAVE_SYS_SOCKET_H=1
-DHAVE_ARPA_INET_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_NETINET_IN_H=1
-DHAVE_LINUX_IF_ETHER_H=1 -DHAVE_NETPACKET_PACKET_H=1 -DHAVE_NET_IF_H=1
-DHAVE_SYS_IOCTL_H=1 -DHAVE_FCNTL_H=1 -DHAVE_PCAP_PCAP_H=1 -I.  -O2
-pipe -Werror=return-type -I../include -g -DTRACE_ENABLED -DHAVE_LIBPCAP
-I../libpktanon -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat
-Werror=format-security -c -o LibpcapRecordsHandler.o
LibpcapRecordsHandler.cpp
make[2]: *** [Makefile:446: RawSocketRecordsHandler.o] Error 1
make[2]: *** Waiting for unfinished jobs
make[2]: Leaving directory '/<>/src'
make[1]: *** [Makefile:487: all-recursive] Error 1
make[1]: Leaving directory '/<>'
dh_auto_build: make -j4 returned exit code 2
make: *** [debian/rules:18: build-arch] Error 255


- -- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.0-3-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled




signature.asc
Description: OpenPGP digital signature