Bug#943577: munin-plugins-core: sensors_ plugin unable to parse millivolt
Control: tags -1 +fixed-upstream Hello Andreas, Am Fri, 1 Nov 2019 08:37:42 +0100 schrieb Andreas Pommer : > > Please test, whether the changed plugin works for you. > > I tested the attached script. First, it resulted in several error messages. I > realized that in the first line of the script the '!' was missing, [..] oh - that was my manual mistake with the attachment :( The plugins in the repository use a substitution pattern. It is correct, there. > The 'volt1' line stayed there, it reported values below 1, and the output from > 'config' stayed stable as well. Fixed! great - thank you for testing! I just merged the change upstream. Cheers, Lars
Bug#943577: munin-plugins-core: sensors_ plugin unable to parse millivolt
Hello Lars, you wrote: [...] > I prepared a change to the sensors_ plugin, that should fix the issue: > https://github.com/munin-monitoring/munin/pull/1246 > I attached the changed plugin for your convenience and to avoid forcing you > into > a non-free service. > > Please test, whether the changed plugin works for you. I tested the attached script. First, it resulted in several error messages. I realized that in the first line of the script the '!' was missing, so the script was executed by the default shell instead of perl. After correcting this it worked as expected: # munin-run --servicedir . sensors_volt volt1.value 1.10 volt2.value 1.02 volt3.value 3.38 volt4.value 3.38 volt5.value 1.01 volt6.value 1.51 volt7.value 1.09 volt8.value 3.39 volt9.value 3.26 volt10.value 0.000 # munin-run --servicedir . sensors_volt volt1.value 0.88 volt2.value 1.02 volt3.value 3.38 volt4.value 3.38 volt5.value 1.01 volt6.value 1.51 volt7.value 1.09 volt8.value 3.39 volt9.value 3.26 volt10.value 0.000 The 'volt1' line stayed there, it reported values below 1, and the output from 'config' stayed stable as well. Fixed! thank you, Andreas
Bug#943577: munin-plugins-core: sensors_ plugin unable to parse millivolt
Hello Andreas, thank you for reporting this issue! I prepared a change to the sensors_ plugin, that should fix the issue: https://github.com/munin-monitoring/munin/pull/1246 I attached the changed plugin for your convenience and to avoid forcing you into a non-free service. Please test, whether the changed plugin works for you. > I suggest to use the -u switch when running the 'sensors' command, which > generates output that can be parsed more easily and with less risk of errors. This would be indeed much better. But the "sensors_" plugin was removed [1] from munin's master branch (to be released as munin 3.0). Thus I did not put the effort into improving the current plugin. Cheers, Lars [1] https://github.com/munin-monitoring/munin/commit/28db208a2da6f807c5322f5422fcfeba9850b5d8 sensors_ Description: Binary data
Bug#943577: munin-plugins-core: sensors_ plugin unable to parse millivolt
Package: munin-plugins-core Version: 2.0.51-1 Severity: normal Dear Maintainer, * What led up to the situation? Recently, in testing a new version of the sensors package showed up, and it seems that it slightly changed the output format of the 'sensors' command, so that the sensors_ munin plugin no longer parses it correctly. Sometimes, an output line of 'sensors' looks like this: Vcore: 1.02 V (min = +0.00 V, max = +1.74 V) and sensors_ parses it as before. However, sometimes, the same line looks like this: Vcore: 880.00 mV (min = +0.00 V, max = +1.74 V) and then the plugin fails to recognize the line, because it cannot deal with the m prefix. * What was the outcome of this action? Because of this, the sensors_volt output sometimes looks like this: volt1.value 1.10 volt2.value 1.02 volt3.value 3.38 volt4.value 3.38 volt5.value 1.01 volt6.value 1.51 volt7.value 1.09 volt8.value 3.39 volt9.value 3.26 volt10.value 0.000 and sometimes: volt1.value 1.02 volt2.value 3.38 volt3.value 3.38 volt4.value 1.01 volt5.value 1.51 volt6.value 1.09 volt7.value 3.39 volt8.value 3.26 volt9.value 0.000 What is actually missing in the second output is the first line. This means that all volt* values are renumbered, the association with the names from the 'config' output is broken, resulting in graphs where the lines are jumping up and down (as you can see in the example above, sometimes volt9 is 0 and sometimes 3.26). In other words, an unusable graph. I suggest to use the -u switch when running the 'sensors' command, which generates output that can be parsed more easily and with less risk of errors. -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=C.UTF-8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages munin-plugins-core depends on: ii munin-common 2.0.51-1 ii perl 5.30.0-8
