Bug#943874: pure-ftpd: pure-ftp error on upgrade

2021-01-22 Thread Stefan Hornburg (Racke)
On 1/18/21 11:55 PM, Andreas Beckmann wrote:
> Followup-For: Bug #943874
> Control: tag -1 patch pending
> 
> Hi,
> 
> I'm attaching a patch that tries to clean up the docdir symlink mess.
> The package is already uploaded to DELAYED/5.
> 
> 
> Andreas
> 

Thanks a lot for your fixes!

Regards
   Racke

-- 
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration. Provisioning with Ansible.



OpenPGP_signature
Description: OpenPGP digital signature


Bug#943874: pure-ftpd: pure-ftp error on upgrade

2021-01-18 Thread Andreas Beckmann
Followup-For: Bug #943874
Control: tag -1 patch pending

Hi,

I'm attaching a patch that tries to clean up the docdir symlink mess.
The package is already uploaded to DELAYED/5.


Andreas


pure-ftpd_1.0.49-4.1.dsc.diff.xz
Description: application/xz


Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-12-07 Thread Andreas Beckmann
Followup-For: Bug #943874

In sid pure-ftpd:amd64 ships

lrwxrwxrwx root/root 0 2019-10-30 17:37 ./usr/share/doc/pure-ftpd -> 
pure-ftpd-common

but pure-ftpd-common:all (which gets unpacked first) ships

drwxr-xr-x root/root 0 2019-10-30 17:37 ./usr/share/doc/pure-ftpd/
-rw-r--r-- root/root 12844 2019-10-30 17:37 ./usr/share/doc/pure-ftpd/FAQ.gz
-rw-r--r-- root/root  2090 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.Authentication-Modules.gz
-rw-r--r-- root/root  1124 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.Configuration-File
-rw-r--r-- root/root  4238 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.LDAP.gz
-rw-r--r-- root/root  1004 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.MacOS-X
-rw-r--r-- root/root  3684 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.MySQL.gz
-rw-r--r-- root/root  3312 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.PGSQL.gz
-rw-r--r-- root/root  5711 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.TLS.gz
-rw-r--r-- root/root  4497 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/README.Virtual-Users.gz
-rw-r--r-- root/root  4289 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/pure-ftpd.conf.gz
-rw-r--r-- root/root  2009 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/pureftpd-ldap.conf
-rw-r--r-- root/root  3455 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/pureftpd-mysql.conf
-rw-r--r-- root/root  2976 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/pureftpd-pgsql.conf
-rw-r--r-- root/root  2548 2019-10-30 17:37 
./usr/share/doc/pure-ftpd/pureftpd.schema
drwxr-xr-x root/root 0 2019-10-30 17:37 
./usr/share/doc/pure-ftpd-common/
-rw-r--r-- root/root  3493 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/AUTHORS.gz
-rw-r--r-- root/root  2245 2011-09-07 05:02 
./usr/share/doc/pure-ftpd-common/HISTORY
-rw-r--r-- root/root44 2019-03-25 15:48 
./usr/share/doc/pure-ftpd-common/NEWS.gz
-rw-r--r-- root/root  2090 2019-03-25 17:10 
./usr/share/doc/pure-ftpd-common/README.Authentication-Modules.gz
-rw-r--r-- root/root  1124 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/README.Configuration-File
-rw-r--r-- root/root  1311 2019-10-30 17:37 
./usr/share/doc/pure-ftpd-common/README.Debian
-rw-r--r-- root/root  2071 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/README.Donations.gz
-rw-r--r-- root/root  4238 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/README.LDAP.gz
-rw-r--r-- root/root  3684 2018-02-09 13:03 
./usr/share/doc/pure-ftpd-common/README.MySQL.gz
-rw-r--r-- root/root  3312 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/README.PGSQL.gz
-rw-r--r-- root/root  5711 2019-03-25 15:48 
./usr/share/doc/pure-ftpd-common/README.TLS.gz
-rw-r--r-- root/root  4497 2018-01-04 12:13 
./usr/share/doc/pure-ftpd-common/README.Virtual-Users.gz
-rw-r--r-- root/root 26547 2019-03-25 18:25 
./usr/share/doc/pure-ftpd-common/README.gz
-rw-r--r-- root/root  6561 2018-02-26 00:19 
./usr/share/doc/pure-ftpd-common/THANKS.gz
-rw-r--r-- root/root  7899 2019-10-30 17:37 
./usr/share/doc/pure-ftpd-common/changelog.Debian.gz
-rw-r--r-- root/root 36745 2019-04-03 11:01 
./usr/share/doc/pure-ftpd-common/changelog.gz
-rw-r--r-- root/root  1463 2019-10-30 17:37 
./usr/share/doc/pure-ftpd-common/copyright
-rw-r--r-- root/root  2548 2011-09-07 05:02 
./usr/share/doc/pure-ftpd-common/pureftpd.schema

Note the duplication of some README files.

As a result there is no /usr/share/doc/pure-ftpd/copyright, which is a policy
violation on its own.

It is bad practice to have -doc symlinks from arch:any to arch:all packages.

Andreas



Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-25 Thread Andreas Beckmann
Followup-For: Bug #943874

I can also reproduce this in piuparts in upgrades from buster to
bullseye/sid.

  Unpacking pure-ftpd-common (1.0.49-1) over (1.0.47-3) ...
  dpkg: error processing archive 
/tmp/apt-dpkg-install-DSFTxC/9-pure-ftpd-common_1.0.49-1_all.deb (--unpack):
   unable to install new version of 
'/usr/share/doc/pure-ftpd-common/README.Authentication-Modules.gz': No such 
file or directory
  Errors were encountered while processing:
   /tmp/apt-dpkg-install-DSFTxC/9-pure-ftpd-common_1.0.49-1_all.deb

In buster you have

lrwxrwxrwx 1 root root  16 Jan 28  2019 /usr/share/doc/pure-ftpd -> 
pure-ftpd-common
drwxr-xr-x 2 root root 420 Nov 25 20:28 /usr/share/doc/pure-ftpd-common

in sid you have

drwxr-xr-x 2 root root 320 Nov 25 20:30 /usr/share/doc/pure-ftpd
drwxr-xr-x 2 root root 400 Nov 25 20:30 /usr/share/doc/pure-ftpd-common

So there is something not working with the symlink to directory
conversion, although the error is different than in the other cases
of unhandled symlink to directory conversion I encountered.
Quoting the corresponding piuparts bug template:

Subject: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

Hi,

an upgrade test with piuparts revealed that your package installs files
over existing symlinks and possibly overwrites files owned by other
packages. This usually means an old version of the package shipped a
symlink but that was later replaced by a real (and non-empty)
directory. This kind of overwriting another package's files cannot be
detected by dpkg.

This was observed on the following upgrade paths:


For /usr/share/doc/PACKAGE this may not be problematic as long as both
packages are installed, ship byte-for-byte identical files and are
upgraded in lockstep. But once one of the involved packages gets
removed, the other one will lose its documentation files, too,
including the copyright file, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#copyright-information

For other overwritten locations anything interesting may happen.

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-unpack-phase-of-installation-or-upgrade

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


Andreas


pure-ftpd_1.0.49-1.log.gz
Description: application/gzip


Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-09 Thread Stefan Hornburg (Racke)
On 11/7/19 10:46 PM, Guy Geens wrote:
> Hello
> 
> I also encountered this error.
> 
> As far as I can see, the documentation (/usr/share/doc/pure-ftp) is
> included in both pure-ftp and pure-ftp-common packages.
> 

Hello,

the build procedure for pure-ftpd is quite complex (different flavours for 
SQL+LDAP, virtualchroot).
It hasn't changed since last release, but apparently the build tools behave 
differently. I'm going
to try to fix the build soon.

Regards
Racke

-- 
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration. Provisioning with Ansible.



signature.asc
Description: OpenPGP digital signature


Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-07 Thread Guy Geens
Hello

I also encountered this error.

As far as I can see, the documentation (/usr/share/doc/pure-ftp) is
included in both pure-ftp and pure-ftp-common packages.



Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-01 Thread Antonio
it could be a problem of mutual interaction created by a package that
removes the directory while the other tries to write a file on the
same path. If so, it would be a case not managed during the update
process...

Il giorno ven 1 nov 2019 alle ore 07:12 Stefan Hornburg (Racke)
 ha scritto:
>
> On 10/31/19 8:54 AM, Antonio wrote:
> > Package: pure-ftpd
> > Version: 1.0.49-1
> > Severity: important
> >
> > Dear Maintainer,
> > there is an error on pure-ftpd-common package when I try to upgrade pure-ftp
> >
> > Preparativi per estrarre .../pure-ftpd-common_1.0.49-1_all.deb...
> > Estrazione di pure-ftpd-common (1.0.49-1) su (1.0.47-3)...
> > dpkg: errore nell'elaborare l'archivio /var/cache/apt/archives/pure-ftpd-
> > common_1.0.49-1_all.deb (--unpack):
> >  impossibile aprire "/usr/share/doc/pure-ftpd-common/README.Authentication-
> > Modules.gz.dpkg-new": File o directory non esistente
> > Si sono verificati degli errori nell'elaborazione:
> >  /var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb
> > E: Sub-process /usr/bin/dpkg returned an error code (1)
> >
> > Thanks,
> > Antonio
> >
>
> Hello Antonio,
>
> I can reproduce the problem but can't explain why it happens.
> Thanks for the report.
>
> Regards
>  Racke
>
>
> --
> Ecommerce and Linux consulting + Perl and web application programming.
> Debian and Sympa administration. Provisioning with Ansible.
>



Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-01 Thread Antonio
Hi Stefan,
I bypassed the problem this way:

# remove previous doc directories:
root@TONY:~/desktop$ rm -rf /usr/share/doc/pure-ftpd-common/
/usr/share/doc/pure-ftpd/

# reinstall packages:
root@TONY:~/desktop$ apt-get install pure-ftpd pure-ftpd-common

Preparativi per estrarre .../pure-ftpd-common_1.0.49-1_all.deb...
Estrazione di pure-ftpd-common (1.0.49-1) su (1.0.47-3)...
 errore nell'elaborare l'archivio
/var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb (--install):
 tentata sovrascrittura di "/usr/share/doc/pure-ftpd" presente anche
nel pacchetto pure-ftpd 1.0.49-1
dpkg-deb: errore: il sottoprocesso paste รจ stato terminato dal segnale
(Pipe interrotta)
Si sono verificati degli errori nell'elaborazione:
 /var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb

# force overwrite
 root@TONY:~/desktop$ dpkg -i --force-overwrite
/var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb

Configurazione di pure-ftpd-common (1.0.49-1)...

File di configurazione "/etc/pure-ftpd/pure-ftpd.conf"
 ==> Modificato (dall'utente o da uno script) dopo l'installazione.
 ==> Il distributore del pacchetto ha fornito una versione aggiornata.
   Come procedere? Le opzioni sono:
Y o I   : installa la versione del responsabile del pacchetto
N od O  : mantiene la versione attualmente installata
  D : mostra le differenze tra le versioni
  Z : avvia una shell per esaminare la situazione
 L'azione predefinita consiste nel mantenere la versione attuale.
*** pure-ftpd.conf (Y/I/N/O/D/Z) [predefinito=N] ? N
Elaborazione dei trigger per man-db (2.9.0-1)...

# now is updated
root@TONY:~/desktop$ apt-cache policy pure-ftpd pure-ftpd-common
pure-ftpd:
  Installato: 1.0.49-1
  Candidato:  1.0.49-1
  Tabella versione:
 *** 1.0.49-1 700
700 http://debian.fastweb.it/debian sid/main amd64 Packages
100 /var/lib/dpkg/status
 1.0.47-3 500
500 http://debian.fastweb.it/debian stable/main amd64 Packages
pure-ftpd-common:
  Installato: 1.0.49-1
  Candidato:  1.0.49-1
  Tabella versione:
 *** 1.0.49-1 700
700 http://debian.fastweb.it/debian sid/main amd64 Packages
700 http://debian.fastweb.it/debian sid/main i386 Packages
100 /var/lib/dpkg/status
 1.0.47-3 500
500 http://debian.fastweb.it/debian stable/main amd64 Packages
500 http://debian.fastweb.it/debian stable/main i386 Packages

# test
root@TONY:~/desktop$ systemctl restart pure-ftpd
root@TONY:~/desktop$ ftp 127.0.0.1
Connected to 127.0.0.1.
220-- Welcome to Pure-FTPd [privsep] [TLS] --
220-You are user number 1 of 50 allowed.
220-Local time is now 09:15. Server port: 21.
220-This is a private system - No anonymous login
220-IPv6 connections are also welcome on this server.
220 You will be disconnected after 15 minutes of inactivity.
Name (127.0.0.1:root):


Il giorno ven 1 nov 2019 alle ore 07:12 Stefan Hornburg (Racke)
 ha scritto:
>
> On 10/31/19 8:54 AM, Antonio wrote:
> > Package: pure-ftpd
> > Version: 1.0.49-1
> > Severity: important
> >
> > Dear Maintainer,
> > there is an error on pure-ftpd-common package when I try to upgrade pure-ftp
> >
> > Preparativi per estrarre .../pure-ftpd-common_1.0.49-1_all.deb...
> > Estrazione di pure-ftpd-common (1.0.49-1) su (1.0.47-3)...
> > dpkg: errore nell'elaborare l'archivio /var/cache/apt/archives/pure-ftpd-
> > common_1.0.49-1_all.deb (--unpack):
> >  impossibile aprire "/usr/share/doc/pure-ftpd-common/README.Authentication-
> > Modules.gz.dpkg-new": File o directory non esistente
> > Si sono verificati degli errori nell'elaborazione:
> >  /var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb
> > E: Sub-process /usr/bin/dpkg returned an error code (1)
> >
> > Thanks,
> > Antonio
> >
>
> Hello Antonio,
>
> I can reproduce the problem but can't explain why it happens.
> Thanks for the report.
>
> Regards
>  Racke
>
>
> --
> Ecommerce and Linux consulting + Perl and web application programming.
> Debian and Sympa administration. Provisioning with Ansible.
>



Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-11-01 Thread Stefan Hornburg (Racke)
On 10/31/19 8:54 AM, Antonio wrote:
> Package: pure-ftpd
> Version: 1.0.49-1
> Severity: important
> 
> Dear Maintainer,
> there is an error on pure-ftpd-common package when I try to upgrade pure-ftp
> 
> Preparativi per estrarre .../pure-ftpd-common_1.0.49-1_all.deb...
> Estrazione di pure-ftpd-common (1.0.49-1) su (1.0.47-3)...
> dpkg: errore nell'elaborare l'archivio /var/cache/apt/archives/pure-ftpd-
> common_1.0.49-1_all.deb (--unpack):
>  impossibile aprire "/usr/share/doc/pure-ftpd-common/README.Authentication-
> Modules.gz.dpkg-new": File o directory non esistente
> Si sono verificati degli errori nell'elaborazione:
>  /var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)
> 
> Thanks,
> Antonio
> 

Hello Antonio,

I can reproduce the problem but can't explain why it happens.
Thanks for the report.

Regards
 Racke


-- 
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration. Provisioning with Ansible.



signature.asc
Description: OpenPGP digital signature


Bug#943874: pure-ftpd: pure-ftp error on upgrade

2019-10-31 Thread Antonio
Package: pure-ftpd
Version: 1.0.49-1
Severity: important

Dear Maintainer,
there is an error on pure-ftpd-common package when I try to upgrade pure-ftp

Preparativi per estrarre .../pure-ftpd-common_1.0.49-1_all.deb...
Estrazione di pure-ftpd-common (1.0.49-1) su (1.0.47-3)...
dpkg: errore nell'elaborare l'archivio /var/cache/apt/archives/pure-ftpd-
common_1.0.49-1_all.deb (--unpack):
 impossibile aprire "/usr/share/doc/pure-ftpd-common/README.Authentication-
Modules.gz.dpkg-new": File o directory non esistente
Si sono verificati degli errori nell'elaborazione:
 /var/cache/apt/archives/pure-ftpd-common_1.0.49-1_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

Thanks,
Antonio