Bug#944785: pufferfish wants to link with twopaco and ntcard
Hi Andreas, On 2022-10-04 12:54, Andreas Tille wrote: Am Tue, Oct 04, 2022 at 10:38:01AM +0300 schrieb Andrius Merkys: Alas, I did not get far. Static libraries for ntcard and twopaco are easy to add (I have pushed 'static-library' branches to salsa for these packages). However, pufferfish has patched main() functions of ntcard and twopaco executables in order to use them in internal calls. This sounds like you should keep the code copies (which was your initial strategy anyway if I remember correctly). At this point I do not think much can be done without getting the upstreams of pufferfish, ntcard and twopaco to align their interfaces. IMHO we need some fast migration path of pufferfish into Debian to get salmon fixed / updated. I do not have the feeling that aligning upstreams is a promising way to be fast. Agree. I would suggest bringing back the embedded twopaco and ntcard for now, launching upstream alignment in the background. Best, Andrius
Bug#944785: pufferfish wants to link with twopaco and ntcard
Hi Andrius, Am Tue, Oct 04, 2022 at 10:38:01AM +0300 schrieb Andrius Merkys: > On 2022-10-03 18:32, Andreas Tille wrote: > > My main motivation to start ntcard and twopaco packages was to avoid > > code duplication in pufferfish. I admit it seems I faild in doing this > > sensibly to forget creating a library package. Simply do whatever > > brings you forward with pufferfish and fix what I failed to do. > > Thanks for replies, Andreas and Steffen! > > Alas, I did not get far. Static libraries for ntcard and twopaco are > easy to add (I have pushed 'static-library' branches to salsa for these > packages). However, pufferfish has patched main() functions of ntcard > and twopaco executables in order to use them in internal calls. This sounds like you should keep the code copies (which was your initial strategy anyway if I remember correctly). > At this point I do not think much can be done without getting the > upstreams of pufferfish, ntcard and twopaco to align their interfaces. IMHO we need some fast migration path of pufferfish into Debian to get salmon fixed / updated. I do not have the feeling that aligning upstreams is a promising way to be fast. Kind regards Andreas. -- http://fam-tille.de
Bug#944785: pufferfish wants to link with twopaco and ntcard
Hi, On 2022-10-03 18:32, Andreas Tille wrote: > My main motivation to start ntcard and twopaco packages was to avoid > code duplication in pufferfish. I admit it seems I faild in doing this > sensibly to forget creating a library package. Simply do whatever > brings you forward with pufferfish and fix what I failed to do. Thanks for replies, Andreas and Steffen! Alas, I did not get far. Static libraries for ntcard and twopaco are easy to add (I have pushed 'static-library' branches to salsa for these packages). However, pufferfish has patched main() functions of ntcard and twopaco executables in order to use them in internal calls. At this point I do not think much can be done without getting the upstreams of pufferfish, ntcard and twopaco to align their interfaces. Best, Andrius
Bug#944785: pufferfish wants to link with twopaco and ntcard
Hi Andrius, Am Mon, Oct 03, 2022 at 10:19:41AM +0300 schrieb Andrius Merkys: > twopaco has entered testing (yay!), thus I gave its reverse dependency, > pufferfish (ITP bug #944785), a look. pufferfish carries embedded copies > of twopaco and ntcard with a modified build system to create static (or > is it shared?) libraries for these two and then links pufferfish with > them. For Debian twopaco and ntcard have been un-embedded from > pufferfish and packaged as separate binary packages instead. However, > they do not build neither shared nor static libraries, just executables. > > I think we can get around by patching twopaco and ntcard builds to > include static libraries in their binary packages. Does this sound right? My main motivation to start ntcard and twopaco packages was to avoid code duplication in pufferfish. I admit it seems I faild in doing this sensibly to forget creating a library package. Simply do whatever brings you forward with pufferfish and fix what I failed to do. Kind regards Andreas. -- http://fam-tille.de
Bug#944785: pufferfish wants to link with twopaco and ntcard
Hello, twopaco has entered testing (yay!), thus I gave its reverse dependency, pufferfish (ITP bug #944785), a look. pufferfish carries embedded copies of twopaco and ntcard with a modified build system to create static (or is it shared?) libraries for these two and then links pufferfish with them. For Debian twopaco and ntcard have been un-embedded from pufferfish and packaged as separate binary packages instead. However, they do not build neither shared nor static libraries, just executables. I think we can get around by patching twopaco and ntcard builds to include static libraries in their binary packages. Does this sound right? Best, Andrius
