Bug#945276: lintian: broken pattern matching in debian/source/lintian-overrides

2019-11-22 Thread Chris Lamb
Martin Pitt wrote:

[…]
> But these overrides now stopped working:
[…]

Without looking into too much detail, are the following the same issue?

  https://bugs.debian.org/945276
  https://bugs.debian.org/945299


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-



Bug#945276: lintian: broken pattern matching in debian/source/lintian-overrides

2019-11-22 Thread Martin Pitt
Package: lintian
Severity: important
Version: 2.36.0

Hello,

The cockpit package is a web application that ships some node_modules/ and the
generated webpacks from the source. This triggers a lot of lintian errors,
which are overridden [1] with 

# node_modules ship pre-minified *.min.js alongside *.js
cockpit source: source-is-missing node_modules/*
# compiled translations can get rather long
cockpit source: source-is-missing dist/static/*po.*.html*
# dist/ is (pre-)built by webpack from pkg/ and node_modules, see 
webpack.config.js
cockpit source: source-is-missing dist/*.js*

As far as  I can see, this is still the currently documented syntax [2], and I
don't see anything related to this in the recent lintian changelog.

But these overrides now stopped working:

  apt-get source -d cockpit
  lintian --no-tag-display-limit cockpit_207-1.dsc

results in tons of complaints like

   E: cockpit source: source-is-missing dist/static/login.po.ja.html line 
length is 520 characters (>512)
   E: cockpit source: source-is-missing node_modules/redux/dist/redux.min.js   

This was still working up to lintian 2.32.0, but it fails with 2.36.0 and
2.37.0.

What does work is to simplify the overrides to

cockpit source: source-is-missing

But that's too big of a hammer -- I do want to keep the check for the real
source (src/, pkg/, etc.), just not for the pre-built bits.

Thanks,

Martin

[1] 
https://salsa.debian.org/utopia-team/cockpit/blob/master/debian/source/lintian-overrides
[2] https://lintian.debian.org/manual/section-2.4.html