Bug#947334: [pkg-lxc-devel] Bug#947334: lxc-checkpoint needs the criu package
Hi, On Thu, Nov 30, 2023 at 01:06:42AM +, Mathias Gibbens wrote: > On Wed, 2023-11-29 at 21:22 +0100, Salvatore Bonaccorso wrote: > > On Sat, Nov 25, 2023 at 02:30:42PM +, Mathias Gibbens wrote: > > > On Fri, 2023-11-24 at 11:37 +0100, Pierre-Elliott Bécue wrote: > > > > Historically it was only in experimental, so I couldn't act upon > > > > this bug. > > > > > > > > Now we can. I'd either add it as a Depends or as a Recommends. > > > > > > I don't think criu should be in Depends, as checkpointing/live > > > migration of containers seems to be a less common use case, and the > > > lxc package has been working fine in Debian for many years without > > > it. I put it as a Suggests, since it does enhance the capability of > > > lxc, but users who don't explicitly need CRIU won't be missing out > > > on any functionality if they don't have it installed. However, I'll > > > defer to group consensus on where exactly to list the criu packge > > > for lxc. > > > > Suggests make sense. > > > > Note I have to resolve an issue with criu currently and is pending > > autoremoval from testing. > > OK, for now I'll do an upload with criu in Suggests; we can easily > change that if desired in a future upload. Many thanks! Thanks for all your work on the lxc package. Regards, Salvatore
Bug#947334: [pkg-lxc-devel] Bug#947334: lxc-checkpoint needs the criu package
On Wed, 2023-11-29 at 21:22 +0100, Salvatore Bonaccorso wrote: > On Sat, Nov 25, 2023 at 02:30:42PM +, Mathias Gibbens wrote: > > On Fri, 2023-11-24 at 11:37 +0100, Pierre-Elliott Bécue wrote: > > > Historically it was only in experimental, so I couldn't act upon > > > this bug. > > > > > > Now we can. I'd either add it as a Depends or as a Recommends. > > > > I don't think criu should be in Depends, as checkpointing/live > > migration of containers seems to be a less common use case, and the > > lxc package has been working fine in Debian for many years without > > it. I put it as a Suggests, since it does enhance the capability of > > lxc, but users who don't explicitly need CRIU won't be missing out > > on any functionality if they don't have it installed. However, I'll > > defer to group consensus on where exactly to list the criu packge > > for lxc. > > Suggests make sense. > > Note I have to resolve an issue with criu currently and is pending > autoremoval from testing. OK, for now I'll do an upload with criu in Suggests; we can easily change that if desired in a future upload. Mathias signature.asc Description: This is a digitally signed message part
Bug#947334: [pkg-lxc-devel] Bug#947334: lxc-checkpoint needs the criu package
Mathias Gibbens wrote on 23/11/2023 at 21:53:54+0100: > Control: tags -1 + pending > > I think it's reasonable to Suggest criu in the bin:lxc package. If > anyone has a strong opinion that it should rather be a Recommends, > please let me know. Historically it was only in experimental, so I couldn't act upon this bug. Now we can. I'd either add it as a Depends or as a Recommends. I was expecting to do a full sweep on the packages I maintain soon, so if you wish I can take care of that at that time. If you want to do a release before, feel free to. :) Cheers! -- PEB signature.asc Description: PGP signature