Bug#948393: foxtrotgps: fails to connect to gpsd despite SUCCESS message
Hi,
so actually there was an API change, and ABI change.. and nothing was
noted in NEWS, just well hidden instead :(
Patch to make it build is attached.
Best regards,
Bernd
--
Bernd ZeimetzDebian GNU/Linux Developer
http://bzed.dehttp://www.debian.org
GPG Fingerprint: ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F
>From da6fde7b1185ae6b1e62d4879fc338f10f26de22 Mon Sep 17 00:00:00 2001
From: Bernd Zeimetz
Date: Tue, 14 Jan 2020 23:17:12 +0100
Subject: [PATCH] Add compatibility for gps.h API 9
Note: this ignores millisecond resolution.
---
src/gps_functions.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gps_functions.c b/src/gps_functions.c
index c3dd201..3c85df7 100644
--- a/src/gps_functions.c
+++ b/src/gps_functions.c
@@ -753,7 +753,11 @@ cb_gpsd_data(GIOChannel *src, GIOCondition condition, gpointer data)
{
gpsdata->satellites_used = libgps_gpsdata.satellites_used;
gpsdata->hdop = libgps_gpsdata.dop.hdop;
+#if GPSD_API_MAJOR_VERSION >= 9
+ gpsdata->fix.time = libgps_gpsdata.fix.time.tv_sec;
+#else
gpsdata->fix.time = libgps_gpsdata.fix.time;
+#endif
if (isnan(gpsdata->fix.time))
{
gpsdata->fix.time = (time_t) 0;
--
2.25.0.rc2
Bug#948393: foxtrotgps: fails to connect to gpsd despite SUCCESS message
Hi, On 2020-01-08 04:18, Dan Chokola wrote: I suspect the error message in #948388 is telling: error:vehicle_gpsd:vehicle_gpsd_try_open:Warning: gps_fd is 0, most likely you have used a gps.h incompatible to libgps hmm, this error message does not come from libgps. It seems foxtrot was built against a different libgps binary. It's also why I got the idea to write the quick C program in #948388, which returns a nonzero fd. Please try to rebuild it as pabs suggested and see what happens. There are no ABI/API changes recorded, but that doesn't say that it did not happen. Especially the gps_data_t struct did not change, so gps_fd should still be at the same position. But: imho there is no reason to look at that fd at all. Just because you connect to a gpsd with gps_open does not mean that there is a gps device connected to gpsd. Using this is also not documented (and: afaik was never). So the other test would be to remove this gps_fd check and see if it just works... Bernd -- Bernd ZeimetzDebian GNU/Linux Developer http://bzed.dehttp://www.debian.org GPG Fingerprint: ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F
Bug#948393: foxtrotgps: fails to connect to gpsd despite SUCCESS message
On Wed, 08 Jan 2020 11:02:02 +0800 Paul Wise wrote: > On Tue, 2020-01-07 at 21:45 -0500, Daniel Peter Chokola wrote: > > > Foxtrotgps fails to connect to gpsd, but other clients work. Console > > prints: 'connection to gpsd SUCCEEDED' but gps data is dever > > displayed. A build of 1.2.2 from source works fine. I suspect the > > build got out of step with libgps. See also #948388. > > I don't have a GPS device in order to test this. I'm CCing the gpsd > maintainer Bernd Zeimetz in order to find out why a rebuild would fix > the issue. Any ideas? I suspect the error message in #948388 is telling: error:vehicle_gpsd:vehicle_gpsd_try_open:Warning: gps_fd is 0, most likely you have used a gps.h incompatible to libgps It seems foxtrot was built against a different libgps binary. It's also why I got the idea to write the quick C program in #948388, which returns a nonzero fd. -- Dan Chokola
Bug#948393: foxtrotgps: fails to connect to gpsd despite SUCCESS message
On Tue, 2020-01-07 at 21:45 -0500, Daniel Peter Chokola wrote: > Foxtrotgps fails to connect to gpsd, but other clients work. Console > prints: 'connection to gpsd SUCCEEDED' but gps data is dever > displayed. A build of 1.2.2 from source works fine. I suspect the > build got out of step with libgps. See also #948388. I don't have a GPS device in order to test this. I'm CCing the gpsd maintainer Bernd Zeimetz in order to find out why a rebuild would fix the issue. Any ideas? -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#948393: foxtrotgps: fails to connect to gpsd despite SUCCESS message
Package: foxtrotgps Version: 1.2.2-1+b1 Severity: important Dear Maintainer, Foxtrotgps fails to connect to gpsd, but other clients work. Console prints: 'connection to gpsd SUCCEEDED' but gps data is dever displayed. A build of 1.2.2 from source works fine. I suspect the build got out of step with libgps. See also #948388. -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386, arm64 Kernel: Linux 5.3.0-2-amd64 (SMP w/8 CPU cores) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages foxtrotgps depends on: ii dconf-gsettings-backend [gsettings-backend] 0.34.0-2 ii libatk1.0-0 2.34.1-1 ii libbluetooth35.50-1+b1 ii libc62.29-8 ii libcurl3-gnutls 7.67.0-2 ii libexif120.6.21-5.1 ii libgdk-pixbuf2.0-0 2.40.0+dfsg-2 ii libglade2-0 1:2.6.4-2+b1 ii libglib2.0-0 2.62.4-1 ii libgps25 3.20-1 ii libgtk2.0-0 2.24.32-4 ii libpango-1.0-0 1.42.4-8 ii libsqlite3-0 3.30.1+fossil191229-1 ii libxml2 2.9.4+dfsg1-8 Versions of packages foxtrotgps recommends: ii gpsd 3.20-1 Versions of packages foxtrotgps suggests: pn gpsbabel ii python3 3.7.5-3 ii python3-bs4 4.8.2-1 pn python3-feedparser ii python3-sqlalchemy 1.3.12+ds1-1 -- no debconf information
