Bug#948570: pkgconfig files are missing from -dev packages

2020-01-25 Thread Steven Robbins
Hello,

On Fri, 10 Jan 2020 11:35:09 +0100 Helge Bahmann  wrote:

> The pkgconfig files supplied by upstream are not included in the installation 
--
> having them available improves usability of the gtest for dev purposes. I 
verified
> that this is still the case for 1.9.0 presently in testing.

It turns out that your patch to ship the generated pkgconfig files triggers the 
lintian error pkg-config-bad-directive:

The pkg-config file contains a wrong directive.

The following file includes a wrong directive. This could lead to   

FTBFS or leak private compile flags to another package.

I have reverted this change until I understand what's going on.

-Steve


signature.asc
Description: This is a digitally signed message part.


Bug#948570: pkgconfig files are missing from -dev packages

2020-01-10 Thread Helge Bahmann
Package: libgtest-dev
Version: 1.8.1-3
Severity: normal
Tags: patch

The pkgconfig files supplied by upstream are not included in the installation --
having them available improves usability of the gtest for dev purposes. I 
verified
that this is still the case for 1.9.0 presently in testing.

-- System Information:
Debian Release: 10.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: arm64

Kernel: Linux 4.19.0-6-amd64 (SMP w/12 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8), 
LANGUAGE=de_CH:de (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libgtest-dev depends on:
ii  googletest  1.8.1-3

libgtest-dev recommends no packages.

libgtest-dev suggests no packages.

-- no debconf information
diff -u debian.old/changelog debian/changelog
--- debian.old/changelog2019-01-12 22:42:59.0 +0100
+++ debian/changelog2020-01-10 11:24:33.260931865 +0100
@@ -1,3 +1,10 @@
+googletest (1.8.1-3.1) UNRELEASED; urgency=medium
+
+  [ Helge Bahmann]
+  * Include pkgconfig files in -dev packages.
+
+ -- Helge Bahmann   Fri, 10 Jan 2020 11:23:33 +0100
+
 googletest (1.8.1-3) unstable; urgency=medium
 
   [ Steven Robbins ]
Nur in debian: .debhelper.
Nur in debian: debhelper-build-stamp.
Nur in debian: files.
Nur in debian: google-mock.
Nur in debian: google-mock.debhelper.log.
Nur in debian: google-mock.substvars.
Nur in debian: googletest.
Nur in debian: googletest.debhelper.log.
Nur in debian: googletest.substvars.
Nur in debian: googletest-tools.
Nur in debian: googletest-tools.debhelper.log.
Nur in debian: googletest-tools.substvars.
Nur in debian: libgmock-dev.
Nur in debian: libgmock-dev.debhelper.log.
diff -u debian.old/libgmock-dev.install debian/libgmock-dev.install
--- debian.old/libgmock-dev.install 2019-01-12 22:42:59.0 +0100
+++ debian/libgmock-dev.install 2020-01-10 11:24:33.260931865 +0100
@@ -1,3 +1,4 @@
 debian/tmp/usr/lib/*/libgmock*
+debian/tmp/usr/lib/*/pkgconfig/gmock*pc
 debian/tmp/usr/include/gmock
 
Nur in debian: libgmock-dev.substvars.
Nur in debian: libgtest-dev.
Nur in debian: libgtest-dev.debhelper.log.
diff -u debian.old/libgtest-dev.install debian/libgtest-dev.install
--- debian.old/libgtest-dev.install 2019-01-12 22:42:59.0 +0100
+++ debian/libgtest-dev.install 2020-01-10 11:24:33.260931865 +0100
@@ -1,2 +1,3 @@
 debian/tmp/usr/lib/*/libgtest*
+debian/tmp/usr/lib/*/pkgconfig/gtest*pc
 debian/tmp/usr/include/gtest
Nur in debian: libgtest-dev.substvars.
Gemeinsame Unterverzeichnisse: debian.old/patches und debian/patches.
Gemeinsame Unterverzeichnisse: debian.old/source und debian/source.
Nur in debian: tmp.