Bug#950571: znc: ZNC is unable to connect to IRC with default oidentd configuration

2020-03-03 Thread Patrick Matthäi
Hi,

Am 13.02.2020 um 13:00 schrieb Richard:
> Sorry, this ended up in my spam folder. The following configuration would 
> work:
>
> user "_znc" {
> default {
> force reply "znc"
> }
> }
>
> This is the one I actually use with the identfile module to have the
> ident show as the actual user rather than "znc", but it probably
> should not be default:
>
> user "_znc" {
> default {
> allow spoof
> allow spoof_all
> }
> }
>
> I don't know what's the best way to fix this, as there doesn't seem to
> be an oidentd.d folder that would make it easier to add additional
> configuration, rather than modifying the main config file, but I
> believe the default configuration with oidentd should not prevent ZNC
> from connecting to IRC, even though in my case I knew what to do.
>
> Maybe patch oidentd to strip the leading underscore by default? I
> don't know if any other services making use of ident accept a leading
> underscore, if so it is possible (though probably not very likely)
> that such a change could break existing setups.
>
> On Fri, Feb 7, 2020 at 8:31 PM Patrick Matthäi  wrote:
>>
>> Am 03.02.2020 um 17:21 schrieb Richard:
>>> Package: znc
>>> Version: 1.7.5-1~bpo10+1
>>> Severity: important
>>>
>>> Dear Maintainer,
>>>
>>> The ZNC package now ships with a system user called `_znc`, rather than
>>> `znc`. This is causes an issue when oidentd is installed and the default
>>> configuration is not overridden. Most IRC networks will treat `_znc` as
>>> an invalid username, and refuse connection. For example, freenode:
>>>
>>> 17:16:59 <*status> Error from server: Closing Link: cadoth.net (Invalid 
>>> username [_znc])
>>>
>>>
>> Hi,
>>
>> I don't know if it is such a good idea (and Debian rules confirm) to
>> provide a default oidentd config (also you are free to use other identd
>> services?). So my first idea would be to provide a working oidentd
>> config as example file. The other pro would be, that the admin of the
>> system has to know, what he is doing :-)
>>
>> --
>>

I would suggest the following solution.
@Mattia: Do you also aggre with it?


Index: debian/README.Debian
===
--- debian/README.Debian    (Revision 9327)
+++ debian/README.Debian    (Arbeitskopie)
@@ -26,3 +26,17 @@
    # systemctl enable znc

 Now znc will run as a system daemon.
+
+=== oidentd configuration ===
+
+Especially if you use the systemd service, you are not able to connect
to many
+IRC networks, because you will use the default username (_znc), which is
+invalid.
+You can configure oidentd to allow identity spoofing or to reply with
"znc" as
+username. You will find an example here:
+   /usr/share/doc/znc/examples/oidentd.conf
+You have to copy it to the home directory of the znc user:
+   /var/lib/znc/.oidentd.conf
+
+You will find more information and configuration examples here:
+   https://wiki.znc.in/Identfile
Index: debian/changelog
===
--- debian/changelog    (Revision 9327)
+++ debian/changelog    (Arbeitskopie)
@@ -1,3 +1,10 @@
+znc (1.7.5-4) UNRELEASED; urgency=medium
+
+  * Add oidentd configuration example and explain it in README.Debian.
+    Closes: #950571
+
+ -- Patrick Matthäi   Tue, 03 Mar 2020 11:15:32 +0100
+
 znc (1.7.5-3) unstable; urgency=medium

   * Build-depend on the unversioned swig.  Closes: #952602
Index: debian/oidentd.conf
===
--- debian/oidentd.conf (nicht existent)
+++ debian/oidentd.conf (Arbeitskopie)
@@ -0,0 +1,5 @@
+user "_znc" {
+   default {
+   force reply "znc"
+   }
+}
Index: debian/znc.examples
===
--- debian/znc.examples (nicht existent)
+++ debian/znc.examples (Arbeitskopie)
@@ -0,0 +1 @@
+debian/oidentd.conf

-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

  Blog: https://www.linux-dev.org/
E-Mail: pmatth...@debian.org
patr...@linux-dev.org
*/



Bug#950571: znc: ZNC is unable to connect to IRC with default oidentd configuration

2020-02-07 Thread Patrick Matthäi


Am 03.02.2020 um 17:21 schrieb Richard:
> Package: znc
> Version: 1.7.5-1~bpo10+1
> Severity: important
>
> Dear Maintainer,
>
> The ZNC package now ships with a system user called `_znc`, rather than
> `znc`. This is causes an issue when oidentd is installed and the default
> configuration is not overridden. Most IRC networks will treat `_znc` as
> an invalid username, and refuse connection. For example, freenode:
>
> 17:16:59 <*status> Error from server: Closing Link: cadoth.net (Invalid 
> username [_znc])
>
>
Hi,

I don't know if it is such a good idea (and Debian rules confirm) to
provide a default oidentd config (also you are free to use other identd
services?). So my first idea would be to provide a working oidentd
config as example file. The other pro would be, that the admin of the
system has to know, what he is doing :-)

-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

  Blog: https://www.linux-dev.org/
E-Mail: pmatth...@debian.org
patr...@linux-dev.org
*/



Bug#950571: znc: ZNC is unable to connect to IRC with default oidentd configuration

2020-02-03 Thread Richard
Package: znc
Version: 1.7.5-1~bpo10+1
Severity: important

Dear Maintainer,

The ZNC package now ships with a system user called `_znc`, rather than
`znc`. This is causes an issue when oidentd is installed and the default
configuration is not overridden. Most IRC networks will treat `_znc` as
an invalid username, and refuse connection. For example, freenode:

17:16:59 <*status> Error from server: Closing Link: cadoth.net (Invalid 
username [_znc])

-- System Information:
Debian Release: 10.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages znc depends on:
ii  libboost-locale1.67.0  1.67.0-13
ii  libc6  2.28-10
ii  libgcc11:8.3.0-6
ii  libicu63   63.1-6
ii  libsasl2-2 2.1.27+dfsg-1+deb10u1
ii  libssl1.1  1.1.1d-0+deb10u2
ii  libstdc++6 8.3.0-6
ii  zlib1g 1:1.2.11.dfsg-1

Versions of packages znc recommends:
ii  znc-perl1.7.5-1~bpo10+1
ii  znc-python  1.7.5-1~bpo10+1
ii  znc-tcl 1.7.5-1~bpo10+1

znc suggests no packages.

-- no debconf information