Bug#952298: sshcommand: FTBFS: shellcheck fails
Hello, Here's a possible patch to fix this: --- sshcommand-0~20160110.1~2795f65.orig/sshcommand +++ sshcommand-0~20160110.1~2795f65/sshcommand @@ -32,7 +32,7 @@ case "$1" in create) # sshcommand create if [[ $# -ne 3 ]]; then echo "Usage : sshcommand create user command" - exit -1 + exit 1 fi USER="$2"; COMMAND="$3" @@ -52,7 +52,7 @@ case "$1" in acl-add) # sshcommand acl-add if [[ $# -ne 3 ]]; then echo "Usage : sshcommand acl-add user identifier" - exit -1 + exit 1 fi USER="$2"; NAME="$3" @@ -68,7 +68,7 @@ case "$1" in if [[ ! "$FINGERPRINT" =~ :.* ]]; then echo "Invalid ssh public key" - exit -1 + exit 1 fi KEY_PREFIX="command=\"FINGERPRINT=$FINGERPRINT NAME=\\\"$NAME\\\" \`cat $USERHOME/.sshcommand\` \$SSH_ORIGINAL_COMMAND\",no-agent-forwarding,no-user-rc,no-X11-forwarding,no-port-forwarding" echo "$KEY_PREFIX $KEY" >> "$USERHOME/.ssh/authorized_keys" @@ -78,7 +78,7 @@ case "$1" in acl-remove) # sshcommand acl-remove if [[ $# -ne 3 ]]; then echo "Usage : sshcommand acl-remove user identifier" - exit -1 + exit 1 fi USER="$2"; NAME="$3" Best regards, -- ⢀⣴⠾⠻⢶⣦⠀ Fabio A. De Muzio Tobich ⣾⠁⢰⠒⠀⣿⡁ 9730 4066 E5AE FAC2 2683 ⢿⡄⠘⠷⠚⠋⠀ D03D 4FB3 B4D3 7EF6 3B2E ⠈⠳⣄ GPG:rsa4096/7EF63B2E signature.asc Description: PGP signature
Bug#952298: sshcommand: FTBFS: shellcheck fails
Source: sshcommand Version: 0~20160110.1~2795f65-1 Severity: serious Justification: FTBFS on amd64 Tags: bullseye sid ftbfs Usertags: ftbfs-20200222 ftbfs-bullseye Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[1]: Entering directory '/<>' > shellcheck sshcommand > > In sshcommand line 35: > exit -1 >^-- SC2242: Can only exit with status 0-255. Other data should be > written to stdout/stderr. > > > In sshcommand line 55: > exit -1 >^-- SC2242: Can only exit with status 0-255. Other data should be > written to stdout/stderr. > > > In sshcommand line 71: > exit -1 >^-- SC2242: Can only exit with status 0-255. Other data should be > written to stdout/stderr. > > > In sshcommand line 81: > exit -1 >^-- SC2242: Can only exit with status 0-255. Other data should be > written to stdout/stderr. > > For more information: > https://www.shellcheck.net/wiki/SC2242 -- Can only exit with status 0-255. > ... > make[1]: *** [debian/rules:7: override_dh_auto_build] Error 1 The full build log is available from: http://qa-logs.debian.net/2020/02/22/sshcommand_0~20160110.1~2795f65-1_unstable.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures.
