Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-04-22 Thread Nicholas D Steeves
Hi Thomas,

Reply follows in-line:

Thomas Koch  writes:

> Hi Nicholas,
>
> I just uploaded persist-el. Thank you and sorry for the delay. This
> was my first sponsorship and I also had to setup a new laptop. I'm
> just waiting for the confirmation mail for the upload.
>

Thank you for sponsoring!  Best of luck with the toil of getting the new
laptop setup (eg: MUA line wrapping, and weird trailing white-space in
lintian output).  Did you upload twice btw?  [22-04 edit: Oh!
Sébastien, thank you!]

> There are a few nitpicks and I'd be grateful if you could track them,
> e.g. in bugs.d.o after the package enters the archive:
>
> - It's a pity that we can not include the info file due to the
> license. Could you ask upstream to consider another license?

Sure thing, I've added it to my TODO.  BTW, because it's a GNU ELPA
project I'm pessimistic they'll relicense the docs...

> - As long as the doc is not included, I think you don't need to build
> depend on texinfo.

Agreed, I'll either drop it for the -2 upload, or if upstream relicenses
their texinfo source then I'll build the info file.

> - If upstream also uses Git, I prefer to track upstreams master branch
> as upstream branch in the packaging repo. You could still merge their
> branch in your existing repo or restart the repo?

I also prefer to track upstream's master branch; however, persist.el is
part of the GNU ELPA mondo-repo, which contains many other packages, and
our team uses one repo per source package.

> - Lintian also had two nitpicks, see below. I'm guilty of the "wrong"
> section myself for elpa-editorconfig. What is the teams stand on this?
>

I've discussed similar issues with the team before, and the consensus is
that it's not worth the trouble of a section change.  Having filed a
couple of section change requests in the past, an ftpmaster sometimes
moved them to weird/generic sections...eg: I requested a move for Elpy
(Python IDE) to Development from either Lisp or Editors, and they moved
it to Text...

Dh-make-elpa also used to use section "lisp" but now uses section
"editors", and this is also a case where where "editors" seems to be
team-endorsed (via dh-make-elpa), and I think the team consensus is that
lintian's claim is wrong.  IIRC the "info" severity is a compromise
between our team and whoever believes all packages that are implemented
in lisp should be in section lisp...  When it was a warning I filed a
bunch of section change requests (editors-to->lisp) that ftpmasters
didn't seem to appreciate.

That said, upon further consideration I agree that "lisp" might have
been the most appropriate section, because persist.el has no interactive
functions and is thus more of a library than an editor.  If there's a
way to attach a note to the ftpmaster review, then let's do that!  I'm
of course happy to happy to correct the package's classification in
control so that it matches the archive.

> I: persist-el source: public-upstream-key-not-minimal 
> upstream/signing-key.asc has 1 extra signature(s) for keyid 066DAFCB81E42C40  
>   
> N:
>   
>  
> N:The package contains a public upstream signing key with extra   
>   
>   
> N:signatures. The signatures are unnecessary and take up space in the 
>   
>   
> N:archive.
>   
>   
> N:
>   
>   
> N:Please export the upstream key again with the command:  
>   
>   
> N:
>   
>   
> N: $ gpg --armor --export --export-options export-minimal,export-clean
>   
>   
> N:
>   
>   
> N:and use that key instead of the key currently in the source package.
>   
>   
> N: 

Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-04-22 Thread Sébastien Delafond
On 21/04 20:23, Thomas Koch wrote:
> I just uploaded persist-el. Thank you and sorry for the delay.

As I had announced in my previous email, I already did that; see msg=19
of #954050, and
https://ftp-master.debian.org/new/persist-el_0.4+dfsg-1.html.

I'll most definitely be out of your way for the next uploads of
persist-el.

Cheers,

-- 
Seb



Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-04-21 Thread Thomas Koch
Hi Nicholas,

I just uploaded persist-el. Thank you and sorry for the delay. This was my 
first sponsorship and I also had to setup a new laptop. I'm just waiting for 
the confirmation mail for the upload.

There are a few nitpicks and I'd be grateful if you could track them, e.g. in 
bugs.d.o after the package enters the archive:

- It's a pity that we can not include the info file due to the license. Could 
you ask upstream to consider another license?
- As long as the doc is not included, I think you don't need to build depend on 
texinfo.
- If upstream also uses Git, I prefer to track upstreams master branch as 
upstream branch in the packaging repo. You could still merge their branch in 
your existing repo or restart the repo?
- Lintian also had two nitpicks, see below. I'm guilty of the "wrong" section 
myself for elpa-editorconfig. What is the teams stand on this?

Cheers, Thomas



I: persist-el source: public-upstream-key-not-minimal upstream/signing-key.asc 
has 1 extra signature(s) for keyid 066DAFCB81E42C40 
   
N:  

  
N:The package contains a public upstream signing key with extra 

  
N:signatures. The signatures are unnecessary and take up space in the   

  
N:archive.  

  
N:  

  
N:Please export the upstream key again with the command:

  
N:  

  
N: $ gpg --armor --export --export-options export-minimal,export-clean  

  
N:  

  
N:and use that key instead of the key currently in the source package.  

  
N:  

  
N:Refer to the uscan(1) manual page for details.

  
N:  

  
N:Severity: info

  
N:  

  
N:Check: debian/upstream/signing-key

  
N:  

  
I: elpa-persist: wrong-section-according-to-package-name elpa-persist => lisp   

  
N:  

  
N:This package has a name suggesting that it belongs to a section other 

  
N:than the one it is currently categorized in.
N:
N:Severity: info
N:
N:Check: fields/section
N:



> Nicholas D Steeves  hat am 11. April 2020 12:31 
> geschrieben:
> 
>  
> Hi Thomas and Sébastien,
> 
> #947017 "ITP: org-drill" is blocked by this RFS (#954050) for a
> required dependency (persist-el).  Please sponsor at your earliest
> convenience to we 

Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-04-13 Thread Sébastien Delafond
On 11/04 06:31, Nicholas D Steeves wrote:
> #947017 "ITP: org-drill" is blocked by this RFS (#954050) for a
> required dependency (persist-el).  Please sponsor at your earliest
> convenience to we can resume progress on getting org-drill back into
> Debian.

Hello,

I have very little bandwidth these days, so if Thomas has some to handle
this mentoring request, that would work out best. If not, I will try to
find some time next week-end to do a one-time review and upload of
persist-el. Thomas, can you let us know what you think?

Cheers,

-- 
Seb



Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-04-11 Thread Nicholas D Steeves
Hi Thomas and Sébastien,

#947017 "ITP: org-drill" is blocked by this RFS (#954050) for a
required dependency (persist-el).  Please sponsor at your earliest
convenience to we can resume progress on getting org-drill back into
Debian.

Thanks,
Nicholas


signature.asc
Description: PGP signature


Bug#954050: RFS: persist-el/0.4+dfsg-1 [ITP] -- persist variables between Emacs Sessions

2020-03-15 Thread Nicholas D Steeves
Package: sponsorship-requests
Severity: wishlist
Control: block 953128 by -1

Dear mentors,

I am looking for a sponsor for my package "persist-el".  It is a
dependency of org-drill (ITP #947017), and org-drill will restore
functionality to Emacs' org-mode that was previously built-in.

 * Package name: persist-el
   Version : 0.4+dfsg-1
   Upstream Author : Phillip Lord 
 * URL : http://elpa.gnu.org/packages/persist.html
 * License : GPL-3+
 * Vcs : https://salsa.debian.org/emacsen-team/persist-el
   Section : editors

It builds this binary package:

  elpa-persist - persist variables between Emacs Sessions

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/persist-el

Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/p/persist-el/persist-el_0.4+dfsg-1.dsc

Alternatively, use git, gbp, and pristine tar using this repo:

  https://salsa.debian.org/emacsen-team/persist-el

Changes since the last upload:

   * Initial release. (Closes: #953128)

Regards,
Nicholas