Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
I have added GTK version in short description. I have removed the GTK 2 build, I'm sad :'(. I updated patch description. For the manpages, yes, it's in my futur todo list, but not yet done. Mentors package updated. Le 15/08/2021 à 12:20, Tobias Frost a écrit : On Sun, Aug 15, 2021 at 11:52:59AM +0200, Tobias Frost wrote: On Sun, Aug 15, 2021 at 11:21:21AM +0200, Fabrice Creuzot wrote: Hi, Thank you. I hope I have fixed the crash with GTK 4. I fixed the debian format. I changed unstable to testing, good? You want "experimental" :) -- tobi (I've merged the RFS and ITP bugs) - Beside "experimental", lintian has: I duplicate-short-description Possibly ammend the short description by the intended GTK version? - The patch has a "Bugs-Debian" entry, but the mentioned bug is the ITP. This is not the intended usage of the field: The field should be used if that patch fixes a specific Debian-Bug, with information the bug being fixed the mentioned bug. (The ITP is not fixin a bug) TL;DR: Remove that field. Though, you should add "Fowarded:" entries (possibly not-needed if Debian specific) (Please read https://dep-team.pages.debian.net/deps/dep3/ for all those details about the dep3 format.) - BTW, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959434#10 … Possibly you should drop the gtk-2 version from your package to be nice to the GTK maintainers (it will create extra work for them if you introduce new GTK2 packages) - (Wishlist) Would it be possible to have some manpages for the binaries? -- tobi
Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
On Sun, Aug 15, 2021 at 11:52:59AM +0200, Tobias Frost wrote: > On Sun, Aug 15, 2021 at 11:21:21AM +0200, Fabrice Creuzot wrote: > > Hi, > > > > Thank you. > > > > I hope I have fixed the crash with GTK 4. > > I fixed the debian format. > > > > I changed unstable to testing, good? > > You want "experimental" :) > > -- > tobi > (I've merged the RFS and ITP bugs) - Beside "experimental", lintian has: I duplicate-short-description Possibly ammend the short description by the intended GTK version? - The patch has a "Bugs-Debian" entry, but the mentioned bug is the ITP. This is not the intended usage of the field: The field should be used if that patch fixes a specific Debian-Bug, with information the bug being fixed the mentioned bug. (The ITP is not fixin a bug) TL;DR: Remove that field. Though, you should add "Fowarded:" entries (possibly not-needed if Debian specific) (Please read https://dep-team.pages.debian.net/deps/dep3/ for all those details about the dep3 format.) - BTW, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959434#10 … Possibly you should drop the gtk-2 version from your package to be nice to the GTK maintainers (it will create extra work for them if you introduce new GTK2 packages) - (Wishlist) Would it be possible to have some manpages for the binaries? -- tobi
Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
On Sun, Aug 15, 2021 at 11:21:21AM +0200, Fabrice Creuzot wrote: > Hi, > > Thank you. > > I hope I have fixed the crash with GTK 4. > I fixed the debian format. > > I changed unstable to testing, good? You want "experimental" :) -- tobi
Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
Hi,
Thank you.
I hope I have fixed the crash with GTK 4.
I fixed the debian format.
I changed unstable to testing, good?
I'm not sure what to do with: the short desc shouldn't be capitalized.
In my last email, I forgot that I have modified:
>> awf-gtk2 - Theme preview application for GTK
>> awf-gtk3 - Theme preview application for GTK
>> awf-gtk4 - Theme preview application for GTK
Package is up to date at mentors.net.
For "patch-not-forwarded-upstream", I applied the pacth for the next
release.
Le 14/08/2021 à 20:40, Adam Borowski a écrit :
On Fri, Aug 13, 2021 at 02:21:21PM +0200, Fabrice Creuzot wrote:
Okay, so I tried to build all binary packages from one source package.
Not sure if it's the good way.
It builds those binary packages:
awf-gtk2 - A widget factory is a theme preview application for GTK
awf-gtk3 - A widget factory is a theme preview application for GTK
awf-gtk4 - A widget factory is a theme preview application for GTK
Generally, looks good to me.
However, gtk-4 is available only in experimental. This will almost
certainly change before your package leaves NEW (gtk4 maintainers are
probably salivating at the thought of uploading to unstable ASAP, while
NEW is very crowded), but let's have installable+buildable packages.
There's no reason for a first upload of a package to go into unstable,
too -- it needs a rebuild in any case.
Nitpick: the short desc shouldn't be capitalized.
Having no explicit debian/source/format is deprecated -- please declare
the format.
Also, while gtk2 and 3 binaries work for me, gtk4 crashes at start:
Thread 1 "awf-gtk4" received signal SIGSEGV, Segmentation fault.
create_treview (root=0x556a5780) at awf.c:1973
1973if (strcmp (config, "0") == 0)
(gdb) bt full
#0 create_treview (root=0x556a5780) at awf.c:1973
scrolled_window = 0x559704c0
store = 0x55909960
iter =
{stamp = -1097518473, user_data = 0x558cc150, user_data2 =
0x556b7160, user_data3 = 0x0}
config = 0x0
view = 0x5593c3c0
renderer =
hbox_columns =
vbox_column1 =
vbox_combo_entry =
hbox_spin =
hbox_check_radio =
vbox_check =
vbox_radio =
vbox_column2 =
vbox_buttons =
hbox_btns1 =
hbox_btns2 =
hbox_btns3 =
hbox_btns4 =
vbox_column3 =
vbox_progressbar1 =
vbox_progressbar2 =
hbox_progressbar1 =
hbox_progressbar2 =
vbox_column4 =
vbox_others =
hbox_label = 0x556a5900
hbox_spinner = 0x556a5a80
vpane = 0x555cb3b0
hpane1 = 0x555cb590
hpane2 = 0x555cb770
hbox_frame1 = 0x556a5c00
hbox_frame2 = 0x556a5d80
hbox_notebook1 = 0x556a5f00
hbox_notebook2 = 0x556d21f0
#1 create_widgets (root=0x556b7760) at awf.c:818
hbox_columns =
vbox_column1 =
vbox_combo_entry =
hbox_spin =
hbox_check_radio =
vbox_check =
vbox_radio =
vbox_column2 =
vbox_buttons =
hbox_btns1 =
hbox_btns2 =
hbox_btns3 =
hbox_btns4 =
vbox_column3 =
vbox_progressbar1 =
vbox_progressbar2 =
hbox_progressbar1 =
hbox_progressbar2 =
vbox_column4 =
vbox_others =
hbox_label = 0x556a5900
hbox_spinner = 0x556a5a80
vpane = 0x555cb3b0
hpane1 = 0x555cb590
hpane2 = 0x555cb770
hbox_frame1 = 0x556a5c00
hbox_frame2 = 0x556a5d80
hbox_notebook1 = 0x556a5f00
hbox_notebook2 = 0x556d21f0
#2 0x55562e1c in create_window (app=, theme=) at awf.c:734
vbox_window = 0x556b7160
toolbar = 0x556b72e0
widgets = 0x556b7760
gmm =
event =
#3 0x774450a2 in g_closure_invoke () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4 0x77457413 in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x7745d6cf in g_signal_emit_valist () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x7745dc3f in g_signal_emit () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x7756a338 in () at /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#8 0x7756a4ae in g_application_run () at
/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#9 0x77161d0a in __libc_start_main (main=
0xb060 , argc=1, argv=0x7fffe008, init=,
fini=, rtld_fini=, stack_end=0x7fffdff8) at
../csu/libc-start.c:308
result =
unwind_buf =
{cancel_jmp_buf = {{jmp_buf = {0, 3035993641122779325,
93824992261632, 0, 0, 0, 9184899517099004093, 9184881029332193469},
mask_was_saved = 0}}, priv = {pad =
Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
On Fri, Aug 13, 2021 at 02:21:21PM +0200, Fabrice Creuzot wrote:
> Okay, so I tried to build all binary packages from one source package.
> Not sure if it's the good way.
>
> It builds those binary packages:
> awf-gtk2 - A widget factory is a theme preview application for GTK
> awf-gtk3 - A widget factory is a theme preview application for GTK
> awf-gtk4 - A widget factory is a theme preview application for GTK
Generally, looks good to me.
However, gtk-4 is available only in experimental. This will almost
certainly change before your package leaves NEW (gtk4 maintainers are
probably salivating at the thought of uploading to unstable ASAP, while
NEW is very crowded), but let's have installable+buildable packages.
There's no reason for a first upload of a package to go into unstable,
too -- it needs a rebuild in any case.
Nitpick: the short desc shouldn't be capitalized.
Having no explicit debian/source/format is deprecated -- please declare
the format.
Also, while gtk2 and 3 binaries work for me, gtk4 crashes at start:
Thread 1 "awf-gtk4" received signal SIGSEGV, Segmentation fault.
create_treview (root=0x556a5780) at awf.c:1973
1973if (strcmp (config, "0") == 0)
(gdb) bt full
#0 create_treview (root=0x556a5780) at awf.c:1973
scrolled_window = 0x559704c0
store = 0x55909960
iter =
{stamp = -1097518473, user_data = 0x558cc150, user_data2 =
0x556b7160, user_data3 = 0x0}
config = 0x0
view = 0x5593c3c0
renderer =
hbox_columns =
vbox_column1 =
vbox_combo_entry =
hbox_spin =
hbox_check_radio =
vbox_check =
vbox_radio =
vbox_column2 =
vbox_buttons =
hbox_btns1 =
hbox_btns2 =
hbox_btns3 =
hbox_btns4 =
vbox_column3 =
vbox_progressbar1 =
vbox_progressbar2 =
hbox_progressbar1 =
hbox_progressbar2 =
vbox_column4 =
vbox_others =
hbox_label = 0x556a5900
hbox_spinner = 0x556a5a80
vpane = 0x555cb3b0
hpane1 = 0x555cb590
hpane2 = 0x555cb770
hbox_frame1 = 0x556a5c00
hbox_frame2 = 0x556a5d80
hbox_notebook1 = 0x556a5f00
hbox_notebook2 = 0x556d21f0
#1 create_widgets (root=0x556b7760) at awf.c:818
hbox_columns =
vbox_column1 =
vbox_combo_entry =
hbox_spin =
hbox_check_radio =
vbox_check =
vbox_radio =
vbox_column2 =
vbox_buttons =
hbox_btns1 =
hbox_btns2 =
hbox_btns3 =
hbox_btns4 =
vbox_column3 =
vbox_progressbar1 =
vbox_progressbar2 =
hbox_progressbar1 =
hbox_progressbar2 =
vbox_column4 =
vbox_others =
hbox_label = 0x556a5900
hbox_spinner = 0x556a5a80
vpane = 0x555cb3b0
hpane1 = 0x555cb590
hpane2 = 0x555cb770
hbox_frame1 = 0x556a5c00
hbox_frame2 = 0x556a5d80
hbox_notebook1 = 0x556a5f00
hbox_notebook2 = 0x556d21f0
#2 0x55562e1c in create_window (app=, theme=) at awf.c:734
vbox_window = 0x556b7160
toolbar = 0x556b72e0
widgets = 0x556b7760
gmm =
event =
#3 0x774450a2 in g_closure_invoke () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4 0x77457413 in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x7745d6cf in g_signal_emit_valist () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x7745dc3f in g_signal_emit () at
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x7756a338 in () at /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#8 0x7756a4ae in g_application_run () at
/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#9 0x77161d0a in __libc_start_main (main=
0xb060 , argc=1, argv=0x7fffe008, init=,
fini=, rtld_fini=, stack_end=0x7fffdff8) at
../csu/libc-start.c:308
result =
unwind_buf =
{cancel_jmp_buf = {{jmp_buf = {0, 3035993641122779325,
93824992261632, 0, 0, 0, 9184899517099004093, 9184881029332193469},
mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x1, 0x7fffe008}, data =
{prev = 0x0, cleanup = 0x0, canceltype = 1}}}
not_first_call =
#10 0xb62a in _start ()
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables
⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice.
⠈⠳⣄
Bug#959892: RFS: awf-gtk/2.5.0-1 [ITP] -- A widget factory is a theme preview application for GTK
Okay, so I tried to build all binary packages from one source package. Not sure if it's the good way. It builds those binary packages: awf-gtk2 - A widget factory is a theme preview application for GTK awf-gtk3 - A widget factory is a theme preview application for GTK awf-gtk4 - A widget factory is a theme preview application for GTK To access further information about this package, please visit the following URL: https://mentors.debian.net/package/awf-gtk/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/a/awf-gtk/awf-gtk_2.5.0-1.dsc
