Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file
Hi Richard, On Fri, Sep 18, 2020 at 12:21 AM Richard Laager wrote: > > found 960132 4.1-1 > severity 960132 serious You commented on a bug that was closed. I believe those settings had no effect. > This bug causes a shipped service (mdcheck_start.service) to completely > fail to start, due to the fact that its script > (/usr/share/mdadm/mdcheck) does not exist. A package should not release > in that state. Due to other comments this bug has become too long and too confusing. Please open another bug if your issue still exists. Thank you! Kind regards Felix Lechner
Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file
found 960132 4.1-1 severity 960132 serious Justification for "serious": This bug causes a shipped service (mdcheck_start.service) to completely fail to start, due to the fact that its script (/usr/share/mdadm/mdcheck) does not exist. A package should not release in that state. I considered going up or down a level, but ultimately landed on "serious". Argument for increasing to "grave": For someone expecting/needing this service to work, this could lead to data loss. The entire point of MD's "check" functionality is to make sure that all the blocks are readable. In e.g. a two-disk mirror, if one disk ends up with an unreadable block and then the other disk fails, data loss occurs. If the check script runs as intended and catches this before the second failure, the unreadable block will be detected and then rewritten (from the good copy on the other disk). Argument for decreasing to "important": mdcheck_start.timer is disabled by default and /etc/cron.d/mdadm still exists. Regardless of the particular severity (>= important), I think this is a good candidate for a stable update. Here is an example debdiff (sub in your name): --- mdadm-4.1/debian/changelog 2019-01-15 12:23:53.0 -0600 +++ mdadm-4.1/debian/changelog 2020-09-18 02:09:41.0 -0500 @@ -1,3 +1,9 @@ +mdadm (4.1-1+deb10u1) buster; urgency=medium + + * Install misc/mdcheck (Closes: #960132) + + -- Richard Laager Fri, 18 Sep 2020 02:09:41 -0500 + mdadm (4.1-1) unstable; urgency=medium * New upstream release. diff -Nru mdadm-4.1/debian/rules mdadm-4.1/debian/rules --- mdadm-4.1/debian/rules 2019-01-15 12:23:53.0 -0600 +++ mdadm-4.1/debian/rules 2020-09-18 02:08:04.0 -0500 @@ -64,6 +64,7 @@ install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script + install -Dm0755 misc/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon install -Dm0644 $(DESTDIR)/lib/udev/rules.d/63-md-raid-arrays.rules $(DESTDIR_UDEB)/lib/udev/rules.d/63-md-raid-arrays.rules -- Richard signature.asc Description: OpenPGP digital signature
Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file
On Sun, 10 May 2020 02:16:57 +0700 Павел Мотырев wrote: > There is a patch in attachment, that adds missed scripts into the > package during build process. syslog-events is already installed by a dh_installexamples call. Also, I'm not sure why this would need to install the mdcheck script into the udeb. So I end up with this (sorry for my mail client line wrapping the context lines): diff -Nru mdadm-4.1/debian/rules mdadm-4.1/debian/rules --- mdadm-4.1/debian/rules 2019-03-11 22:58:03.0 -0500 +++ mdadm-4.1/debian/rules 2020-09-11 17:08:40.0 -0500 @@ -63,6 +63,7 @@ install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray + install -Dm0755 misc/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon -- Richard signature.asc Description: OpenPGP digital signature
Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file
Bug affects all versions since release 4.1-1 - systemd services for mdcheck was created in 0004-mdcheck-add-systemd-unit-files-to-run-mdcheck.patch (https://sources.debian.org/patches/mdadm/4.1-1/0004-mdcheck-add-systemd-unit-files-to-run-mdcheck.patch/)
Bug#960132: mdadm: mdcheck_start.service trying to start unexisting file
X-Debbugs-Cc: none Package: mdadm Version: 4.1-5 Severity: normal mdcheck_start.service trying to start unexisting file root@debian:/# cat /lib/systemd/system/mdcheck_start.service | grep Exec ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh ExecStart=/usr/share/mdadm/mdcheck --duration $MDADM_CHECK_DURATION root@debian:/# ls -la /usr/share/mdadm/mdcheck ls: cannot access '/usr/share/mdadm/mdcheck': No such file or directory root@debian:/# dpkg -L mdadm | grep mdcheck /lib/systemd/system/mdcheck_continue.service /lib/systemd/system/mdcheck_continue.timer /lib/systemd/system/mdcheck_start.service /lib/systemd/system/mdcheck_start.timer -- System Information: Debian Release: 10.4 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-9-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages mdadm depends on: ii debconf [debconf-2.0] 1.5.71 ii libc6 2.28-10 ii lsb-base 10.2019051400 ii udev 241-7~deb10u4 Versions of packages mdadm recommends: ii exim4-daemon-light [mail-transport-agent] 4.92-8+deb10u3 ii kmod 26-1 Versions of packages mdadm suggests: pn dracut-core -- debconf information: mdadm/autoscan: true mdadm/mail_to: root mdadm/start_daemon: true mdadm/autocheck: true There is a patch in attachment, that adds missed scripts into the package during build process. This bug also affects Ubuntu mdadm package - https://bugs.launchpad.net/ubuntu/+source/mdadm/+bug/1852747 --- a/debian/rules 2020-05-10 01:51:20.69600 +0700 +++ b/debian/rules 2020-05-10 01:52:56.4 +0700 @@ -28,6 +28,7 @@ rm -rf udeb mkdir udeb ln *.[ch] Makefile udeb/ + ln misc/mdcheck misc/syslog-events udeb/ touch $@ build-arch: udeb/build-stamp @@ -63,6 +64,8 @@ install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray + install -Dm0755 udeb/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck + install -Dm0755 udeb/syslog-events $(DESTDIR)/usr/share/mdadm/syslog-events install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon
