Bug#960837: opendht: Need -latomic on at least RISC-V architecture

2020-11-14 Thread Adrian Bunk
Control: tags -1 patch

On Sun, Nov 08, 2020 at 09:53:53AM +0200, Juhani Numminen wrote:
> Control: reassign -1 src:opendht 2.1.1-1
> Control: severity -1 serious
> Control: tags -1 +ftbfs
> 
> On Sun, 17 May 2020 14:31:40 +0200 Petter Reinholdtsen  
> wrote:
> > 
> > I had a look at the build failure on RISC-V, as reported by the
> > autobuilders[1], and the problem seem to be that -latomic is not used
> > during linking.
> > 
> >  [1] https://buildd.debian.org/status/package.php?p=opendht >
> 
> The build failures with this message, undefined reference to 
> `__atomic_exchange_8',
> are now happening on two release architectures, armel and mipsel.

Fix/workaround below.

> Regards,
> Juhani

cu
Adrian

--- debian/rules.old2020-11-14 12:04:18.032821426 +
+++ debian/rules2020-11-14 12:07:45.514909271 +
@@ -3,6 +3,10 @@
 
 # Hardening
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+
+ifneq (,$(filter $(DEB_HOST_ARCH), armel m68k mips mipsel powerpc riscv64 sh4))
+  export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic 
-Wl,--as-needed
+endif
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
 



Bug#960837: opendht: Need -latomic on at least RISC-V architecture

2020-11-07 Thread Juhani Numminen
Control: reassign -1 src:opendht 2.1.1-1
Control: severity -1 serious
Control: tags -1 +ftbfs

On Sun, 17 May 2020 14:31:40 +0200 Petter Reinholdtsen  wrote:
> 
> I had a look at the build failure on RISC-V, as reported by the
> autobuilders[1], and the problem seem to be that -latomic is not used
> during linking.
> 
>  [1] https://buildd.debian.org/status/package.php?p=opendht >

The build failures with this message, undefined reference to 
`__atomic_exchange_8',
are now happening on two release architectures, armel and mipsel.


Regards,
Juhani



Bug#960837: opendht: Need -latomic on at least RISC-V architecture

2020-05-17 Thread Petter Reinholdtsen


Package: opendht
Version: 2.1.1-1
Severity: wishlist

I had a look at the build failure on RISC-V, as reported by the
autobuilders[1], and the problem seem to be that -latomic is not used
during linking.

 [1] https://buildd.debian.org/status/package.php?p=opendht >

A similar problem is reported against aktualizr on github[2], which in
turn link to a riscv-gnu-toolchain issue[3] suggesting that every use of
'include ' should be accompanied by -latomic to the linker.

  [2] https://github.com/advancedtelematic/aktualizr/issues/1427
  [3] https://github.com/riscv/riscv-gnu-toolchain/issues/183#issuecomment-253721765 >

Setting severity to wishlist as the RISC-V architecture is not a release
architecture.

A similar problem exist with restinio[4], for a different set of atomic
operations, and for this issue I found a cmake recipe/patch[5] that
might be useful to look at when trying to fix opendht too.

 [4] https://buildd.debian.org/status/package.php?p=restinio=sid >
 [5] https://github.com/kimwalisch/primesieve/pull/46 >.

-- 
Happy hacking
Petter Reinholdtsen