Bug#961755: dh-golang: dh_golang_autopkgtest no longer detects debian/rules targets with make-4.3

[Michael Banck]

On Thu, May 28, 2020 at 09:57:04PM +0200, Michael Banck wrote:
> with make_4.2.3-1:

I meant 4.2.1-1.3.
 
> |# make -pRrq -f debian/rules : | awk -v RS= -F: '/^# File/,/^# Finished Make 
> data base/ { if ($1 !~ "^[#.]") {print $1} }'
> |
> |autopkgtest
> |build
> |override_dh_auto_test
> |override_dh_installsystemd
> |debian/rules
> |override_dh_installinit
> |#
> 
> with make_4.3-1:
> 
> |# make -pRrq -f debian/rules : | awk -v RS= -F: '/^# File/,/^# Finished  
> Make data base/ { if ($1 !~ "^[#.]") {print $1} }'
> |#
> 
> i.e. no output.

The difference is in the make output; make-4.2.1-1.3 puts a new line
before '# Files', like:

|# 1 implicit rules, 0 (0.0%) terminal.
|
|# Files

But make-4.3 no longer does that:

|# 1 implicit rules, 0 (0.0%) terminal.
|# Files

That (in combination with setting RS to empty and IFS to :) makes awk's
pattern-match no longer find /^# File/.

Not sure what the best fix would be.


Michael

Bug#961755: dh-golang: dh_golang_autopkgtest no longer detects debian/rules targets with make-4.3

[Michael Banck]

Package: dh-golang
Version: 1.48
Severity: important

Dear Maintainer,

dh_golang_autopkgtest's prepar() function tries to determine the targets
in debian/rules. In current unstable, TARGETS= is empty and it exits out
silently with return code 1 (due to set -e at the top I think).

with make_4.2.3-1:

|# make -pRrq -f debian/rules : | awk -v RS= -F: '/^# File/,/^# Finished Make 
data base/ { if ($1 !~ "^[#.]") {print $1} }'
|
|autopkgtest
|build
|override_dh_auto_test
|override_dh_installsystemd
|debian/rules
|override_dh_installinit
|#

with make_4.3-1:

|# make -pRrq -f debian/rules : | awk -v RS= -F: '/^# File/,/^# Finished  Make 
data base/ { if ($1 !~ "^[#.]") {print $1} }'
|#

i.e. no output.


Michael

-- System Information:
Debian Release: 10.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-6-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dh-golang depends on:
ii  debhelper 12.1.1
ii  dpkg  1.19.7
ii  libdpkg-perl  1.19.7
ii  perl  5.28.1-6

dh-golang recommends no packages.

dh-golang suggests no packages.