Bug#963971: [Pkg-samba-maint] Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-07-04 Thread Michael Stone

On Sat, Jul 04, 2020 at 03:21:03PM +0200, Mathieu Parent wrote:

Le sam. 4 juil. 2020 à 15:15, Michael Stone  a écrit :


On Sat, Jul 04, 2020 at 07:28:32AM +0200, Mathieu Parent wrote:
>clone 963971 -1
>tag 963971 + upstream
>tag -1 + upstream fixed-upstream patch
>reassign -1 sssd-ad-common
>
>Le lun. 29 juin 2020 à 14:48, Michael Stone  a écrit :
>>
>> Package: samba-libs
>> Version: 2:4.12.3+dfsg-2
>> Severity: critical
>> Justification: breaks the whole system
>>
>> The new samba-libs package changes the soname of libndr from libndr.so.0 to
>> libndr.so.1 without reflecting this change in the package name. 
sssd-ad-common
>> has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to libndr.so.0.
>> When the samba-libs package is updated and libndr.so.0 disappears sssd fails 
to
>> start, which then makes a system's remote users unavailable. (Worse, this
>> doesn't happen until the next time sssd restarts--which may not be until the
>> next reboot.)
>
>It looks to be fixed in sssd 2.3.0:
>https://github.com/SSSD/sssd/commit/bc56b10aea999284458dcc293b54cf65288e325d
>
>I'm cloning this bug:
>- on the samba side I'll add a breaks: sssd-ad-common (<< 2.3.0)
>- on the sssd side, an update to 2.3.0+ is needed

Going forward, do things using samba-libs need a strict version
depenedency since there is no ABI version in the package name?


No, I think. According to the sssd commit, sssd 2.3 will still build
on older samba-libs.


Not a build-time dependency, a run-time dependency; if there is no 
guarantee that the ABI is stable between versions, a dependency on 
"samba-libs >= something" simply isn't valid. (Packages built from the 
samba source package already have a dependency on "samba-libs = version" 
but there currently isn't anything telling other packages that the 
dependencies need to work that way.)




Bug#963971: [Pkg-samba-maint] Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-07-04 Thread Mathieu Parent
Le sam. 4 juil. 2020 à 15:15, Michael Stone  a écrit :
>
> On Sat, Jul 04, 2020 at 07:28:32AM +0200, Mathieu Parent wrote:
> >clone 963971 -1
> >tag 963971 + upstream
> >tag -1 + upstream fixed-upstream patch
> >reassign -1 sssd-ad-common
> >
> >Le lun. 29 juin 2020 à 14:48, Michael Stone  a écrit :
> >>
> >> Package: samba-libs
> >> Version: 2:4.12.3+dfsg-2
> >> Severity: critical
> >> Justification: breaks the whole system
> >>
> >> The new samba-libs package changes the soname of libndr from libndr.so.0 to
> >> libndr.so.1 without reflecting this change in the package name. 
> >> sssd-ad-common
> >> has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to libndr.so.0.
> >> When the samba-libs package is updated and libndr.so.0 disappears sssd 
> >> fails to
> >> start, which then makes a system's remote users unavailable. (Worse, this
> >> doesn't happen until the next time sssd restarts--which may not be until 
> >> the
> >> next reboot.)
> >
> >It looks to be fixed in sssd 2.3.0:
> >https://github.com/SSSD/sssd/commit/bc56b10aea999284458dcc293b54cf65288e325d
> >
> >I'm cloning this bug:
> >- on the samba side I'll add a breaks: sssd-ad-common (<< 2.3.0)
> >- on the sssd side, an update to 2.3.0+ is needed
>
> Going forward, do things using samba-libs need a strict version
> depenedency since there is no ABI version in the package name?

No, I think. According to the sssd commit, sssd 2.3 will still build
on older samba-libs.

Regards
-- 
Mathieu Parent



Bug#963971: [Pkg-samba-maint] Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-07-04 Thread Michael Stone

On Sat, Jul 04, 2020 at 07:28:32AM +0200, Mathieu Parent wrote:

clone 963971 -1
tag 963971 + upstream
tag -1 + upstream fixed-upstream patch
reassign -1 sssd-ad-common

Le lun. 29 juin 2020 à 14:48, Michael Stone  a écrit :


Package: samba-libs
Version: 2:4.12.3+dfsg-2
Severity: critical
Justification: breaks the whole system

The new samba-libs package changes the soname of libndr from libndr.so.0 to
libndr.so.1 without reflecting this change in the package name. sssd-ad-common
has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to libndr.so.0.
When the samba-libs package is updated and libndr.so.0 disappears sssd fails to
start, which then makes a system's remote users unavailable. (Worse, this
doesn't happen until the next time sssd restarts--which may not be until the
next reboot.)


It looks to be fixed in sssd 2.3.0:
https://github.com/SSSD/sssd/commit/bc56b10aea999284458dcc293b54cf65288e325d

I'm cloning this bug:
- on the samba side I'll add a breaks: sssd-ad-common (<< 2.3.0)
- on the sssd side, an update to 2.3.0+ is needed


Going forward, do things using samba-libs need a strict version 
depenedency since there is no ABI version in the package name?




Bug#963971: [Pkg-samba-maint] Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-07-03 Thread Mathieu Parent
clone 963971 -1
tag 963971 + upstream
tag -1 + upstream fixed-upstream patch
reassign -1 sssd-ad-common

Le lun. 29 juin 2020 à 14:48, Michael Stone  a écrit :
>
> Package: samba-libs
> Version: 2:4.12.3+dfsg-2
> Severity: critical
> Justification: breaks the whole system
>
> The new samba-libs package changes the soname of libndr from libndr.so.0 to
> libndr.so.1 without reflecting this change in the package name. sssd-ad-common
> has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to libndr.so.0.
> When the samba-libs package is updated and libndr.so.0 disappears sssd fails 
> to
> start, which then makes a system's remote users unavailable. (Worse, this
> doesn't happen until the next time sssd restarts--which may not be until the
> next reboot.)

It looks to be fixed in sssd 2.3.0:
https://github.com/SSSD/sssd/commit/bc56b10aea999284458dcc293b54cf65288e325d

I'm cloning this bug:
- on the samba side I'll add a breaks: sssd-ad-common (<< 2.3.0)
- on the sssd side, an update to 2.3.0+ is needed

Regards
-- 
Mathieu Parent



Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-06-29 Thread Michael Stone

On Tue, Jun 30, 2020 at 08:48:05AM +1200, Andrew Bartlett wrote:

On Mon, 2020-06-29 at 08:46 -0400, Michael Stone wrote:

Package: samba-libs
Version: 2:4.12.3+dfsg-2
Severity: critical
Justification: breaks the whole system

The new samba-libs package changes the soname of libndr from
libndr.so.0 to
libndr.so.1 without reflecting this change in the package name. sssd-
ad-common
has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to
libndr.so.0.
When the samba-libs package is updated and libndr.so.0 disappears
sssd fails to
start, which then makes a system's remote users unavailable. (Worse,
this
doesn't happen until the next time sssd restarts--which may not be
until the
next reboot.)

It's not clear why the samba-libs package doesn't include the so
number, but at
the very least it needs a set of dependencies to avoid breaking sssd-
ad-common.


We can't put a version number in samba-libs as there are multiple
public libraries in there.

(Upstream) Samba doesn't promise not to keep doing this - the
underlying change has happened before, but this time we were honest and
bumped the .so - so sssd may need to have a dependency on the Samba
version it built against.


That may well be the best solution going forward, but something else 
needs to be in place to prevent breakage for existing packages.




Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-06-29 Thread Andrew Bartlett
On Mon, 2020-06-29 at 08:46 -0400, Michael Stone wrote:
> Package: samba-libs
> Version: 2:4.12.3+dfsg-2
> Severity: critical
> Justification: breaks the whole system
> 
> The new samba-libs package changes the soname of libndr from
> libndr.so.0 to
> libndr.so.1 without reflecting this change in the package name. sssd-
> ad-common
> has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to
> libndr.so.0.
> When the samba-libs package is updated and libndr.so.0 disappears
> sssd fails to
> start, which then makes a system's remote users unavailable. (Worse,
> this
> doesn't happen until the next time sssd restarts--which may not be
> until the
> next reboot.)
> 
> It's not clear why the samba-libs package doesn't include the so
> number, but at
> the very least it needs a set of dependencies to avoid breaking sssd-
> ad-common.

We can't put a version number in samba-libs as there are multiple
public libraries in there.

(Upstream) Samba doesn't promise not to keep doing this - the
underlying change has happened before, but this time we were honest and
bumped the .so - so sssd may need to have a dependency on the Samba
version it built against. 

Andrew Bartlett

-- 
Andrew Bartlett   https://samba.org/~abartlet/
Authentication Developer, Samba Team  https://samba.org
Samba Developer, Catalyst IT  
https://catalyst.net.nz/services/samba



Bug#963971: samba-libs: libndr.so.0 gone from latest version, breaks sssd-ad-common dependency

2020-06-29 Thread Michael Stone
Package: samba-libs
Version: 2:4.12.3+dfsg-2
Severity: critical
Justification: breaks the whole system

The new samba-libs package changes the soname of libndr from libndr.so.0 to
libndr.so.1 without reflecting this change in the package name. sssd-ad-common
has a dependency on samba-libs (>= 2:4.11.5+dfsg) and links to libndr.so.0.
When the samba-libs package is updated and libndr.so.0 disappears sssd fails to
start, which then makes a system's remote users unavailable. (Worse, this
doesn't happen until the next time sssd restarts--which may not be until the
next reboot.)

It's not clear why the samba-libs package doesn't include the so number, but at
the very least it needs a set of dependencies to avoid breaking sssd-ad-common.