Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
On Tue, 14 Jul 2020, Olly Betts wrote: On Sat, Jul 11, 2020 at 11:31:51AM +0200, Michel Le Bihan wrote: I opened https://github.com/wxWidgets/wxWidgets/pull/1946. It is still very ugly, but at least the AUI caption text is readable. This has now been applied upstream as: https://github.com/wxWidgets/wxWidgets/commit/aae96a430609bacfa546f0a872cf1a94e8a0b073 Scott: Do you want to take care of this? Sure, can do. Scott
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
On Sat, Jul 11, 2020 at 11:31:51AM +0200, Michel Le Bihan wrote: > I opened https://github.com/wxWidgets/wxWidgets/pull/1946. It is still > very ugly, but at least the AUI caption text is readable. This has now been applied upstream as: https://github.com/wxWidgets/wxWidgets/commit/aae96a430609bacfa546f0a872cf1a94e8a0b073 Scott: Do you want to take care of this? Cheers, Olly
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
Hello, I opened https://github.com/wxWidgets/wxWidgets/pull/1946. It is still very ugly, but at least the AUI caption text is readable.
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
On Sat, 11 Jul 2020, Olly Betts wrote: In dark GTK themes the caption background correctly changes to the dark color, but the text stays black resulting in it being unreadable. The text color should also change. I opened a PR upstream https://github.com/wxWidgets/wxWidgets/pull/1791 and my changes got merged in https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c. I think that this change should be backported to the version of wxWidgets in testing because currently some wxWidgets apps are barely usable with a dark GTK theme. Has this patch been backported to upstream's WX_3_0_BRANCH branch? It's been so long since this branched that most patches against upstream master won't cleanly apply to 3.0.x, so while you've linked to a patch for this, that patch isn't actually usable as-is for the package because it doesn't apply cleanly: $ wget https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c.diff [...] $ patch -p1 < 1e25f0d966b7539fee93a67671f7834db38c3d5c.diff patching file src/aui/auibar.cpp Hunk #1 succeeded at 89 (offset 2 lines). Hunk #2 succeeded at 155 (offset 11 lines). Hunk #3 succeeded at 314 (offset -20 lines). Hunk #4 succeeded at 334 (offset -20 lines). Hunk #5 FAILED at 363. Hunk #6 succeeded at 432 (offset -25 lines). Hunk #7 succeeded at 451 (offset -25 lines). Hunk #8 FAILED at 501. Hunk #9 succeeded at 680 (offset -44 lines). 2 out of 9 hunks FAILED -- saving rejects to file src/aui/auibar.cpp.rej can't find file to patch at input line 130 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |diff --git a/src/aui/barartmsw.cpp b/src/aui/barartmsw.cpp |index 7958f810db2..878aafce5ae 100644 |--- a/src/aui/barartmsw.cpp |+++ b/src/aui/barartmsw.cpp -- File to patch: Skip this patch? [y] Skipping patch. 2 out of 2 hunks ignored patching file src/aui/dockart.cpp Hunk #1 FAILED at 324. 1 out of 1 hunk FAILED -- saving rejects to file src/aui/dockart.cpp.rej It's probably OK that src/aui/barartmsw.cpp doesn't exist from a Debian perspective, as from the name it's MSW-specific, but the failed hunks need sorting out. But overall I'd encourage getting this fixed in upstream's WX_3_0_BRANCH first (or linking to that commit if it's already backported). That way this gets fixed for all distros, not just Debian-based ones. Yeah, as I noted in my email, some methods are not even present in 3.0, such as IsDark(). I agree, it would be better if this was backported upstream first. Scott
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
On Fri, Jul 10, 2020 at 10:47:14PM +0200, Michel Le Bihan wrote: > In dark GTK themes the caption background correctly changes to the dark color, > but the text stays black resulting in it being unreadable. The text color > should also change. > > I opened a PR upstream https://github.com/wxWidgets/wxWidgets/pull/1791 and my > changes got merged in > https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c. > I think that this change should be backported to the version of wxWidgets in > testing because currently some wxWidgets apps are barely usable with a dark > GTK > theme. Has this patch been backported to upstream's WX_3_0_BRANCH branch? It's been so long since this branched that most patches against upstream master won't cleanly apply to 3.0.x, so while you've linked to a patch for this, that patch isn't actually usable as-is for the package because it doesn't apply cleanly: $ wget https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c.diff [...] $ patch -p1 < 1e25f0d966b7539fee93a67671f7834db38c3d5c.diff patching file src/aui/auibar.cpp Hunk #1 succeeded at 89 (offset 2 lines). Hunk #2 succeeded at 155 (offset 11 lines). Hunk #3 succeeded at 314 (offset -20 lines). Hunk #4 succeeded at 334 (offset -20 lines). Hunk #5 FAILED at 363. Hunk #6 succeeded at 432 (offset -25 lines). Hunk #7 succeeded at 451 (offset -25 lines). Hunk #8 FAILED at 501. Hunk #9 succeeded at 680 (offset -44 lines). 2 out of 9 hunks FAILED -- saving rejects to file src/aui/auibar.cpp.rej can't find file to patch at input line 130 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |diff --git a/src/aui/barartmsw.cpp b/src/aui/barartmsw.cpp |index 7958f810db2..878aafce5ae 100644 |--- a/src/aui/barartmsw.cpp |+++ b/src/aui/barartmsw.cpp -- File to patch: Skip this patch? [y] Skipping patch. 2 out of 2 hunks ignored patching file src/aui/dockart.cpp Hunk #1 FAILED at 324. 1 out of 1 hunk FAILED -- saving rejects to file src/aui/dockart.cpp.rej It's probably OK that src/aui/barartmsw.cpp doesn't exist from a Debian perspective, as from the name it's MSW-specific, but the failed hunks need sorting out. But overall I'd encourage getting this fixed in upstream's WX_3_0_BRANCH first (or linking to that commit if it's already backported). That way this gets fixed for all distros, not just Debian-based ones. Cheers, Olly
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
Package: libwxgtk3.0-gtk3-0v5 Version: 3.0.5.1+dfsg-1 Severity: normal Tags: patch Hello, In dark GTK themes the caption background correctly changes to the dark color, but the text stays black resulting in it being unreadable. The text color should also change. I opened a PR upstream https://github.com/wxWidgets/wxWidgets/pull/1791 and my changes got merged in https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c. I think that this change should be backported to the version of wxWidgets in testing because currently some wxWidgets apps are barely usable with a dark GTK theme. -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (700, 'testing'), (650, 'unstable'), (600, 'experimental'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages libwxgtk3.0-gtk3-0v5 depends on: ii libc62.30-8 ii libcairo21.16.0-4 ii libgcc-s110.1.0-4 ii libgdk-pixbuf2.0-0 2.40.0+dfsg-5 ii libgl1 1.3.1-1 ii libglib2.0-0 2.64.3-2 ii libgtk-3-0 3.24.20-1 ii libjpeg62-turbo 1:1.5.2-2+b1 ii libnotify4 0.7.9-1 ii libpango-1.0-0 1.44.7-4 ii libpangocairo-1.0-0 1.44.7-4 ii libpng16-16 1.6.37-2 ii libsm6 2:1.2.3-1 ii libstdc++6 10.1.0-4 ii libtiff5 4.1.0+git191117-2 ii libwxbase3.0-0v5 3.0.5.1+dfsg-1 ii libx11-6 2:1.6.9-2+b1 libwxgtk3.0-gtk3-0v5 recommends no packages. libwxgtk3.0-gtk3-0v5 suggests no packages. -- no debconf information
Bug#964820: libwxgtk3.0-gtk3-0v5: AUI caption text is dark on a dark background
On Fri, 10 Jul 2020, Michel Le Bihan wrote: In dark GTK themes the caption background correctly changes to the dark color, but the text stays black resulting in it being unreadable. The text color should also change. I opened a PR upstream https://github.com/wxWidgets/wxWidgets/pull/1791 and my changes got merged in https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c. I think that this change should be backported to the version of wxWidgets in testing because currently some wxWidgets apps are barely usable with a dark GTK theme. It appears the actual upstream commit is: https://github.com/wxWidgets/wxWidgets/commit/697bd0744159e8c0ded7fb4174eecbfa41700e7c I will look into it. It looks like it may take a bit more work to backport as, e.g., the IsDark() method doesn't exist in wx 3.0. Scott
